Issue 7992013: Merge 100031 - Modify the build recipe for nacl_helper_bootstrap to invoke the linker explicitly ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7992013: Merge 100031 - Modify the build recipe for nacl_helper_bootstrap to invoke the linker explicitly ... (Closed)

Created:
9 years, 3 months ago by Brad Chen

Modified:
9 years, 3 months ago

Reviewers:
Brad Chen

CC:
chromium-reviews, native-client-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/874/src/

Visibility:
Public.

Description

Merge 100031 - Modify the build recipe for nacl_helper_bootstrap to invoke the linker explicitly via an action rather than invoking via g++. This addresses build problems that occurred on certain developer machines. Also, modified tools/ld_bfd/ld script to find the loader within the Chrome OS build chroot. Also re-enable the nacl_helper. BUG=92964, nativeclient:480 TEST=nacl_integration tests on bots Review URL: http://codereview.chromium.org/7841008 TBR=bradchen@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102301

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -57 lines)			Patch
M	chrome/chrome_exe.gypi	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/nacl.gypi	View	3 chunks	+66 lines, -29 lines	0 comments	Download
M	chrome/nacl/nacl_fork_delegate_linux.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/ld_bfd/ld	View	1 chunk	+33 lines, -27 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages