Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: src/variables.cc

Issue 7992005: Block scoped const variables. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comments, function variable mode, preparser. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/variables.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 23 matching lines...) Expand all
34 namespace v8 { 34 namespace v8 {
35 namespace internal { 35 namespace internal {
36 36
37 // ---------------------------------------------------------------------------- 37 // ----------------------------------------------------------------------------
38 // Implementation Variable. 38 // Implementation Variable.
39 39
40 const char* Variable::Mode2String(VariableMode mode) { 40 const char* Variable::Mode2String(VariableMode mode) {
41 switch (mode) { 41 switch (mode) {
42 case VAR: return "VAR"; 42 case VAR: return "VAR";
43 case CONST: return "CONST"; 43 case CONST: return "CONST";
44 case CONST_HARMONY: return "CONST";
44 case LET: return "LET"; 45 case LET: return "LET";
45 case DYNAMIC: return "DYNAMIC"; 46 case DYNAMIC: return "DYNAMIC";
46 case DYNAMIC_GLOBAL: return "DYNAMIC_GLOBAL"; 47 case DYNAMIC_GLOBAL: return "DYNAMIC_GLOBAL";
47 case DYNAMIC_LOCAL: return "DYNAMIC_LOCAL"; 48 case DYNAMIC_LOCAL: return "DYNAMIC_LOCAL";
48 case INTERNAL: return "INTERNAL"; 49 case INTERNAL: return "INTERNAL";
49 case TEMPORARY: return "TEMPORARY"; 50 case TEMPORARY: return "TEMPORARY";
50 } 51 }
51 UNREACHABLE(); 52 UNREACHABLE();
52 return NULL; 53 return NULL;
53 } 54 }
(...skipping 19 matching lines...) Expand all
73 } 74 }
74 75
75 76
76 bool Variable::is_global() const { 77 bool Variable::is_global() const {
77 // Temporaries are never global, they must always be allocated in the 78 // Temporaries are never global, they must always be allocated in the
78 // activation frame. 79 // activation frame.
79 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope(); 80 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope();
80 } 81 }
81 82
82 } } // namespace v8::internal 83 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/variables.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698