Search prototypes for accessor setters if interceptor returns empty value.

src/objects.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1987 matching lines @@
   MUST_USE_RESULT MaybeObject* SetElementWithInterceptor(
       uint32_t index,
       Object* value,
       StrictModeFlag strict_mode,
       bool check_prototype);
   MUST_USE_RESULT MaybeObject* SetElementWithoutInterceptor(
       uint32_t index,
       Object* value,
       StrictModeFlag strict_mode,
       bool check_prototype);
 

[Rico, 2011/09/26 10:37:36]

Could we add a comment here stating that this may return found=true even if this
is giving back a failure, I at least had to convince myself that in case of GC
during the callwould always be safe. Also, this would be nice to know for other
callsites in the future (i.e., that even when found, they should check the
result if they do not immediately return it)

[ulan, 2011/09/26 12:56:07]

Done.

+  MUST_USE_RESULT MaybeObject* SetPropertyInPrototypes(

[Rico, 2011/09/26 10:37:36]

could we use a more descriptive name for this?
Like, SetPropertyWithCallbackSetterInPrototypes

[ulan, 2011/09/26 12:56:07]

Done.

+      String* name,
+      Object* value,
+      PropertyAttributes attributes,
+      bool* found,
+      StrictModeFlag strict_mode);
+
   MUST_USE_RESULT MaybeObject* DeletePropertyPostInterceptor(String* name,
                                                              DeleteMode mode);
   MUST_USE_RESULT MaybeObject* DeletePropertyWithInterceptor(String* name);
 
   MUST_USE_RESULT MaybeObject* DeleteElementWithInterceptor(uint32_t index);
 
   MUST_USE_RESULT MaybeObject* DeleteFastElement(uint32_t index);
   MUST_USE_RESULT MaybeObject* DeleteDictionaryElement(uint32_t index,
                                                        DeleteMode mode);
 
@@ skipping 5471 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_