Issue 799006: Math.abs rewrited to not use Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 799006: Math.abs rewrited to not use Runtime. (Closed)

Created:
10 years, 9 months ago by SeRya

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Math.abs rewrited to not use Runtime. Committed: http://code.google.com/p/v8/source/detail?r=4093

Patch Set 4 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -13 lines)			Patch
M	src/math.js	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1 2 3	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/v8-counters.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
A	test/mjsunit/abs.js	View	1 2 3	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/799006/diff/9001/3003 File test/mjsunit/abs.js (right): http://codereview.chromium.org/799006/diff/9001/3003#newcode1 test/mjsunit/abs.js:1: // Copyright 2009 the V8 project authors. All ...

10 years, 9 months ago (2010-03-11 07:48:25 UTC) #2

SeRya

10 years, 9 months ago (2010-03-11 08:30:44 UTC) #3

http://codereview.chromium.org/799006/diff/9001/3003
File test/mjsunit/abs.js (right):

http://codereview.chromium.org/799006/diff/9001/3003#newcode1
test/mjsunit/abs.js:1: // Copyright 2009 the V8 project authors. All rights
reserved.
On 2010/03/11 07:48:25, Mads Ager wrote:
> 2010

Done.

Expand Messages | Collapse Messages

Issue 799006: Math.abs rewrited to not use Runtime. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages