Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/user_style_sheet_watcher.h

Issue 799005: Connect UserStyleSheetWatcher to FileWatcher to have changes to (Closed)
Patch Set: rebase Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/user_style_sheet_watcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/user_style_sheet_watcher.h
diff --git a/chrome/browser/user_style_sheet_watcher.h b/chrome/browser/user_style_sheet_watcher.h
index 87fa5ce3fc1692d05179b8337e264e6ed3beec8e..14960a0defa10e8bfa4d5ae7e178b14b1067e0d5 100644
--- a/chrome/browser/user_style_sheet_watcher.h
+++ b/chrome/browser/user_style_sheet_watcher.h
@@ -9,17 +9,18 @@
#include "base/logging.h"
#include "base/ref_counted.h"
#include "chrome/browser/chrome_thread.h"
+#include "chrome/browser/file_watcher.h"
#include "chrome/common/notification_observer.h"
#include "chrome/common/notification_registrar.h"
#include "googleurl/src/gurl.h"
// This loads the user style sheet on the file thread and sends a notification
// when the style sheet is loaded.
-// TODO(tony): Watch for file changes and send a notification of the update.
class UserStyleSheetWatcher
: public base::RefCountedThreadSafe<UserStyleSheetWatcher,
ChromeThread::DeleteOnUIThread>,
- public NotificationObserver {
+ public NotificationObserver,
+ public FileWatcher::Delegate {
public:
explicit UserStyleSheetWatcher(const FilePath& profile_path);
virtual ~UserStyleSheetWatcher() {}
@@ -35,6 +36,9 @@ class UserStyleSheetWatcher
const NotificationSource& source,
const NotificationDetails& details);
+ // FileWatcher::Delegate interface
+ virtual void OnFileChanged(const FilePath& path);
+
private:
// Load the user style sheet on the file thread and convert it to a
// base64 URL. Posts the base64 URL back to the UI thread.
@@ -42,12 +46,15 @@ class UserStyleSheetWatcher
void SetStyleSheet(const GURL& url);
- // The directory containing the User StyleSheet.
+ // The directory containing User StyleSheets/Custom.css.
FilePath profile_path_;
// The user style sheet as a base64 data:// URL.
GURL user_style_sheet_;
+ // Watches for changes to the css file so we can reload the style sheet.
+ scoped_ptr<FileWatcher> file_watcher_;
+
NotificationRegistrar registrar_;
bool has_loaded_;
« no previous file with comments | « no previous file | chrome/browser/user_style_sheet_watcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698