Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 7989013: Actually, it's filtering by reviews that is useful, clean up the code accordingly (Closed)

Created:
9 years, 3 months ago by M-A Ruel
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Actually, it's filtering by reviews that is useful, clean up the code accordingly It's now live on codereview.appspot, codereview.chromium and the internal instance so it's far more easier to get review stats now. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102331

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comment #

Patch Set 3 : rebase against head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -31 lines) Patch
M my_reviews.py View 1 2 5 chunks +45 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
9 years, 3 months ago (2011-09-22 17:21:15 UTC) #1
M-A Ruel
And this one, this is the follow up of http://codereview.chromium.org/7991002/
9 years, 3 months ago (2011-09-22 17:42:46 UTC) #2
Peter Mayo
LGTM I don't know if anyone will miss the -o. http://codereview.chromium.org/7989013/diff/1/my_reviews.py File my_reviews.py (right): http://codereview.chromium.org/7989013/diff/1/my_reviews.py#newcode139 ...
9 years, 3 months ago (2011-09-22 19:01:05 UTC) #3
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel%40chromium.org/7989013/1004
9 years, 3 months ago (2011-09-22 19:16:42 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 19:22:26 UTC) #5
Change committed as 102331

Powered by Google App Engine
This is Rietveld 408576698