Remove use of default request context and fix use of speech censor flag

content/browser/speech/speech_input_preferences.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_SPEECH_SPEECH_INPUT_PREFERENCES_H_
+#define CONTENT_BROWSER_SPEECH_SPEECH_INPUT_PREFERENCES_H_
+#pragma once
+
+#include "base/memory/ref_counted.h"
+#include "content/common/content_export.h"
+
+class CONTENT_EXPORT SpeechInputPreferences
+    : public base::RefCountedThreadSafe<SpeechInputPreferences> {
+ public:
+  SpeechInputPreferences(bool censor_results);

[Satish, 2011/09/23 16:31:54]

instead of passing the option values in the constructor, can we pass the Pref
store pointer? That will allow us to easily add new prefs later while not
changing this interface.. only the code in this object will change.

[allanwoj, 2011/09/26 13:05:15]

Made a chrome class to do this.

+  ~SpeechInputPreferences();
+
+  bool censor_results() const;

[Satish, 2011/09/23 16:31:54]

perhaps add a mention that all accessors can only be called from the IO thread

[allanwoj, 2011/09/26 13:05:15]

Done.

+  void set_censor_results(bool censor_results);
+
+ private:
+  friend class base::RefCountedThreadSafe<SpeechInputPreferences>;
+
+  bool censor_results_;

[Satish, 2011/09/23 16:31:54]

since this object is used across threads, we should either have a mutex to guard
the variables or access the variables only in one thread. I suggest the latter.
So add a comment here mentioning all vars should be accessed/modified only from
the IO thread.

[allanwoj, 2011/09/26 13:05:15]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(SpeechInputPreferences);
+};
+
+#endif  // CONTENT_BROWSER_SPEECH_SPEECH_INPUT_PREFERENCES_H_