Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 7988012: Clarify the variable names and reorder assignments to be more consistent. (Closed)

Created:
9 years, 3 months ago by M-A Ruel
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Clarify the variable names and reorder assignments to be more consistent. Enforce a reviewer, when $EMAIL_ADDRESS is not set BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102340

Patch Set 1 #

Patch Set 2 : Enforce -r #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M my_reviews.py View 1 3 chunks +30 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Reviewer is whoever is the first. It's much more readable this way in fact, thanks ...
9 years, 3 months ago (2011-09-22 19:27:50 UTC) #1
M-A Ruel
(Updated description)
9 years, 3 months ago (2011-09-22 19:36:24 UTC) #2
nsylvain
lgtm
9 years, 3 months ago (2011-09-22 20:00:58 UTC) #3
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/7988012/2001
9 years, 3 months ago (2011-09-22 20:09:27 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 20:15:08 UTC) #5
Change committed as 102340

Powered by Google App Engine
This is Rietveld 408576698