Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: webkit/plugins/ppapi/ppb_url_loader_impl.h

Issue 7988005: Merge 101524 - Don't try to call setDefersLoading when the loader is null. This does a bit of cle... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/874/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppb_url_loader_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_url_loader_impl.h
===================================================================
--- webkit/plugins/ppapi/ppb_url_loader_impl.h (revision 102278)
+++ webkit/plugins/ppapi/ppb_url_loader_impl.h (working copy)
@@ -117,6 +117,10 @@
bool RecordDownloadProgress() const;
bool RecordUploadProgress() const;
+ // Calls SetDefersLoading on the current load. This encapsulates the logic
+ // differences between document loads and regular ones.
+ void SetDefersLoading(bool defers_loading);
+
void FinishLoading(int32_t done_status);
// If true, then the plugin instance is a full-frame plugin and we're just
@@ -128,7 +132,15 @@
// change the request info resource out from under us.
::ppapi::PPB_URLRequestInfo_Data request_data_;
+ // The loader associated with this request. MAY BE NULL.
+ //
+ // This will be NULL if the load hasn't been opened yet, or if this is a main
+ // document loader (when registered as a mime type). Therefore, you should
+ // always NULL check this value before using it. In the case of a main
+ // document load, you would call the functions on the document to cancel the
+ // load, etc. since there is no loader.
scoped_ptr<WebKit::WebURLLoader> loader_;
+
scoped_refptr<PPB_URLResponseInfo_Impl> response_info_;
scoped_refptr<TrackedCompletionCallback> pending_callback_;
std::deque<char> buffer_;
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppb_url_loader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698