aura: Fix a crash when moving mouse over the empty space on the root window.

aura: Fix a crash when moving mouse over the empty space on the root window.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102109

[sadrul, 2011-09-21 14:24:39]

http://codereview.chromium.org/7986001/diff/1/ui/aura/root_window.cc
File ui/aura/root_window.cc (right):

http://codereview.chromium.org/7986001/diff/1/ui/aura/root_window.cc#newcode30
ui/aura/root_window.cc:30: target = GetEventHandlerForPoint(event.location());
Or may be return early if target is NULL here?

[Ben Goodger (Google), 2011-09-21 14:58:00]

LGTM

On Wed, Sep 21, 2011 at 7:24 AM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
>
>
http://codereview.chromium.**org/7986001/diff/1/ui/aura/**root_window.cc<http...
> File ui/aura/root_window.cc (right):
>
> http://codereview.chromium.**org/7986001/diff/1/ui/aura/**
>
root_window.cc#newcode30<http://codereview.chromium.org/7986001/diff/1/ui/aura/root_window.cc#newcode30>
> ui/aura/root_window.cc:30: target =
> GetEventHandlerForPoint(event.**location());
> Or may be return early if target is NULL here?
>
> Description:
> aura: Fix a crash when moving mouse over the empty space on the root
> window.
>
> BUG=none
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/7986001/<http://codereview.chromium.org/7986...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/aura/root_window.cc
>
>
> Index: ui/aura/root_window.cc
> diff --git a/ui/aura/root_window.cc b/ui/aura/root_window.cc
> index 9c50a2cf801ca0b2bb1b779fdf28aa**3e29316363..**
> f6b6b0256473aa4ea699523d851e79**3262b945a1 100644
> --- a/ui/aura/root_window.cc
> +++ b/ui/aura/root_window.cc
> @@ -32,7 +32,7 @@ bool RootWindow::HandleMouseEvent(**const MouseEvent&
> event) {
>     mouse_pressed_handler_ = target;
>   if (event.type() == ui::ET_MOUSE_RELEASED)
>     mouse_pressed_handler_ = NULL;
> -  if (target->delegate()) {
> +  if (target && target->delegate()) {
>     MouseEvent translated_event(event, this, target);
>     return target->OnMouseEvent(&**translated_event);
>   }
>
>
>