src/x64/deoptimizer-x64.cc - Issue 7983045: Notify collector about lazily deoptimized code objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/deoptimizer-x64.cc

Issue 7983045: Notify collector about lazily deoptimized code objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: clear lo from rescan flag, avoid ShouldSweepLazily predicate in preparation Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/deoptimizer-x64.cc

diff --git a/src/x64/deoptimizer-x64.cc b/src/x64/deoptimizer-x64.cc

index 9e312ef3838f406f0443abb6fd8f6a760e0e53f5..0733602f1a9f063ac33c10e5942e8544b9b0f671 100644

--- a/src/x64/deoptimizer-x64.cc

+++ b/src/x64/deoptimizer-x64.cc

@@ -204,6 +204,11 @@ void Deoptimizer::DeoptimizeFunction(JSFunction* function) {

node->set_next(data->deoptimizing_code_list_);

data->deoptimizing_code_list_ = node;

+ // We might be in the middle of incremental marking with compaction.

+ // Tell collector to treat this code object in a special way and

+ // ignore all slots that might have been recorded on it.

+ isolate->heap()->mark_compact_collector()->InvalidateCode(code);

// Set the code for the function to non-optimized version.

function->ReplaceCode(function->shared()->code());