Notify collector about lazily deoptimized code objects.

src/spaces.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1912 matching lines @@
   // skipped when scanning the heap.
   int old_linear_size = static_cast<int>(limit() - top());
   Free(top(), old_linear_size);
   SetTop(NULL, NULL);
 
   // Stop lazy sweeping and clear marking bits for unswept pages.
   if (first_unswept_page_ != NULL) {
     Page* last = last_unswept_page_->next_page();
     Page* p = first_unswept_page_;
     do {
-      if (ShouldBeSweptLazily(p)) {
-        ASSERT(!p->WasSwept());
+      // Do not use ShouldBeSweptLazily predicate here.
+      // New evacuation candidates were selected but they still have
+      // to be swept before collection starts.
+      if (!p->WasSwept()) {

[Vyacheslav Egorov (Chromium), 2011/09/22 15:30:11]

The same regression test revealed a bug here.

We should not use ShouldBeSweptLazily here because it skips evacuation
candidates. 

But _new_ evacuation candidates are already selected when we call
PrepareForMarkCompact (happens only with --always-compact) and they _have_ to be
swept before the GC.

         Bitmap::Clear(p);
         if (FLAG_gc_verbose) {
           PrintF("Sweeping 0x%" V8PRIxPTR " lazily abandoned.\n",
                  reinterpret_cast<intptr_t>(p));
         }
       }
       p = p->next_page();
     } while (p != last);
   }
   first_unswept_page_ = last_unswept_page_ = Page::FromAddress(NULL);
@@ skipping 575 matching lines @@
     object->ShortPrint();
     PrintF("\n");
   }
   printf(" --------------------------------------\n");
   printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes());
 }
 
 #endif  // DEBUG
 
 } }  // namespace v8::internal