Issue 7983042: CrOS: Add Discard Tab command link to about:discards

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7983042: CrOS: Add Discard Tab command link to about:discards (Closed)

Created:
9 years, 3 months ago by James Cook

Modified:
9 years, 3 months ago

Reviewers:
Greg Spencer (Chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

CrOS: Add Discard Tab command link to about:discards Work in process on discarding a tab (for low memory conditions on CrOS). Also clean up the strings we use to describe system memory, and eliminate memory as an input for "interestingness" of tabs, since the OOM killer already includes memory as an input. BUG=none TEST=Open "about:discards". Click the "Discard Tab Now" link - the tab at the bottom of the list should close. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102397

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -124 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View		3 chunks	+17 lines, -10 lines	0 comments	Download
M	chrome/browser/oom_priority_manager.h	View	1 2	4 chunks	+25 lines, -24 lines	0 comments	Download
M	chrome/browser/oom_priority_manager.cc	View	1 2	8 chunks	+94 lines, -90 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Cook

Greg, PTAL. I think I'd like to commit this, then start on the internals of ...

9 years, 3 months ago (2011-09-22 20:46:39 UTC) #1

LGTM

Expand Messages | Collapse Messages

Issue 7983042: CrOS: Add Discard Tab command link to about:discards (Closed)

Description

Patch Set 1 #

Patch Set 2 : actually close a tab now #

Patch Set 3 : strip memory as a factor, actually close a tab #

Patch Set 4 : revert tab_strip_model.h #

Messages