Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 7983037: Revert 102126 - Make cancel remove cancelled download from active queues at time of cancel. (Closed)

Created:
9 years, 3 months ago by Randy Smith (Not in Mondays)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, asanka, cbentzel+watch_chromium.org, jennb, tbarzic+watch_chromium.org, kkania, dpranke+watch-content_chromium.org, jam, Dmitry Titov, dcheng, prasadt, joi+watch-content_chromium.org, achuith+watch_chromium.org, darin-cc_chromium.org, jianli, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., Randy Smith (Not in Mondays)
Visibility:
Public.

Description

Revert 102126 - Make cancel remove cancelled download from active queues at time of cancel. Also add various tests required or enabled by this change. This changes two aspects of Cancel semantics (for downloads, not save page): a) Cancel can now be called anytime during the lifetime of a download, and b) if it is called before the history callback occurs, the download will be removed from the system (no where to store it persistently while waiting) BUG=85408 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101510 Review URL: http://codereview.chromium.org/7796014 TBR=rdsmith@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -765 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 21 chunks +142 lines, -540 lines 0 comments Download
M chrome/browser/download/download_history.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/download/download_history.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/download-dangerous.jar View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/download-dangerous.jar.mock-http-headers View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/download/download_item.h View 3 chunks +15 lines, -15 lines 0 comments Download
M content/browser/download/download_item.cc View 4 chunks +19 lines, -49 lines 0 comments Download
M content/browser/download/download_manager.h View 4 chunks +20 lines, -23 lines 0 comments Download
M content/browser/download/download_manager.cc View 10 chunks +67 lines, -45 lines 0 comments Download
M content/browser/download/download_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_request_handle.h View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/download/download_stats.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/download/mock_download_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mock_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/url_request_slow_download_job.h View 3 chunks +6 lines, -13 lines 0 comments Download
M content/browser/net/url_request_slow_download_job.cc View 8 chunks +15 lines, -36 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Randy Smith (Not in Mondays)
9 years, 3 months ago (2011-09-21 18:29:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698