Issue 7983032: Add NPChannelBase::GetModalDialogEvent() to avoid content/plugin/ include from npobject_proxy.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7983032: Add NPChannelBase::GetModalDialogEvent() to avoid content/plugin/ include from npobject_proxy.cc (Closed)

Created:
9 years, 3 months ago by Steve Block

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add NPChannelBase::GetModalDialogEvent() to avoid content/plugin/ include from npobject_proxy.cc This patch adds a new virtual method NPChannelBase::GetModalDialogEvent() to avoid the need for NPObjectProxy to cast its NPChannelBase to PluginChannel. Refactoring only, no functional change. BUG=96703 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102212

Patch Set 1 #

Patch Set 2 : Rebased after http://codereview.chromium.org/7982026 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -21 lines)			Patch
M	content/common/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/np_channel_base.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/common/np_channel_base.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/common/npobject_proxy.cc	View		4 chunks	+10 lines, -19 lines	0 comments	Download
M	content/plugin/plugin_channel.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 102212

Expand Messages | Collapse Messages