Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3184)

Unified Diff: chrome/renderer/autofill/form_cache.h

Issue 7983028: Don't cache WebFrame pointers for Autofill, as these can become stale. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/autofill/form_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/form_cache.h
diff --git a/chrome/renderer/autofill/form_cache.h b/chrome/renderer/autofill/form_cache.h
index 5bfe461f23790e88674d165d95668c1e5e76eb91..8173ab14c4673dce23b4c26152f07fb74e4c7d9f 100644
--- a/chrome/renderer/autofill/form_cache.h
+++ b/chrome/renderer/autofill/form_cache.h
@@ -18,6 +18,7 @@ struct FormDataPredictions;
} // namespace webkit_glue
namespace WebKit {
+class WebDocument;
class WebFormControlElement;
class WebFrame;
class WebInputElement;
@@ -52,7 +53,7 @@ class FormCache {
private:
// The cached web frames.
- std::set<const WebKit::WebFrame*> web_frames_;
+ std::set<WebKit::WebDocument> web_documents_;
// The cached initial values for <select> elements.
std::map<const WebKit::WebSelectElement, string16> initial_select_values_;
« no previous file with comments | « no previous file | chrome/renderer/autofill/form_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698