Issue 7983022: Reland 102005 and 102009: aura: Explicitly disable GTK.

Issue 7983022: Reland 102005 and 102009: aura: Explicitly disable GTK. (Closed)

Created:
9 years, 3 months ago by sadrul

Modified:
9 years, 3 months ago

Reviewers:
tfarina

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Reland 102005 and 102009: aura: Explicitly disable GTK. Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components. TBR=evan@chromium.org BUG=97131 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102058

Patch Set 1 #

Patch Set 2 : arm fix? #

Patch Set 3 : . #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -93 lines)			Patch
M	base/base.gyp	View		3 chunks	+12 lines, -7 lines	0 comments	Download
M	base/base.gypi	View		4 chunks	+17 lines, -6 lines	0 comments	Download
M	base/message_loop.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/message_pump_glib_unittest.cc	View		7 chunks	+16 lines, -3 lines	0 comments	Download
M	base/message_pump_x.h	View		5 chunks	+26 lines, -17 lines	0 comments	Download
M	base/message_pump_x.cc	View		9 chunks	+73 lines, -39 lines	0 comments	Download
M	build/build_config.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View	1 2	2 chunks	+10 lines, -6 lines	0 comments	Download
M	build/linux/system.gyp	View	1	1 chunk	+37 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

did you compile this on Linux with toolkit_views=1 and use_aura=1? It fails for me: ./ui/gfx/native_widget_types.h:133:9: ...

9 years, 3 months ago (2011-09-21 01:57:44 UTC) #1

sadrul

9 years, 3 months ago (2011-09-21 02:05:18 UTC) #2

On 2011/09/21 01:57:44, tfarina wrote:
> did you compile this on Linux with toolkit_views=1 and use_aura=1?
> 
> It fails for me:
> 
> ./ui/gfx/native_widget_types.h:133:9: error: ‘PangoFontDescription’ does not
> name a type
> ./ui/gfx/native_widget_types.h:134:9: error: ‘GtkWidget’ does not name a type
> ./ui/gfx/native_widget_types.h:135:9: error: ‘cairo_t’ does not name a type
> ./ui/gfx/native_widget_types.h:136:9: error: ‘GdkCursor’ does not name a type
> ./ui/gfx/native_widget_types.h:137:9: error: ‘GtkWidget’ does not name a type
> ./ui/gfx/native_widget_types.h:138:9: error: ‘GdkRegion’ does not name a type

The purpose of this bug (97131)/ CL is to start with base, and then move upwards
in the dependency tree until we can build at least aura_shell without GTK.
Subsequent CLs: http://codereview.chromium.org/7944011/
http://codereview.chromium.org/7963001/

I am currently working on another CL to have 'ui' build without GTK. Once that
happens, we should be able to build aura and aura_shell again.

With this CL, the expectation is that base_unittests will build. aura/aura_shell
will be buildable Really Soon Now (is the expectation!)

Expand Messages | Collapse Messages