Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 7983018: gtk: swallow spurious error (Closed)

Created:
9 years, 3 months ago by Evan Martin
Modified:
9 years, 3 months ago
Reviewers:
tony
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam
Visibility:
Public.

Description

gtk: swallow spurious error We promote GTK errors into DFATALs. Some versions of GTK accidentally call it an error to not have an environment variable set. They fixed this on GTK trunk, but we shouldn't die on Ubuntu releases that don't have the fix. BUG=97293 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/browser_main.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
9 years, 3 months ago (2011-09-20 20:30:38 UTC) #1
tony
9 years, 3 months ago (2011-09-20 21:17:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698