Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 7983005: Fix the issue on extension API that extension ID should be converted to app name when it is passe... (Closed)

Created:
9 years, 3 months ago by jianli
Modified:
9 years, 3 months ago
Reviewers:
stevenjb, jennb
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Fix the issue on extension API that extension ID should be converted to app name when it is passed to the Browser. BUG=none TEST=Manual test by opening a panel via extension API and clicking on settings button Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/extensions/extension_tabs_module.cc View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jianli
9 years, 3 months ago (2011-09-20 17:17:15 UTC) #1
jennb
I'm surprised that no other popups opened by extensions have hit this bug. Are you ...
9 years, 3 months ago (2011-09-20 17:30:24 UTC) #2
jianli
I fixed the similar issue some time ago. We need to package the extension id ...
9 years, 3 months ago (2011-09-20 17:50:21 UTC) #3
jennb
LGTM Thanks for reminding me of the related fix in http://codereview.chromium.org/7249013
9 years, 3 months ago (2011-09-20 17:52:52 UTC) #4
stevenjb
9 years, 3 months ago (2011-09-20 22:54:45 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698