Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: chrome/browser/sync/js/js_transaction_observer.cc

Issue 7982049: [Sync] Move some code into new class JsMutationEventObserver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix deps Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/js/js_transaction_observer.h ('k') | chrome/browser/sync/syncable/syncable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/js/js_transaction_observer.cc
diff --git a/chrome/browser/sync/js/js_transaction_observer.cc b/chrome/browser/sync/js/js_transaction_observer.cc
deleted file mode 100644
index e27133655f3855cb494c7c9c831169fb03b41f2b..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/js/js_transaction_observer.cc
+++ /dev/null
@@ -1,89 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/sync/js/js_transaction_observer.h"
-
-#include <string>
-
-#include "base/location.h"
-#include "base/logging.h"
-#include "base/string_number_conversions.h"
-#include "base/values.h"
-#include "chrome/browser/sync/js/js_event_details.h"
-#include "chrome/browser/sync/js/js_event_handler.h"
-
-namespace browser_sync {
-
-JsTransactionObserver::JsTransactionObserver() {}
-
-JsTransactionObserver::~JsTransactionObserver() {
- DCHECK(non_thread_safe_.CalledOnValidThread());
-}
-
-void JsTransactionObserver::SetJsEventHandler(
- const WeakHandle<JsEventHandler>& event_handler) {
- event_handler_ = event_handler;
-}
-
-void JsTransactionObserver::OnTransactionStart(
- const tracked_objects::Location& location,
- const syncable::WriterTag& writer) {
- DCHECK(non_thread_safe_.CalledOnValidThread());
- if (!event_handler_.IsInitialized()) {
- return;
- }
- DictionaryValue details;
- details.SetString("location", location.ToString());
- details.SetString("writer", syncable::WriterTagToString(writer));
- HandleJsEvent(FROM_HERE, "onTransactionStart", JsEventDetails(&details));
-}
-
-namespace {
-
-// Max number of mutations we attempt to convert to values (to avoid
-// running out of memory).
-const size_t kMutationLimit = 300;
-
-} // namespace
-
-void JsTransactionObserver::OnTransactionWrite(
- const syncable::ImmutableWriteTransactionInfo& write_transaction_info,
- const syncable::ModelTypeBitSet& models_with_changes) {
- DCHECK(non_thread_safe_.CalledOnValidThread());
- if (!event_handler_.IsInitialized()) {
- return;
- }
- DictionaryValue details;
- details.Set("writeTransactionInfo",
- write_transaction_info.Get().ToValue(kMutationLimit));
- details.Set("modelsWithChanges",
- syncable::ModelTypeBitSetToValue(models_with_changes));
- HandleJsEvent(FROM_HERE, "onTransactionMutate", JsEventDetails(&details));
-}
-
-void JsTransactionObserver::OnTransactionEnd(
- const tracked_objects::Location& location,
- const syncable::WriterTag& writer) {
- DCHECK(non_thread_safe_.CalledOnValidThread());
- if (!event_handler_.IsInitialized()) {
- return;
- }
- DictionaryValue details;
- details.SetString("location", location.ToString());
- details.SetString("writer", syncable::WriterTagToString(writer));
- HandleJsEvent(FROM_HERE, "onTransactionEnd", JsEventDetails(&details));
-}
-
-void JsTransactionObserver::HandleJsEvent(
- const tracked_objects::Location& from_here,
- const std::string& name, const JsEventDetails& details) {
- if (!event_handler_.IsInitialized()) {
- NOTREACHED();
- return;
- }
- event_handler_.Call(from_here,
- &JsEventHandler::HandleJsEvent, name, details);
-}
-
-} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/js/js_transaction_observer.h ('k') | chrome/browser/sync/syncable/syncable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698