Issue 7982049: [Sync] Move some code into new class JsMutationEventObserver

Issue 7982049: [Sync] Move some code into new class JsMutationEventObserver (Closed)

Created:
9 years, 3 months ago by akalin

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, arv (Not doing code reviews), Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Move some code into new class JsMutationEventObserver Move JsTransactionObserver code into JsMutationEventObserver. Move ChangeObserver methods of JsSyncManagerObserver to JsMutationEventObserver. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102414

Patch Set 1 #

Patch Set 2 : Fix deps #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+290 lines, -309 lines)			Patch
M	chrome/browser/resources/sync_internals/chrome_sync.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/internal_api/sync_manager.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
A +	chrome/browser/sync/js/js_mutation_event_observer.h	View		4 chunks	+19 lines, -8 lines	0 comments	Download
A	chrome/browser/sync/js/js_mutation_event_observer.cc	View		1 chunk	+129 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/js/js_mutation_event_observer_unittest.cc	View	1	1 chunk	+127 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/js/js_sync_manager_observer.h	View		1 chunk	+1 line, -10 lines	0 comments	Download
M	chrome/browser/sync/js/js_sync_manager_observer.cc	View		1 chunk	+0 lines, -48 lines	0 comments	Download
M	chrome/browser/sync/js/js_sync_manager_observer_unittest.cc	View		3 chunks	+0 lines, -83 lines	0 comments	Download
D	chrome/browser/sync/js/js_transaction_observer.h	View		1 chunk	+0 lines, -59 lines	0 comments	Download
D	chrome/browser/sync/js/js_transaction_observer.cc	View		1 chunk	+0 lines, -89 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/7982049/1

9 years, 3 months ago (2011-09-23 00:14:40 UTC) #3

commit-bot: I haz the power

9 years, 3 months ago (2011-09-23 00:48:38 UTC) #4

Try job failure for 7982049-1 (retry) on linux_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages