Fix Chromoting Mac to work with multiple monitors.

Fix Chromoting Mac to work with multiple monitors.


BUG=96742
TEST=See bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102190

[dmac, 2011-09-21 20:22:50]

PTAL.

Stupidly simple once I knew where to look.

[Jamie, 2011-09-21 20:27:44]

Reminds me of the old story of an itemized bill from an engineer: "Tightening a
screw: $1; Knowing which screw to tighten: $9,999"

LGTM

[commit-bot: I haz the power, 2011-09-21 23:15:05]

Change committed as 102190

[Wez, 2011-09-22 10:41:18]

How does this CL fix the multi-monitor case?

It looks to be fixing the blit routines to not try to blit empty rectangles from
the old buffer to the new?

[dmaclach1, 2011-09-22 14:39:25]

Turns out that intersect on skia rectangles doesn't quite do what you expect.

if you have rect x and rect y and you call x.intersect(y), x will be
set to the intersection of x and y IFF there is an intersection.
Otherwise it leaves x alone and returns false. so if x (our copy area)
did not intersect at all with y (our clip area) at all, we were still
trying to copy it, it just didn't get clipped.

Cheers,
Dave

On Thu, Sep 22, 2011 at 03:41,  <wez@chromium.org> wrote:
> How does this CL fix the multi-monitor case?
>
> It looks to be fixing the blit routines to not try to blit empty rectangles
> from
> the old buffer to the new?
>
>
> http://codereview.chromium.org/7982037/
>