Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: content/browser/gpu/gpu_blacklist_unittest.cc

Issue 7982034: Add a "disabled" field for GPU Blacklist entries. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/gpu_blacklist.cc ('k') | content/browser/gpu/gpu_data_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_blacklist_unittest.cc
===================================================================
--- content/browser/gpu/gpu_blacklist_unittest.cc (revision 102158)
+++ content/browser/gpu/gpu_blacklist_unittest.cc (working copy)
@@ -144,12 +144,13 @@
flags.flags(),
static_cast<uint32>(GpuFeatureFlags::kGpuFeatureAcceleratedCompositing));
std::vector<uint32> entries;
+ bool disabled = false;
blacklist.GetGpuFeatureFlagEntries(
- GpuFeatureFlags::kGpuFeatureAcceleratedCompositing, entries);
+ GpuFeatureFlags::kGpuFeatureAcceleratedCompositing, entries, disabled);
EXPECT_EQ(entries.size(), 1u);
EXPECT_EQ(entries[0], 5u);
blacklist.GetGpuFeatureFlagEntries(
- GpuFeatureFlags::kGpuFeatureAll, entries);
+ GpuFeatureFlags::kGpuFeatureAll, entries, disabled);
EXPECT_EQ(entries.size(), 1u);
EXPECT_EQ(entries[0], 5u);
EXPECT_EQ(blacklist.max_entry_id(), 5u);
@@ -725,3 +726,37 @@
static_cast<uint32>(GpuFeatureFlags::kGpuFeatureWebgl));
}
+TEST_F(GpuBlacklistTest, DisabledEntry) {
+ const std::string disabled_json =
+ "{\n"
+ " \"name\": \"gpu blacklist\",\n"
+ " \"version\": \"0.1\",\n"
+ " \"entries\": [\n"
+ " {\n"
+ " \"id\": 1,\n"
+ " \"disabled\": true,\n"
+ " \"blacklist\": [\n"
+ " \"webgl\"\n"
+ " ]\n"
+ " }\n"
+ " ]\n"
+ "}";
+ scoped_ptr<Version> os_version(Version::GetVersionFromString("10.6.4"));
+
+ GpuBlacklist blacklist("1.0 unknown");
+ EXPECT_TRUE(
+ blacklist.LoadGpuBlacklist(disabled_json, GpuBlacklist::kAllOs));
+ GpuFeatureFlags flags = blacklist.DetermineGpuFeatureFlags(
+ GpuBlacklist::kOsWin, os_version.get(), gpu_info());
+ EXPECT_EQ(flags.flags(), 0u);
+ std::vector<uint32> flag_entries;
+ bool disabled = false;
+ blacklist.GetGpuFeatureFlagEntries(
+ GpuFeatureFlags::kGpuFeatureAll, flag_entries, disabled);
+ EXPECT_EQ(flag_entries.size(), 0u);
+ disabled = true;
+ blacklist.GetGpuFeatureFlagEntries(
+ GpuFeatureFlags::kGpuFeatureAll, flag_entries, disabled);
+ EXPECT_EQ(flag_entries.size(), 1u);
+}
+
« no previous file with comments | « content/browser/gpu/gpu_blacklist.cc ('k') | content/browser/gpu/gpu_data_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698