Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: content/browser/gpu/gpu_blacklist.h

Issue 7982034: Add a "disabled" field for GPU Blacklist entries. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/software_rendering_list.json ('k') | content/browser/gpu/gpu_blacklist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_blacklist.h
===================================================================
--- content/browser/gpu/gpu_blacklist.h (revision 102158)
+++ content/browser/gpu/gpu_blacklist.h (working copy)
@@ -59,15 +59,18 @@
Version* os_version,
const GPUInfo& gpu_info);
- // Collects the entries that set the "feature" flag from the last
+ // Collects the active entries that set the "feature" flag from the last
// DetermineGpuFeatureFlags() call. This tells which entries are responsible
// for raising a certain flag, i.e, for blacklisting a certain feature.
// Examples of "feature":
// kGpuFeatureAll - any of the supported features;
// kGpuFeatureWebgl - a single feature;
// kGpuFeatureWebgl | kGpuFeatureAcceleratedCompositing - two features.
+ // If disabled set to true, return entries that are disabled; otherwise,
+ // return enabled entries.
void GetGpuFeatureFlagEntries(GpuFeatureFlags::GpuFeatureType feature,
- std::vector<uint32>& entry_ids) const;
+ std::vector<uint32>& entry_ids,
+ bool disabled) const;
// Returns status information on the blacklist. This is two parted:
// {
@@ -238,6 +241,9 @@
// Returns the entry's unique id. 0 is reserved.
uint32 id() const;
+ // Returns whether the entry is disabled.
+ bool disabled() const;
+
// Returns the description of the entry
const std::string& description() const { return description_; }
@@ -265,6 +271,8 @@
bool SetId(uint32 id);
+ void SetDisabled(bool disabled);
+
bool SetOsInfo(const std::string& os,
const std::string& version_op,
const std::string& version_string,
@@ -299,6 +307,7 @@
void AddBrowserChannel(BrowserChannel channel);
uint32 id_;
+ bool disabled_;
std::string description_;
std::vector<int> cr_bugs_;
std::vector<int> webkit_bugs_;
« no previous file with comments | « chrome/browser/resources/software_rendering_list.json ('k') | content/browser/gpu/gpu_blacklist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698