Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: content/browser/gpu/gpu_blacklist.h

Issue 7982034: Add a "disabled" field for GPU Blacklist entries. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/gpu_blacklist.h
===================================================================
--- content/browser/gpu/gpu_blacklist.h (revision 101450)
+++ content/browser/gpu/gpu_blacklist.h (working copy)
@@ -68,6 +68,10 @@
// kGpuFeatureWebgl | kGpuFeatureAcceleratedCompositing - two features.
void GetGpuFeatureFlagEntries(GpuFeatureFlags::GpuFeatureType feature,
std::vector<uint32>& entry_ids) const;
+ // Collects the entries that will the "feature" flag from the last
+ // DetermineGpuFeatureFlags() call if not disabled.
vangelis 2011/09/21 21:27:17 I don't understand this comment...
Zhenyao Mo 2011/09/22 17:10:39 This comment and its function are removed based on
+ void GetGpuFeatureFlagDisabledEntries(GpuFeatureFlags::GpuFeatureType feature,
+ std::vector<uint32>& entry_ids) const;
// Returns status information on the blacklist. This is two parted:
// {
@@ -238,6 +242,9 @@
// Returns the entry's unique id. 0 is reserved.
uint32 id() const;
+ // Returns whether the entry is disabled.
+ bool disabled() const;
+
// Returns the description of the entry
const std::string& description() const { return description_; }
@@ -265,6 +272,8 @@
bool SetId(uint32 id);
+ void SetDisabled(bool disabled);
+
bool SetOsInfo(const std::string& os,
const std::string& version_op,
const std::string& version_string,
@@ -299,6 +308,7 @@
void AddBrowserChannel(BrowserChannel channel);
uint32 id_;
+ bool disabled_;
std::string description_;
std::vector<int> cr_bugs_;
std::vector<int> webkit_bugs_;
@@ -352,6 +362,10 @@
// user machine. It is updated everytime DetermineGpuFeatureFlags() is
// called and is used later by GetGpuFeatureFlagEntries().
std::vector<ScopedGpuBlacklistEntry> active_entries_;
+ // This records all the disabled blacklist entries that are appliable to the
+ // current user machine. It is updated everytime DetermineGpuFeatureFlags()
+ // is called and is used later by GetGpuFeatureFlagDisabledEntries().
+ std::vector<ScopedGpuBlacklistEntry> active_disabled_entries_;
uint32 max_entry_id_;

Powered by Google App Engine
This is Rietveld 408576698