Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 7982033: Prevent VoiceOver from announcing omnibox and status bubble overlay windows. (Closed)

Created:
9 years, 3 months ago by David Tseng
Modified:
9 years, 3 months ago
CC:
chromium-reviews, dmazzoni
Visibility:
Public.

Description

Prevent VoiceOver from announcing omnibox overlay windows. While typing into the omnibox, VoiceOver will announce "untitled window created" This is fairly disruptive and has been commented on by users. We should revisit how to make the underlying NSMatrix accessible, but in the meantime, set the window to NSAccessibilityUnknownRole so VoiceOver will ignore it. Similarly, status bubbles cause VoiceOver to announce "untitled window created". The content contained therein is exposed in other ways to the user of VoiceOver. BUG=63483 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102207

Patch Set 1 #

Patch Set 2 : Add same override to status bubbles. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
David Tseng
Primary reviewer: pinkerton FYI: dmazzoni
9 years, 3 months ago (2011-09-21 19:00:07 UTC) #1
pink (ping after 24hrs)
lgtm
9 years, 3 months ago (2011-09-21 19:01:45 UTC) #2
David Tseng
Missed status bubbles in the first go around. Same override applied to those windows. Thanks!
9 years, 3 months ago (2011-09-21 20:05:31 UTC) #3
pink (ping after 24hrs)
SLGTM On Wed, Sep 21, 2011 at 4:05 PM, <dtseng@chromium.org> wrote: > Missed status bubbles ...
9 years, 3 months ago (2011-09-21 20:07:44 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 00:16:15 UTC) #5
Change committed as 102207

Powered by Google App Engine
This is Rietveld 408576698