Add GetPluginPath() to npobject_util to avoid content/plugin/ include from npobject_stub.cc

Modify NPObjectStub::OnSetProperty() to get the plugin path from the command line directly

This avoids the need for NPObjectStub to use PluginThread::plugin_path() and allows us to remove the content/plugin/ include from npobject_stub.cc. We can also remove PluginThread::plugin_path().

Refactoring only, no functional change.

BUG=96703
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102145

[Steve Block, 2011-09-21 13:19:05]

http://codereview.chromium.org/7982026/diff/1/content/common/npobject_util.h
File content/common/npobject_util.h (left):

http://codereview.chromium.org/7982026/diff/1/content/common/npobject_util.h#...
content/common/npobject_util.h:36: bool IsPluginProcess();
This seems like a strange place for this function. Is there a better place we
could move both this and GetPluginPath()?

[jam, 2011-09-21 16:01:54]

It would be simpler if npobject_stub just looked at the command line flags for
switches::kPluginPath to get the path directly. this is a common pattern in
chrome, i.e. when  there's some data that's in a switch, multiple places can
look at the command line, instead of only one place and having it propagate it.

[jam, 2011-09-21 19:09:26]

lgtm

http://codereview.chromium.org/7982026/diff/4001/content/plugin/plugin_thread.h
File content/plugin/plugin_thread.h (left):

http://codereview.chromium.org/7982026/diff/4001/content/plugin/plugin_thread...
content/plugin/plugin_thread.h:49: FilePath plugin_path_;
nit: i think this isn't needed anymore