Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 7982024: [cros] OOBE/Login: proxy settings are saved when closed immediately after typing. (Closed)

Created:
9 years, 3 months ago by Ivan Korotkov
Modified:
9 years, 3 months ago
Reviewers:
xiyuan, whywhat
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[cros] OOBE/Login: proxy settings are saved even when closed immediately after typing. In stand-alone Proxy Settings dialog, 'keyup' events now trigger 'change' events. This is to circumvent http://crosbug.com/20660. BUG=chromium-os:11487 TEST=Manual: in login screen, open proxy settings, type in any IP and a non-standard port number (e.g. 9999), then press Esc or click the close button without focus leaving the port textbox. Port should be saved and re-appear when opening that dialog again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102129

Patch Set 1 #

Total comments: 2

Patch Set 2 : TODO added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/proxy_settings.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ivan Korotkov
9 years, 3 months ago (2011-09-21 09:29:24 UTC) #1
whywhat
lgtm
9 years, 3 months ago (2011-09-21 09:39:27 UTC) #2
xiyuan
LGTM http://codereview.chromium.org/7982024/diff/1/chrome/browser/resources/chromeos/proxy_settings.js File chrome/browser/resources/chromeos/proxy_settings.js (right): http://codereview.chromium.org/7982024/diff/1/chrome/browser/resources/chromeos/proxy_settings.js#newcode28 chrome/browser/resources/chromeos/proxy_settings.js:28: var inputs = document.querySelectorAll('input[pref]'); nit: Let's put a ...
9 years, 3 months ago (2011-09-21 17:14:37 UTC) #3
Ivan Korotkov
http://codereview.chromium.org/7982024/diff/1/chrome/browser/resources/chromeos/proxy_settings.js File chrome/browser/resources/chromeos/proxy_settings.js (right): http://codereview.chromium.org/7982024/diff/1/chrome/browser/resources/chromeos/proxy_settings.js#newcode28 chrome/browser/resources/chromeos/proxy_settings.js:28: var inputs = document.querySelectorAll('input[pref]'); On 2011/09/21 17:14:37, xiyuan wrote: ...
9 years, 3 months ago (2011-09-21 17:39:01 UTC) #4
xiyuan
9 years, 3 months ago (2011-09-21 17:42:31 UTC) #5
Cool. Thanks. And still LGTM. :)

Powered by Google App Engine
This is Rietveld 408576698