Fixed ExtraInfoSpec flags for webRequest.onAuthRequired

Fixed ExtraInfoSpec flags for webRequest.onAuthRequired


BUG=no
TEST=no


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102182

[battre, 2011-09-21 16:28:47]

Please review. Thanks.

[jochen (gone - plz use gerrit), 2011-09-21 20:12:33]

LGTM

On Wed, Sep 21, 2011 at 6:28 PM, <battre@chromium.org> wrote:

> Reviewers: jochen,
>
> Message:
> Please review. Thanks.
>
> Description:
> Fixed ExtraInfoSpec flags for webRequest.onAuthRequired
>
>
> BUG=no
> TEST=no
>
>
> Please review this at
http://codereview.chromium.**org/7982023/<http://codereview.chromium.org/7982...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/extensions/**extension_webrequest_api.cc
>  M chrome/test/data/extensions/**api_test/webrequest/test_**complex.html
>
>
> Index: chrome/browser/extensions/**extension_webrequest_api.cc
> diff --git a/chrome/browser/extensions/**extension_webrequest_api.cc
> b/chrome/browser/extensions/**extension_webrequest_api.cc
> index 36ee72c7d9e8df807b8ae64a070ebc**63077957b4..**
> cf13a5290c116aaa7377380c0de81a**0123ae10d9 100644
> --- a/chrome/browser/extensions/**extension_webrequest_api.cc
> +++ b/chrome/browser/extensions/**extension_webrequest_api.cc
> @@ -620,7 +620,7 @@ void ExtensionWebRequestEventRouter**::OnAuthRequired(
>   challenger->SetInteger(keys::**kPortKey, auth_info.challenger.port());
>   dict->Set(keys::**kChallengerKey, challenger);
>   dict->SetDouble(keys::**kTimeStampKey, time.ToDoubleT() * 1000);
> -  if (extra_info_spec & ExtraInfoSpec::REQUEST_**HEADERS) {
> +  if (extra_info_spec & ExtraInfoSpec::RESPONSE_**HEADERS) {
>     dict->Set(keys::**kResponseHeadersKey,
>               GetResponseHeadersList(**request->response_headers()));
>   }
> Index: chrome/test/data/extensions/**api_test/webrequest/test_**
> complex.html
> diff --git
a/chrome/test/data/extensions/**api_test/webrequest/test_**complex.html
> b/chrome/test/data/extensions/**api_test/webrequest/test_**complex.html
> index eb4e7c53ae23b25a3accb83e8e70af**a848dd90a7..**
> 58a580111081fd0ecf25b09423e1b0**059fa19697 100644
> --- a/chrome/test/data/extensions/**api_test/webrequest/test_**
> complex.html
> +++ b/chrome/test/data/extensions/**api_test/webrequest/test_**
> complex.html
> @@ -227,7 +227,8 @@ runTests([
>             isProxy: false,
>             scheme: "basic",
>             realm: "testrealm",
> -            challenger: {host: testServer, port: testServerPort}
> +            challenger: {host: testServer, port: testServerPort},
> +            responseHeadersExist: true
>           }
>         },
>         { label: "onResponseStarted",
> @@ -236,7 +237,8 @@ runTests([
>             url: getURLAuthRequired(),
>             fromCache: false,
>             statusCode: 401,
> -            ip: "127.0.0.1"
> +            ip: "127.0.0.1",
> +            responseHeadersExist: true
>           }
>         },
>         { label: "onCompleted",
> @@ -245,7 +247,8 @@ runTests([
>             url: getURLAuthRequired(),
>             fromCache: false,
>             statusCode: 401,
> -            ip: "127.0.0.1"
> +            ip: "127.0.0.1",
> +            responseHeadersExist: true
>           }
>         },
>       ],
> @@ -253,7 +256,7 @@ runTests([
>         ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
>          "onAuthRequired", "onResponseStarted", "onCompleted"]
>       ],
> -      {}, []);
> +      {}, ["responseHeaders"]);
>     navigateAndWait(**getURLAuthRequired());
>   },
>
>
>
>

[commit-bot: I haz the power, 2011-09-21 22:41:59]

Change committed as 102182