Panel auto-resize for GTK.

Panel auto-resize for GTK.

This continues to use the existing auto-resize framework. A separate
patch will change the framework to allow the native panel to compute
content size from window size and vice versa.

BUG=None
TEST=PanelBrowserTest.AutoResize


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102081

[jennb, 2011-09-20 23:03:45]

erg - for the changes to browser_window_gtk layer.
jianli - for the panel changes.

Thanks,
Jenn

[Elliot Glaysher, 2011-09-20 23:17:28]

lgtm

[jianli, 2011-09-20 23:35:39]

LGTM with a couple nits.

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel.h
File chrome/browser/ui/panels/panel.h (right):

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel....
chrome/browser/ui/panels/panel.h:181: void OnNonClientAreaSizeKnown();
How about OnNonClientExtentBecomeKnown or OnNonClientExtentAvailable?

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_window_gtk.cc (right):

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_window_gtk.cc:278: bounds.x() +
bounds.width() != bounds_.x() + bounds_.width() ||
Simpler to call bounds.right() than bounds.x() + bounds.width().

Ditto for bounds.y() + bounds.height().

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_window_gtk.h (right):

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_window_gtk.h:164: bool
non_client_area_size_known_;
Seems to be simpler and more natural to invert it to
non_client_area_size_unknown_

[jennb, 2011-09-20 23:46:43]

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel.h
File chrome/browser/ui/panels/panel.h (right):

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel....
chrome/browser/ui/panels/panel.h:181: void OnNonClientAreaSizeKnown();
On 2011/09/20 23:35:39, jianli wrote:
> How about OnNonClientExtentBecomeKnown or OnNonClientExtentAvailable?

Done.

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_window_gtk.cc (right):

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_window_gtk.cc:278: bounds.x() +
bounds.width() != bounds_.x() + bounds_.width() ||
On 2011/09/20 23:35:39, jianli wrote:
> Simpler to call bounds.right() than bounds.x() + bounds.width().
> 
> Ditto for bounds.y() + bounds.height().

Thanks! I didn't know about right() and bottom().

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_window_gtk.h (right):

http://codereview.chromium.org/7982016/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_window_gtk.h:164: bool
non_client_area_size_known_;
On 2011/09/20 23:35:39, jianli wrote:
> Seems to be simpler and more natural to invert it to
> non_client_area_size_unknown_

I left this one as-is. I'm more accustomed to the initial value of a bool being
false.

[jianli, 2011-09-20 23:49:48]

lgtm.

[commit-bot: I haz the power, 2011-09-21 03:27:38]

Change committed as 102081