Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 7982011: Rename export() in Page Benchmarker (collision with reserved word). (Closed)

Created:
9 years, 3 months ago by miket_OOO
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Rename export() in Page Benchmarker (collision with reserved word). BUG=97101 TEST=manually installed it and ran it on www.google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102063

Patch Set 1 #

Total comments: 1

Patch Set 2 : Style. #

Patch Set 3 : Bump version number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -50 lines) Patch
M chrome/common/extensions/docs/examples/extensions/benchmark.zip View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/benchmark/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/extensions/benchmark/options.html View 1 25 chunks +49 lines, -49 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
miket_OOO
Your reviewitude would be most appreciated.
9 years, 3 months ago (2011-09-20 19:16:08 UTC) #1
Mihai Parparita -not on Chrome
http://codereview.chromium.org/7982011/diff/1/chrome/common/extensions/docs/examples/extensions/benchmark/options.html File chrome/common/extensions/docs/examples/extensions/benchmark/options.html (right): http://codereview.chromium.org/7982011/diff/1/chrome/common/extensions/docs/examples/extensions/benchmark/options.html#newcode832 chrome/common/extensions/docs/examples/extensions/benchmark/options.html:832: function export_html() { This should be called exportHtml (to ...
9 years, 3 months ago (2011-09-20 20:02:05 UTC) #2
miket_OOO
> This should be called exportHtml (to be consistent with the rest of the > ...
9 years, 3 months ago (2011-09-20 20:10:55 UTC) #3
miket_OOO
Changes made.
9 years, 3 months ago (2011-09-20 20:11:08 UTC) #4
Mihai Parparita -not on Chrome
lgtm
9 years, 3 months ago (2011-09-20 20:24:25 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-21 01:09:43 UTC) #6
Change committed as 102063

Powered by Google App Engine
This is Rietveld 408576698