Issue 7982009: views: Add comment to Combobox's native wrapper about its lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7982009: views: Add comment to Combobox's native wrapper about its lifetime. (Closed)

Created:
9 years, 3 months ago by tfarina

Modified:
9 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

views: Add comment to Combobox's native wrapper about its lifetime. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102105

Patch Set 2 : #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	views/controls/combobox/combobox.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	views/controls/combobox/combobox.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/7982009/diff/1/views/controls/combobox/combobox.cc File views/controls/combobox/combobox.cc (right): http://codereview.chromium.org/7982009/diff/1/views/controls/combobox/combobox.cc#newcode134 views/controls/combobox/combobox.cc:134: native_wrapper_ = NativeComboboxWrapper::CreateWrapper(this); Same as in views/controls/textfield/textfield.cc:416

9 years, 3 months ago (2011-09-20 18:10:50 UTC) #1

LGTM

Expand Messages | Collapse Messages

Issue 7982009: views: Add comment to Combobox's native wrapper about its lifetime. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages