Move dependencies to a locked property.

tests/gclient_test.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for gclient.py.
 
 See gclient_smoketest.py for integration tests.
 """
 
@@ skipping 116 matching lines @@
         '  "foo/dir1/dir2": "/dir1/another",\n'
         '}')
 
     obj = gclient.GClient.LoadCurrentConfig(options)
     self._check_requirements(obj.dependencies[0], {})
     self._check_requirements(obj.dependencies[1], {})
     obj.RunOnDeps('None', args)
     # The trick here is to manually process the list to make sure it's out of
     # order.
     for i in obj.dependencies:
-      i.dependencies.sort(key=lambda x: x.name, reverse=reverse)
+      # pylint: disable=W0212
+      i._dependencies.sort(key=lambda x: x.name, reverse=reverse)
     actual = self._get_processed()
     # We don't care of the ordering of these items:
     self.assertEquals(
         ['svn://example.com/bar', 'svn://example.com/foo'], sorted(actual[0:2]))
     actual = actual[2:]
     # Ordering may not be exact in case of parallel jobs.
     self.assertTrue(
         actual.index('svn://example.com/bar/dir1/dir2') >
         actual.index('svn://example.com/foo/dir1'))
     actual.remove('svn://example.com/bar/dir1/dir2')
@@ skipping 54 matching lines @@
         None, 'name', 'proto://host/path/@revision', None, None, None,
         None, '', True)
     self.assertEquals('proto://host/path@revision', d.url)
 
   def testStr(self):
     # Make sure __str__() works fine.
     # pylint: disable=W0212
     parser = gclient.Parser()
     options, _ = parser.parse_args([])
     obj = gclient.GClient('foo', options)
-    obj.dependencies.append(
+    obj._dependencies.append(
         gclient.Dependency(obj, 'foo', 'url', None, None, None, None, 'DEPS',
                            True))
-    obj.dependencies.append(
+    obj._dependencies.append(
         gclient.Dependency(obj, 'bar', 'url', None, None, None, None, 'DEPS',
                            True))
-    obj.dependencies[0].dependencies.append(
+    obj.dependencies[0]._dependencies.append(
         gclient.Dependency(
           obj.dependencies[0], 'foo/dir1', 'url', None, None, None, None,
           'DEPS', True))
-    obj.dependencies[0].dependencies.append(
+    obj.dependencies[0]._dependencies.append(
         gclient.Dependency(
           obj.dependencies[0], 'foo/dir2',
           gclient.GClientKeywords.FromImpl('bar'), None, None, None, None,
           'DEPS', True))
-    obj.dependencies[0].dependencies.append(
+    obj.dependencies[0]._dependencies.append(
         gclient.Dependency(
           obj.dependencies[0], 'foo/dir3',
           gclient.GClientKeywords.FileImpl('url'), None, None, None, None,
           'DEPS', True))
     obj.dependencies[0]._file_list.append('foo')
     self.assertEquals(434, len(str(obj)), '%d\n%s' % (len(str(obj)), str(obj)))
 
 
 if __name__ == '__main__':
   logging.basicConfig(
       level=[logging.ERROR, logging.WARNING, logging.INFO, logging.DEBUG][
         min(sys.argv.count('-v'), 3)],
       format='%(asctime).19s %(levelname)s %(filename)s:'
               '%(lineno)s %(message)s')
   unittest.main()