Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 95551) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,5 +1,4700 @@ |
+2011-09-19 James Robinson <jamesr@chromium.org> |
+ |
+ [chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint |
+ https://bugs.webkit.org/show_bug.cgi?id=68405 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case |
+ compositing is turned off halfway through a paint. |
+ |
+ * platform/graphics/chromium/ContentLayerChromium.h: |
+ * platform/graphics/chromium/ImageLayerChromium.cpp: |
+ (WebCore::ImageLayerTextureUpdater::create): |
+ * platform/graphics/chromium/ImageLayerChromium.h: |
+ * platform/graphics/chromium/LayerTextureUpdater.h: |
+ * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: |
+ (WebCore::LayerTextureUpdaterBitmap::create): |
+ (WebCore::LayerTextureUpdaterSkPicture::create): |
+ * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: |
+ * platform/graphics/chromium/TiledLayerChromium.cpp: |
+ (WebCore::TiledLayerChromium::prepareToUpdate): |
+ |
+2011-09-19 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Eliminate Length::undefinedLength = -1 and replace with Undefined LengthType. |
+ https://bugs.webkit.org/show_bug.cgi?id=68057 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ There appear to be many cases where -1 is actually a valid Length. |
+ Encoding the validity of Length separately to the value is a natural solution. |
+ |
+ No new tests / no behavioral changes. |
+ |
+ * css/CSSComputedStyleDeclaration.cpp: |
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): |
+ * css/CSSPrimitiveValue.cpp: |
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::ApplyPropertyLength::applyValue): |
+ * platform/Length.h: |
+ (WebCore::Length::Length): |
+ (WebCore::Length::value): |
+ (WebCore::Length::calcValue): |
+ (WebCore::Length::calcMinValue): |
+ (WebCore::Length::calcFloatValue): |
+ (WebCore::Length::isUndefined): |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::computePreferredLogicalWidths): |
+ * rendering/RenderDeprecatedFlexibleBox.cpp: |
+ (WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths): |
+ * rendering/RenderFileUploadControl.cpp: |
+ (WebCore::RenderFileUploadControl::computePreferredLogicalWidths): |
+ * rendering/RenderImage.cpp: |
+ (WebCore::RenderImage::isLogicalWidthSpecified): |
+ (WebCore::RenderImage::isLogicalHeightSpecified): |
+ * rendering/RenderListBox.cpp: |
+ (WebCore::RenderListBox::computePreferredLogicalWidths): |
+ * rendering/RenderMenuList.cpp: |
+ (WebCore::RenderMenuList::computePreferredLogicalWidths): |
+ * rendering/RenderReplaced.cpp: |
+ (WebCore::RenderReplaced::computePreferredLogicalWidths): |
+ * rendering/RenderSlider.cpp: |
+ (WebCore::RenderSlider::computePreferredLogicalWidths): |
+ * rendering/RenderTextControl.cpp: |
+ (WebCore::RenderTextControl::computePreferredLogicalWidths): |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::InheritedFlags::initialMaxSize): |
+ * rendering/svg/RenderSVGRoot.cpp: |
+ (WebCore::RenderSVGRoot::computePreferredLogicalWidths): |
+ |
+2011-09-19 Adam Barth <abarth@webkit.org> |
+ |
+ Always enable ENABLE(EVENTSOURCE) |
+ https://bugs.webkit.org/show_bug.cgi?id=68414 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ EventSource seems to be here to stay. This patch makes WebKit more |
+ hackable by removing this ENABLE macro, as discussed on webkit-dev. |
+ |
+ * Configurations/FeatureDefines.xcconfig: |
+ * GNUmakefile.am: |
+ * bindings/cpp/WebDOMEventTarget.cpp: |
+ (toWebKit): |
+ * bindings/js/JSDOMWindowCustom.cpp: |
+ (WebCore::JSDOMWindow::eventSource): |
+ * bindings/js/JSEventSourceCustom.cpp: |
+ * bindings/js/JSEventTarget.cpp: |
+ (WebCore::toJS): |
+ (WebCore::toEventTarget): |
+ * bindings/js/JSWorkerContextCustom.cpp: |
+ (WebCore::JSWorkerContext::eventSource): |
+ * bindings/v8/V8DOMWrapper.cpp: |
+ (WebCore::V8DOMWrapper::convertEventTargetToV8Object): |
+ * features.pri: |
+ * page/DOMWindow.idl: |
+ * page/EventSource.cpp: |
+ * page/EventSource.h: |
+ * page/EventSource.idl: |
+ * workers/WorkerContext.idl: |
+ |
+2011-09-19 Jeremy Apthorp <jeremya@chromium.org> |
+ |
+ Fix a use-after-free: clear the fullscreen change event target queue at |
+ detach time, rather than at destruction time. If this isn't done, it's |
+ possible for the event target queue to be the only thing that |
+ references the document. Then when the document is popped off the queue |
+ and dereferenced in Document::fullScreenChangeDelayTimerFired, the |
+ document is destroyed and the subsequent access to |
+ m_fullScreenChangeEventTargetQueue.isEmpty() accesses free'd memory. |
+ https://bugs.webkit.org/show_bug.cgi?id=67960 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::~Document): |
+ (WebCore::Document::detach): |
+ |
+2011-09-19 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95482. |
+ http://trac.webkit.org/changeset/95482 |
+ https://bugs.webkit.org/show_bug.cgi?id=68410 |
+ |
+ Broke chromium webkit-tests (Requested by dslomov on #webkit). |
+ |
+ * platform/image-encoders/skia/JPEGImageEncoder.cpp: |
+ (WebCore::RGBAtoRGB): |
+ |
+2011-09-19 Oliver Hunt <oliver@apple.com> |
+ |
+ Refactor Heap allocation logic into separate AllocationSpace class |
+ https://bugs.webkit.org/show_bug.cgi?id=68409 |
+ |
+ Reviewed by Gavin Barraclough. |
+ |
+ Adding a forwarding header. |
+ |
+ * ForwardingHeaders/heap/AllocationSpace.h: Added. |
+ |
+2011-09-19 Adam Barth <abarth@webkit.org> |
+ |
+ [V8] document.all gets confused about its prototype chain |
+ https://bugs.webkit.org/show_bug.cgi?id=68393 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ GetRealNamedPropertyInPrototypeChain doesn't call interceptors, so it's |
+ not a good idea to use its return value. It turns out that all the |
+ callers of the API only cared about whether it returns a null handle. |
+ |
+ Test: http/tests/security/document-all.html |
+ |
+ * bindings/v8/V8Collection.h: |
+ (WebCore::collectionNamedPropertyGetter): |
+ * bindings/v8/custom/V8DOMStringMapCustom.cpp: |
+ (WebCore::V8DOMStringMap::namedPropertyDeleter): |
+ (WebCore::V8DOMStringMap::namedPropertySetter): |
+ * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: |
+ (WebCore::V8HTMLAllCollection::namedPropertyGetter): |
+ * bindings/v8/custom/V8HTMLCollectionCustom.cpp: |
+ (WebCore::V8HTMLCollection::namedPropertyGetter): |
+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp: |
+ (WebCore::V8NamedNodeMap::namedPropertyGetter): |
+ * bindings/v8/custom/V8StorageCustom.cpp: |
+ (WebCore::storageSetter): |
+ |
+2011-09-19 Adam Barth <abarth@webkit.org> |
+ |
+ Named property confusion with __proto__ |
+ https://bugs.webkit.org/show_bug.cgi?id=68221 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ The __proto__ property is super magical because it's not a real named |
+ property and it has higher precedence than even interceptors. This |
+ confuses this check, which is meant to detech which names will get |
+ handled by our interceptor. |
+ |
+ Test: http/tests/security/window-named-proto.html |
+ |
+ * bindings/v8/custom/V8DOMWindowCustom.cpp: |
+ (WebCore::V8DOMWindow::namedSecurityCheck): |
+ |
+2011-09-19 Adam Barth <abarth@webkit.org> |
+ |
+ Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER) |
+ https://bugs.webkit.org/show_bug.cgi?id=68292 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ OpenType Sanitizer is a library for sanitizing type and not a feature. |
+ Therefore this macro should say that we USE the library. |
+ |
+ * platform/graphics/WOFFFileFormat.cpp: |
+ * platform/graphics/WOFFFileFormat.h: |
+ * platform/graphics/mac/FontCustomPlatformData.cpp: |
+ (WebCore::createFontCustomPlatformData): |
+ * platform/graphics/opentype/OpenTypeSanitizer.cpp: |
+ * platform/graphics/opentype/OpenTypeSanitizer.h: |
+ * platform/graphics/skia/FontCustomPlatformData.cpp: |
+ (WebCore::createFontCustomPlatformData): |
+ (WebCore::FontCustomPlatformData::supportsFormat): |
+ |
+2011-09-19 Adam Barth <abarth@webkit.org> |
+ |
+ Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code |
+ https://bugs.webkit.org/show_bug.cgi?id=68407 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ As discussed on webkit-dev, no one appears to be using this code. |
+ |
+ * GNUmakefile.list.am: |
+ * UseJSC.cmake: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSBindingsAllInOne.cpp: |
+ * bindings/js/JSDOMApplicationCacheCustom.cpp: Removed. |
+ |
+2011-09-19 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95385 and r95457. |
+ http://trac.webkit.org/changeset/95385 |
+ http://trac.webkit.org/changeset/95457 |
+ https://bugs.webkit.org/show_bug.cgi?id=68395 |
+ |
+ Broke chromium browser_tests (Requested by dslomov on |
+ #webkit). |
+ |
+ * bindings/v8/V8DOMWindowShell.cpp: |
+ (WebCore::V8DOMWindowShell::disposeContextHandles): |
+ (WebCore::V8DOMWindowShell::initContextIfNeeded): |
+ * bindings/v8/V8IsolatedContext.cpp: |
+ (WebCore::V8IsolatedContext::V8IsolatedContext): |
+ (WebCore::V8IsolatedContext::destroy): |
+ * bindings/v8/V8IsolatedContext.h: |
+ * loader/EmptyClients.h: |
+ (WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame): |
+ (WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame): |
+ (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext): |
+ * loader/FrameLoaderClient.h: |
+ |
+2011-09-19 John Bauman <jbauman@chromium.org> |
+ |
+ Fix nonpremultiplied webgl toDataURL to jpeg |
+ https://bugs.webkit.org/show_bug.cgi?id=68366 |
+ |
+ The canvas spec says that toDataURL to formats without an alpha must |
+ be "composited onto a solid black background using the source-over |
+ operator." Do that. |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ * platform/image-encoders/skia/JPEGImageEncoder.cpp: |
+ (WebCore::RGBAtoRGB): |
+ |
+2011-09-19 Chris Marrin <cmarrin@apple.com> |
+ |
+ Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction |
+ https://bugs.webkit.org/show_bug.cgi?id=67510 |
+ |
+ Reviewed by Adam Roben. |
+ |
+ Another fix to take care of one last crash when running pause-crash.html. |
+ CACF can't deal with null valueFunctions, so avoid setting it when it doesn't |
+ exist. |
+ |
+ This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it |
+ from catching the null pointer exception generated by the pause-crash.html test |
+ before this bug was fixed. Windows was ignoring the exception, so the testcase |
+ would appear to succeed, even though it should have crashed. |
+ |
+ This is a resubmission of http://trac.webkit.org/changeset/95243 with a build fix. |
+ |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * platform/graphics/ca/win/LayerChangesFlusher.cpp: |
+ (WebCore::LayerChangesFlusher::hookCallback): |
+ * platform/graphics/ca/win/PlatformCAAnimationWin.cpp: |
+ (PlatformCAAnimation::copy): |
+ * platform/win/StructuredExceptionHandlerSupressor.h: Added. |
+ (WebCore::StructuredExceptionHandlerSupressor::StructuredExceptionHandlerSupressor): |
+ (WebCore::StructuredExceptionHandlerSupressor::~StructuredExceptionHandlerSupressor): |
+ |
+2011-09-19 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Incorrect selection with absolutely positioned div |
+ https://bugs.webkit.org/show_bug.cgi?id=39503 |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ The bug was caused by a false assumption in RenderBlock::positionForPoint. Because the last child box |
+ can be positioned, floated, invisible, etc..., we can't always trust last child's logicalTop to tell us |
+ whether a given point is inside or below the last child box. |
+ |
+ Fixed the bug by using the last hit-test candidate instead. |
+ |
+ Test: editing/selection/block-with-positioned-lastchild.html |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::positionForPoint): |
+ |
+2011-09-19 Dmitry Titov <dimich@chromium.org> |
+ |
+ [Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins. |
+ https://bugs.webkit.org/show_bug.cgi?id=68267 |
+ Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins. |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: fast/frames/iframe-reparenting-embed-elements.html |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::adoptNode): |
+ * html/HTMLFrameElementBase.cpp: |
+ (WebCore::hasPluginElements): |
+ (WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree): |
+ * html/HTMLFrameElementBase.h: |
+ |
+2011-09-19 Abhishek Arya <inferno@chromium.org> |
+ |
+ Issues with merging ruby bases. |
+ https://bugs.webkit.org/show_bug.cgi?id=67240 |
+ |
+ Reviewed by James Robinson. |
+ |
+ 1) Change fromBeforeChild to beforeChild to match |
+ webkit rendering naming conventions. |
+ 2) Add assert to verify ruby base is indeed emptied |
+ after collecting all children in a single base. |
+ 3) Fix condition in mergeBlockChildren to bail out only |
+ when we have no children and there is no work to merge |
+ children to toBase. |
+ |
+ Test: fast/ruby/ruby-overhang-crash.html |
+ |
+ * rendering/RenderRubyBase.cpp: |
+ (WebCore::RenderRubyBase::moveChildren): |
+ (WebCore::RenderRubyBase::moveInlineChildren): |
+ (WebCore::RenderRubyBase::moveBlockChildren): |
+ (WebCore::RenderRubyBase::mergeBlockChildren): |
+ * rendering/RenderRubyBase.h: |
+ * rendering/RenderRubyRun.cpp: |
+ (WebCore::RenderRubyRun::removeChild): |
+ |
+2011-09-16 Abhishek Arya <inferno@chromium.org> |
+ |
+ Child not placed correctly when beforeChild (table part) |
+ has both :before, :after content. |
+ https://bugs.webkit.org/show_bug.cgi?id=67656 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Tests: fast/table/table-cell-before-after-content-around-table-block.html |
+ fast/table/table-cell-before-after-content-around-table-row.html |
+ fast/table/table-cell-before-after-content-around-table.html |
+ fast/table/table-row-before-after-content-around-block.html |
+ fast/table/table-row-before-after-content-around-table.html |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): |
+ 1. Use the new helper functions findAfterContentRenderer, |
+ anonymousContainer. |
+ 2. Rename anonymousChild to better name - beforeChildAnonymousContainer. |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::addChild): |
+ When adding a new child, if beforeChild is a table part( |
+ Table/TableSection/TableRow), we need to check if both |
+ :before, :after content are shoved in one of the anonymous child. |
+ If yes, we need to split the :before, :after content before adding |
+ newChild. Easiest approach is to destroy the :before content, then add |
+ the newChild and then call updateBeforeAfterContent to recreate the |
+ :before content. |
+ * rendering/RenderObject.h: |
+ (WebCore::RenderObject::findBeforeContentRenderer): same as |
+ beforePseudoElementRenderer, but ignores text childs since they are |
+ sequentially added. |
+ (WebCore::RenderObject::findAfterContentRenderer): same. |
+ (WebCore::RenderObject::anonymousContainer): |
+ (WebCore::objectIsRelayoutBoundary): |
+ * rendering/RenderTable.cpp: |
+ (WebCore::RenderTable::addChild): use the new helpers and functionally |
+ correct functions - findAfterContentRenderer, anonymousContainer. previous |
+ implementation was wrong since it would not go inside, if :after content |
+ is embedded deeper than one level. |
+ * rendering/RenderTableRow.cpp: |
+ (WebCore::RenderTableRow::addChild): same. |
+ * rendering/RenderTableSection.cpp: |
+ (WebCore::RenderTableSection::addChild): same. |
+ |
+2011-09-19 Robert Kroeger <rjkroege@chromium.org> |
+ |
+ [chromium] Gesture recognizer fires taptype only every other touch |
+ down/up sequence https://bugs.webkit.org/show_bug.cgi?id=68368 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ The addition of doubletap detection to the gesture recognizer missed some of the |
+ outgoing edges in the recognizer state machine. This change simplifies the logic |
+ and handles all outgoing edges. |
+ |
+ * platform/chromium/GestureRecognizerChromium.cpp: |
+ (WebCore::GestureRecognizerChromium::GestureRecognizerChromium): |
+ (WebCore::GestureRecognizerChromium::isInSecondClickTimeWindow): |
+ (WebCore::GestureRecognizerChromium::updateValues): |
+ (WebCore::GestureRecognizerChromium::touchDown): |
+ (WebCore::GestureRecognizerChromium::click): |
+ * platform/chromium/GestureRecognizerChromium.h: |
+ |
+2011-09-19 Tom Sepez <tsepez@chromium.org> |
+ |
+ Fix xssauditor bypass with unterminated closing tag by making the HTMLSourceTracker |
+ and the HTMLParser interact more closely with each other. HTMLParser should be |
+ setting the end range for the token itself to account for buffering that the |
+ HTMLSourceTracker can't know about, but there are a lot of paths that would need |
+ updating. First step is to cover this one path. |
+ https://bugs.webkit.org/show_bug.cgi?id=68281 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html |
+ |
+ * html/parser/HTMLSourceTracker.cpp: |
+ (WebCore::HTMLSourceTracker::end): |
+ * html/parser/HTMLTokenizer.cpp: |
+ (WebCore::HTMLTokenizer::nextToken): |
+ |
+2011-09-19 Peter Rybin <peter.rybin@gmail.com> |
+ |
+ TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes |
+ https://bugs.webkit.org/show_bug.cgi?id=63541 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests because this patch is not changing behavior. |
+ |
+ * bindings/js/JavaScriptCallFrame.cpp: |
+ (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): |
+ * bindings/js/JavaScriptCallFrame.h: |
+ (WebCore::JavaScriptCallFrame::create): |
+ (WebCore::JavaScriptCallFrame::position): |
+ (WebCore::JavaScriptCallFrame::update): |
+ * bindings/js/ScriptController.cpp: |
+ (WebCore::ScriptController::eventHandlerLineNumber): |
+ * bindings/js/ScriptDebugServer.cpp: |
+ (WebCore::ScriptDebugServer::hasBreakpoint): |
+ (WebCore::ScriptDebugServer::dispatchDidParseSource): |
+ (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): |
+ (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): |
+ * bindings/js/ScriptDebugServer.h: |
+ * bindings/js/ScriptSourceCode.h: |
+ (WebCore::ScriptSourceCode::ScriptSourceCode): |
+ * bindings/js/StringSourceProvider.h: |
+ (WebCore::StringSourceProvider::create): |
+ (WebCore::StringSourceProvider::startPosition): |
+ (WebCore::StringSourceProvider::StringSourceProvider): |
+ * bindings/v8/ScheduledAction.cpp: |
+ (WebCore::ScheduledAction::ScheduledAction): |
+ * bindings/v8/ScriptController.cpp: |
+ (WebCore::ScriptController::eventHandlerPosition): |
+ * bindings/v8/ScriptController.h: |
+ * bindings/v8/ScriptEventListener.cpp: |
+ (WebCore::createAttributeEventListener): |
+ * bindings/v8/ScriptSourceCode.h: |
+ (WebCore::ScriptSourceCode::ScriptSourceCode): |
+ (WebCore::ScriptSourceCode::startPosition): |
+ * bindings/v8/V8LazyEventListener.cpp: |
+ (WebCore::V8LazyEventListener::V8LazyEventListener): |
+ * bindings/v8/V8LazyEventListener.h: |
+ (WebCore::V8LazyEventListener::create): |
+ * bindings/v8/V8Proxy.cpp: |
+ (WebCore::V8Proxy::compileScript): |
+ (WebCore::V8Proxy::evaluate): |
+ (WebCore::V8Proxy::runScript): |
+ * bindings/v8/V8Proxy.h: |
+ * bindings/v8/WorkerContextExecutionProxy.cpp: |
+ (WebCore::WorkerContextExecutionProxy::evaluate): |
+ (WebCore::WorkerContextExecutionProxy::runScript): |
+ * bindings/v8/WorkerContextExecutionProxy.h: |
+ * bindings/v8/WorkerScriptController.cpp: |
+ (WebCore::WorkerScriptController::evaluate): |
+ * dom/PendingScript.cpp: |
+ (WebCore::PendingScript::releaseElementAndClear): |
+ * dom/PendingScript.h: |
+ (WebCore::PendingScript::PendingScript): |
+ (WebCore::PendingScript::startingPosition): |
+ (WebCore::PendingScript::setStartingPosition): |
+ * dom/ScriptElement.cpp: |
+ (WebCore::ScriptElement::prepareScript): |
+ * dom/ScriptElement.h: |
+ * dom/ScriptableDocumentParser.h: |
+ * dom/ViewportArguments.cpp: |
+ (WebCore::parserLineNumber): |
+ * html/parser/HTMLDocumentParser.cpp: |
+ (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): |
+ (WebCore::HTMLDocumentParser::pumpTokenizer): |
+ (WebCore::HTMLDocumentParser::lineNumber): |
+ (WebCore::HTMLDocumentParser::textPosition): |
+ * html/parser/HTMLDocumentParser.h: |
+ * html/parser/HTMLInputStream.h: |
+ * html/parser/HTMLScriptRunner.cpp: |
+ (WebCore::HTMLScriptRunner::execute): |
+ (WebCore::HTMLScriptRunner::runScript): |
+ * html/parser/HTMLScriptRunner.h: |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::uninitializedPositionValue1): |
+ (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): |
+ (WebCore::HTMLTreeBuilder::takeScriptToProcess): |
+ (WebCore::HTMLTreeBuilder::processEndTag): |
+ (WebCore::HTMLTreeBuilder::processScriptStartTag): |
+ * html/parser/HTMLTreeBuilder.h: |
+ * inspector/InspectorResourceAgent.cpp: |
+ (WebCore::InspectorResourceAgent::buildInitiatorObject): |
+ * platform/text/SegmentedString.cpp: |
+ (WebCore::SegmentedString::currentLine): |
+ (WebCore::SegmentedString::currentColumn): |
+ (WebCore::SegmentedString::setCurrentPosition): |
+ * platform/text/SegmentedString.h: |
+ * svg/SVGDocumentExtensions.cpp: |
+ (WebCore::parserLineNumber): |
+ * xml/XMLErrors.cpp: |
+ (WebCore::XMLErrors::XMLErrors): |
+ (WebCore::XMLErrors::handleError): |
+ (WebCore::XMLErrors::appendErrorMessage): |
+ * xml/XMLErrors.h: |
+ * xml/parser/MarkupTokenizerBase.h: |
+ (WebCore::MarkupTokenizerBase::lineNumber): |
+ * xml/parser/NewXMLDocumentParser.cpp: |
+ (WebCore::NewXMLDocumentParser::processScript): |
+ (WebCore::NewXMLDocumentParser::textPosition): |
+ (WebCore::NewXMLDocumentParser::lineNumber): |
+ * xml/parser/NewXMLDocumentParser.h: |
+ * xml/parser/XMLDocumentParser.cpp: |
+ (WebCore::XMLDocumentParser::pushCurrentNode): |
+ (WebCore::XMLDocumentParser::handleError): |
+ * xml/parser/XMLDocumentParser.h: |
+ * xml/parser/XMLDocumentParserLibxml2.cpp: |
+ (WebCore::PendingCallbacks::appendErrorCallback): |
+ (WebCore::XMLDocumentParser::XMLDocumentParser): |
+ (WebCore::XMLDocumentParser::doWrite): |
+ (WebCore::XMLDocumentParser::startElementNs): |
+ (WebCore::XMLDocumentParser::error): |
+ (WebCore::XMLDocumentParser::lineNumber): |
+ (WebCore::XMLDocumentParser::columnNumber): |
+ (WebCore::XMLDocumentParser::textPosition): |
+ * xml/parser/XMLDocumentParserQt.cpp: |
+ (WebCore::XMLDocumentParser::XMLDocumentParser): |
+ (WebCore::XMLDocumentParser::doWrite): |
+ (WebCore::XMLDocumentParser::doEnd): |
+ (WebCore::XMLDocumentParser::lineNumber): |
+ (WebCore::XMLDocumentParser::columnNumber): |
+ (WebCore::XMLDocumentParser::textPosition): |
+ (WebCore::XMLDocumentParser::parse): |
+ (WebCore::XMLDocumentParser::parseStartElement): |
+ |
+2011-09-19 Dan Bernstein <mitz@apple.com> |
+ |
+ WebCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes |
+ https://bugs.webkit.org/show_bug.cgi?id=68323 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Renamed AccessibilityObjectWrapper to WebAccessibilityObjectWrapper. |
+ Renamed CascadeList to WebCascadeList. |
+ Renamed CookieStorageObjCAdapter to WebCookieStorageObjCAdapter. |
+ Renamed LanguageChangeObserver to WebLanguageChangeObserver. |
+ Renamed ScrollAnimationHelperDelegate to WebScrollAnimationHelperDelegate. |
+ Renamed ScrollbarPainterControllerDelegate to WebScrollbarPainterControllerDelegate. |
+ Renamed ScrollbarPainterDelegate to WebScrollbarPainterDelegate. |
+ Renamed ScrollbarPartAnimation to WebScrollbarPartAnimation. |
+ Renamed ScrollbarPrefsObserver to WebScrollbarPrefsObserver. |
+ |
+ * WebCore.gyp/WebCore.gyp: Updated for the renaming of CascadeList to WebCascadeList. |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * accessibility/AccessibilityObject.h: |
+ * accessibility/mac/AXObjectCacheMac.mm: |
+ (WebCore::AXObjectCache::attachWrapper): |
+ * accessibility/mac/AccessibilityObjectMac.mm: |
+ * accessibility/mac/AccessibilityObjectWrapper.h: Removed. |
+ * accessibility/mac/AccessibilityObjectWrapper.mm: Removed. |
+ * accessibility/mac/WebAccessibilityObjectWrapper.h: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.h. |
+ * accessibility/mac/WebAccessibilityObjectWrapper.mm: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm. |
+ (convertToNSArray): |
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): |
+ (-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]): |
+ (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): |
+ * platform/graphics/mac/ComplexTextControllerCoreText.mm: |
+ (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): |
+ * platform/mac/Language.mm: |
+ (WebCore::platformDefaultLanguage): |
+ * platform/mac/ScrollAnimatorMac.h: |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::ScrollbarThemeMac): |
+ * platform/network/mac/CookieStorageMac.mm: |
+ (WebCore::startObservingCookieChanges): |
+ |
+2011-09-19 Cary Clark <caryclark@google.com> |
+ |
+ Move fontDataForCombiningCharacterSequence to fix Skia on Mac build |
+ https://bugs.webkit.org/show_bug.cgi?id=68358 |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ No new tests. |
+ |
+ * platform/graphics/mac/FontMac.mm: |
+ * platform/graphics/mac/FontComplexTextMac.cpp: |
+ (WebCore::Font::fontDataForCombiningCharacterSequence): |
+ This moves the implementation from FontMac.mm to |
+ FontComplexTextMac.cpp, so it is visible to the Skia on Mac |
+ platform as well. |
+ |
+2011-09-19 Jessie Berlin <jberlin@apple.com> |
+ |
+ Sites that use history pushState or replaceState are recorded in history in Private Browsing |
+ mode. |
+ https://bugs.webkit.org/show_bug.cgi?id=68208 |
+ |
+ Reviewed by Brady Eidson. |
+ |
+ Test: TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback. |
+ |
+ Add the privateBrowsingEnabled check that is used in other places in HistoryController |
+ before calling addVisitedLink and FrameLoaderClient::updateGlobalHistory. |
+ |
+ * loader/HistoryController.cpp: |
+ (WebCore::HistoryController::pushState): |
+ (WebCore::HistoryController::replaceState): |
+ |
+2011-09-19 Leandro Pereira <leandro@profusion.mobi> |
+ |
+ Unreviewed: ScrollbarThemeMock.cpp is already referenced in the |
+ global CMakeLists.txt. |
+ |
+ * CMakeListsEfl.txt: Remove reference to platform/mock/ScrollbarThemeMock.cpp. |
+ * CMakeListsWinCE.txt: Ditto. |
+ |
+2011-09-19 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org> |
+ |
+ Unreviewed: dos2unix on bindings/js/JSExceptionBase.h |
+ |
+ Visual Studio is choking on this file when generating packages for |
+ Qt-4.8 on Windows: |
+ |
+ """ |
+ Source\WebCore\Bindings\js\JSExceptionBase.h: |
+ error C4335: Mac file format detected: please convert the source file |
+ to either DOS or UNIX format |
+ """ |
+ |
+ Since from all .cpp or .h files shared by all ports this is the only |
+ one with CRLF line terminations, I'm assuming this was a mistake. |
+ |
+ * bindings/js/JSExceptionBase.h: |
+ |
+2011-09-19 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type. |
+ https://bugs.webkit.org/show_bug.cgi?id=67528 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Tests: inspector/timeline/timeline-dom-content-loaded-event.html |
+ inspector/timeline/timeline-load-event.html |
+ |
+ * inspector/InspectorTimelineAgent.cpp: |
+ (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): |
+ |
+2011-09-19 Shawn Singh <shawnsingh@chromium.org> |
+ |
+ Re-name LayerChromium border functions to reflect that |
+ they are only for debug use. |
+ https://bugs.webkit.org/show_bug.cgi?id=68212 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Code cleanup towards unit testing. |
+ |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ (WebCore::GraphicsLayerChromium::clearBackgroundColor): |
+ (WebCore::GraphicsLayerChromium::setDebugBackgroundColor): |
+ (WebCore::GraphicsLayerChromium::setDebugBorder): |
+ (WebCore::GraphicsLayerChromium::updateLayerBackgroundColor): |
+ (WebCore::GraphicsLayerChromium::setupContentsLayer): |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::setDebugBorderColor): |
+ (WebCore::LayerChromium::setDebugBorderWidth): |
+ * platform/graphics/chromium/LayerChromium.h: |
+ |
+2011-09-18 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel. |
+ https://bugs.webkit.org/show_bug.cgi?id=67986 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Test: inspector/timeline/timeline-animation-frame.html |
+ |
+ * English.lproj/localizedStrings.js: |
+ * bindings/v8/V8Proxy.cpp: |
+ (WebCore::V8Proxy::callFunction): |
+ (WebCore::V8Proxy::callFunctionWithoutFrame): |
+ (WebCore::V8Proxy::instrumentedCallFunction): |
+ * bindings/v8/V8Proxy.h: |
+ * bindings/v8/custom/V8CustomVoidCallback.cpp: |
+ (WebCore::invokeCallback): |
+ * dom/ScriptedAnimationController.cpp: |
+ (WebCore::ScriptedAnimationController::registerCallback): |
+ (WebCore::ScriptedAnimationController::cancelCallback): |
+ (WebCore::ScriptedAnimationController::serviceScriptedAnimations): |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl): |
+ (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl): |
+ (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl): |
+ (WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl): |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::willCallFunction): |
+ (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback): |
+ (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback): |
+ (WebCore::InspectorInstrumentation::willFireAnimationFrameEvent): |
+ (WebCore::InspectorInstrumentation::didFireAnimationFrameEvent): |
+ * inspector/InspectorTimelineAgent.cpp: |
+ (WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback): |
+ (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback): |
+ (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent): |
+ (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent): |
+ * inspector/InspectorTimelineAgent.h: |
+ * inspector/TimelineRecordFactory.cpp: |
+ (WebCore::TimelineRecordFactory::createAnimationFrameCallbackData): |
+ * inspector/TimelineRecordFactory.h: |
+ * inspector/front-end/TimelineAgent.js: |
+ * inspector/front-end/TimelinePanel.js: |
+ (WebInspector.TimelinePanel): |
+ (WebInspector.TimelinePanel.prototype.get _recordStyles): |
+ (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): |
+ (WebInspector.TimelinePanel.prototype._clearPanel): |
+ (WebInspector.TimelinePanel.FormattedRecord): |
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): |
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): |
+ |
+2011-09-19 Carlos Garcia Campos <cgarcia@igalia.com> |
+ |
+ [GTK] Fix distcheck build |
+ https://bugs.webkit.org/show_bug.cgi?id=68241 |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ * GNUmakefile.list.am: |
+ |
+2011-09-18 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Web Inspector: chromium-win: "Save timeline data" does nothing. |
+ https://bugs.webkit.org/show_bug.cgi?id=68313 |
+ |
+ windows shell API function GetSaveFileName doesn't accept file names with ':' symbol. |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/TimelinePanel.js: |
+ (WebInspector.TimelineModel.prototype._saveToFile): |
+ |
+2011-09-18 Dan Bernstein <mitz@apple.com> |
+ |
+ Try to fix the Chromium Mac build after r95391. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ |
+2011-09-18 Dan Bernstein <mitz@apple.com> |
+ |
+ Try to fix the Chromium Mac build after r95391. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ |
+2011-09-18 Dan Bernstein <mitz@apple.com> |
+ |
+ Try to fix the Chromium Mac build after r95391. |
+ |
+ * WebCore.gypi: Updated for the renaming of ComplexTextController.cpp. |
+ * WebCore.xcodeproj/project.pbxproj: Ditto. |
+ * platform/graphics/Font.h: Changed #if directives to include the Chromium Mac port. |
+ * platform/graphics/SimpleFontData.h: Ditto. |
+ * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Changed the filename extension of this |
+ Objective-C++ file to .mm. |
+ * platform/graphics/mac/ComplexTextControllerCoreText.mm: Copied from Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp. |
+ |
+2011-09-18 Dan Bernstein <mitz@apple.com> |
+ |
+ Snow Leopard build fix after r95391. |
+ |
+ * platform/graphics/mac/ComplexTextControllerCoreText.cpp: |
+ (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): |
+ |
+2011-09-18 Dan Bernstein <mitz@apple.com> |
+ |
+ Leopard build fix after r95391. |
+ |
+ * platform/graphics/mac/ComplexTextControllerATSUI.cpp: |
+ (WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): |
+ |
+2011-09-18 Dan Bernstein <mitz@apple.com> |
+ |
+ Allow Core Text to choose the fallback font for rendering a combining character sequence |
+ |
+ Fixes <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified |
+ https://bugs.webkit.org/show_bug.cgi?id=68287 |
+ |
+ Reviewed by Dave Hyatt. |
+ |
+ Test: platform/mac/fast/text/combining-character-sequence-fallback.html |
+ |
+ * WebCore.xcodeproj/project.pbxproj: Compile ComplexTextControllerCoreText.cpp as Objective-C++. |
+ I am going to rename this file in a followup patch. |
+ |
+ * platform/graphics/Font.h: Declared fontDataForCombiningCharacterSequence(). |
+ |
+ * platform/graphics/SimpleFontData.h: Declared canRenderCombiningCharacterSequence() and added |
+ a member variable to cache the results of calling this function. |
+ |
+ * platform/graphics/mac/ComplexTextController.cpp: |
+ (WebCore::ComplexTextController::offsetForPosition): Fixed a typo in a comment. |
+ (WebCore::advanceByCombiningCharacterSequence): Added this helper function, which iterates over |
+ characters until the end of a sequence of combining characters, zero-width joiners and zero-width |
+ non-joiners. A single base characater followed by such a (possibly-empty) sequence is known as |
+ a combining character sequence. This stretches the definition a little because the base character |
+ may be a combining character as well. Returns false if an invalid UTF-16 sequence is encountered, |
+ true otherwise. |
+ (WebCore::ComplexTextController::collectComplexTextRuns): - Replaced the glyphData and nextGlyphData |
+ variables each with a pair of variables, a SimpleFontData* and a boolean indicating whether a |
+ character mapped to the missing glyph. This clarifies that this function does not use glyph IDs. |
+ - Renamed the local variable newC to uppercaseCharacter. |
+ - Changed to use advanceByCombiningCharacterSequence(). |
+ - Changed to use Font::fontDataForCombiningCharacterSequence() instead of Font::glyphDataForCharacter(). |
+ If there are combining marks and none of the fonts in the fallback list can render the sequence alone, |
+ use the systemFallbackFontData() constant to indicate to collectComplexTextRunsForCharactersCoreText() |
+ to allow Core Text to perform its own fallback. |
+ - Stopped checking isSmallCaps against nextIsSmallCaps. It was redundant, since the small caps FontData |
+ differs from the normal variant. |
+ (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Moved the common logic to |
+ handle the 0 fontData case from the ATSUI and Core Text continuations of this function into this function. |
+ |
+ * platform/graphics/mac/ComplexTextController.h: |
+ (WebCore::ComplexTextController::systemFallbackFontData): Added. This constant is used to indicate to |
+ collectComplexTextRunsForCharactersCoreText() that it should allow Core Text to perform its own font |
+ fallback. |
+ |
+ * platform/graphics/mac/ComplexTextControllerATSUI.cpp: |
+ (WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): Handle systemFallbackFontData() |
+ by using the primary font data. |
+ |
+ * platform/graphics/mac/ComplexTextControllerCoreText.cpp: |
+ (-[CascadeList initWithFont:WebCore::character:]): Added. |
+ (-[CascadeList count]): Added. |
+ (-[CascadeList objectAtIndex:]): Added. Returns an entry from a cascade list of CTFontDescriptorRef |
+ objects based on the font’s fallback list for the character. The list is initialized lazily. |
+ (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Handle systemFallbackFontData() |
+ by allowing Core Text to perform font fallback, starting with a cascade list based on the font’s fallback |
+ list and possibly continuing with system fallback. |
+ |
+ * platform/graphics/mac/FontMac.mm: |
+ (WebCore::Font::fontDataForCombiningCharacterSequence): Added. If the sequence is only a base character, |
+ calls through to glyphDataForCharacter(). Otherwise, iterates over the font’s fallback list for the |
+ base character (and the system fallback font for that character), returning the first font that can |
+ render the sequence, or 0 if there is none. |
+ |
+ * platform/graphics/mac/SimpleFontDataMac.mm: |
+ (WebCore::provideStringAndAttributes): Added this Core Text callback. |
+ (WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added. Checks if Core Text can render |
+ the sequence using only this font. Caches the result. |
+ |
+2011-09-17 Mihai Parparita <mihaip@chromium.org> |
+ |
+ FrameLoaderClient BackForwardList-related methods are unsued |
+ https://bugs.webkit.org/show_bug.cgi?id=68293 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Remove FrameLoaderClient methods that were added by r51629, since only |
+ the old (since-deleted) Android port needed them. |
+ |
+ * history/BackForwardListImpl.cpp: |
+ (WebCore::BackForwardListImpl::addItem): |
+ (WebCore::BackForwardListImpl::goBack): |
+ (WebCore::BackForwardListImpl::goForward): |
+ (WebCore::BackForwardListImpl::goToItem): |
+ (WebCore::BackForwardListImpl::setCapacity): |
+ * loader/EmptyClients.h: |
+ * loader/FrameLoaderClient.h: |
+ |
+2011-09-17 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=68307 |
+ |
+ Crash in border image cssText. Make sure to null check all the components, since they're all |
+ optional now. |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Added fast/borders/border-image-slice-omission.html |
+ |
+ * css/CSSBorderImageValue.cpp: |
+ (WebCore::CSSBorderImageValue::cssText): |
+ |
+2011-09-17 Aaron Boodman <aa@chromium.org> |
+ |
+ Rework script context creation/release notifications |
+ https://bugs.webkit.org/show_bug.cgi?id=67828 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ * bindings/v8/V8DOMWindowShell.cpp: |
+ (WebCore::V8DOMWindowShell::disposeContextHandles): |
+ (WebCore::V8DOMWindowShell::initContextIfNeeded): |
+ * bindings/v8/V8IsolatedContext.cpp: |
+ (WebCore::V8IsolatedContext::V8IsolatedContext): |
+ (WebCore::V8IsolatedContext::destroy): |
+ * bindings/v8/V8IsolatedContext.h: |
+ * loader/EmptyClients.h: |
+ (WebCore::EmptyFrameLoaderClient::didCreateScriptContext): |
+ (WebCore::EmptyFrameLoaderClient::willReleaseScriptContext): |
+ * loader/FrameLoaderClient.h: |
+ |
+2011-09-17 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel. |
+ https://bugs.webkit.org/show_bug.cgi?id=68312 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/TimelinePanel.js: |
+ (WebInspector.TimelinePanel.prototype._createFileSelector): |
+ |
+2011-09-17 Jeff Miller <jeffm@apple.com> |
+ |
+ Build fix after r95372. |
+ |
+ * dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp" |
+ |
+2011-09-17 Deepak Sherveghar <bpwv64@motorola.com> |
+ |
+ Override supportsFocus() for HTMLMediaElement. |
+ https://bugs.webkit.org/show_bug.cgi?id=67190 |
+ |
+ Reviewed by Antonio Gomes. |
+ |
+ Tests: fast/events/media-element-focus-tab.html |
+ fast/spatial-navigation/snav-media-elements.html |
+ |
+ Return true from supportsFocus() if control's attribute is present or a tabindex is specified. |
+ |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::supportsFocus): |
+ * html/HTMLMediaElement.h: |
+ |
+2011-09-16 Adam Barth <abarth@webkit.org> |
+ |
+ Rename ENABLE(LEVELDB) to USE(LEVELDB) |
+ https://bugs.webkit.org/show_bug.cgi?id=68290 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ LEVELDB is a library that can be used to implemented INDEXED_DATABASE, |
+ which means it should be a USE not an ENABLE. |
+ |
+ * CMakeLists.txt: |
+ * WebCore.gyp/WebCore.gyp: |
+ * platform/leveldb/LevelDBComparator.h: |
+ * platform/leveldb/LevelDBDatabase.cpp: |
+ * platform/leveldb/LevelDBDatabase.h: |
+ * platform/leveldb/LevelDBIterator.h: |
+ * platform/leveldb/LevelDBSlice.h: |
+ * platform/leveldb/LevelDBTransaction.cpp: |
+ * platform/leveldb/LevelDBTransaction.h: |
+ * platform/leveldb/LevelDBWriteBatch.cpp: |
+ * platform/leveldb/LevelDBWriteBatch.h: |
+ * storage/IDBFactoryBackendImpl.cpp: |
+ (WebCore::IDBFactoryBackendImpl::open): |
+ (WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB): |
+ * storage/IDBLevelDBBackingStore.cpp: |
+ * storage/IDBLevelDBBackingStore.h: |
+ * storage/IDBLevelDBCoding.cpp: |
+ * storage/IDBLevelDBCoding.h: |
+ |
+2011-09-16 Andreas Kling <kling@webkit.org> |
+ |
+ Reduce EventTarget memory usage by deferring hash map allocation |
+ until there are listeners for more than 1 event type. |
+ |
+ http://webkit.org/b/68105 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Introduce an EventListenerMap class which manages a map of event types that have |
+ one or more listeners connected. |
+ |
+ When there is only one event type, it's stored directly on the EventListenerMap |
+ internally, and when more are added it moves to a hash map. It only goes back |
+ from the hash map if all the listeners are removed at once (i.e clear() is called.) |
+ |
+ * CMakeLists.txt: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ |
+ Adding files. |
+ |
+ * WebCore.exp.in: |
+ |
+ Export EventListenerMap::contains() for WebKit/mac. |
+ |
+ * dom/EventListenerMap.cpp: Added. |
+ (WebCore::EventListenerMap::EventListenerMap): |
+ (WebCore::EventListenerMap::~EventListenerMap): |
+ (WebCore::EventListenerMap::isEmpty): |
+ (WebCore::EventListenerMap::contains): |
+ (WebCore::EventListenerMap::clear): |
+ (WebCore::EventListenerMap::eventTypes): |
+ (WebCore::addListenerToVector): |
+ (WebCore::EventListenerMap::add): |
+ (WebCore::removeListenerFromVector): |
+ (WebCore::EventListenerMap::remove): |
+ (WebCore::EventListenerMap::find): |
+ (WebCore::removeFirstListenerCreatedFromMarkup): |
+ (WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup): |
+ (WebCore::copyListenersNotCreatedFromMarkupToTarget): |
+ (WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget): |
+ (WebCore::EventListenerIterator::EventListenerIterator): |
+ (WebCore::EventListenerIterator::nextListener): |
+ * dom/EventListenerMap.h: Added. |
+ |
+ * dom/EventTarget.cpp: |
+ (WebCore::EventTargetData::~EventTargetData): |
+ (WebCore::EventTarget::addEventListener): |
+ (WebCore::EventTarget::removeEventListener): |
+ (WebCore::EventTarget::fireEventListeners): |
+ (WebCore::EventTarget::getEventListeners): |
+ (WebCore::EventTarget::removeAllEventListeners): |
+ |
+ * dom/EventTarget.h: |
+ (WebCore::EventTarget::visitJSEventListeners): |
+ |
+ Use EventListenerIterator to visit listeners. (JSC specific.) |
+ |
+ * inspector/InspectorDOMAgent.cpp: |
+ (WebCore::InspectorDOMAgent::getEventListenersForNode): |
+ |
+ Call EventListenerMap::eventTypes() go get the list of event types |
+ currently listened for. |
+ |
+ * dom/Node.cpp: |
+ (WebCore::Node::removeEventListener): |
+ * svg/SVGUseElement.cpp: |
+ (WebCore::SVGUseElement::transferEventListenersToShadowTree): |
+ |
+ Move implementations of SVG-specific hacks into EventListenerMap and |
+ call them from here. |
+ |
+2011-09-16 Jeremy Apthorp <jeremya@chromium.org> and James Kozianski <koz@chromium.org> |
+ |
+ Don't detach elements from the render tree when entering fullscreen mode |
+ https://bugs.webkit.org/show_bug.cgi?id=66531 |
+ |
+ This prevents plugin instances from being destroyed and reinstantiated |
+ when entering fullscreen mode. |
+ |
+ Reviewed by James Robinson. |
+ |
+ Test: plugins/fullscreen-plugins-dont-reload.html |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::webkitWillEnterFullScreenForElement): |
+ (WebCore::Document::webkitDidExitFullScreenForElement): |
+ * dom/NodeRenderingContext.cpp: |
+ (WebCore::NodeRendererFactory::createRendererIfNeeded): |
+ * rendering/RenderFullScreen.cpp: |
+ (createFullScreenStyle): |
+ (RenderFullScreen::wrapRenderer): |
+ (RenderFullScreen::unwrapRenderer): |
+ * rendering/RenderFullScreen.h: |
+ |
+2011-09-16 Jochen Eisinger <jochen@chromium.org> |
+ |
+ Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter |
+ https://bugs.webkit.org/show_bug.cgi?id=68071 |
+ |
+ This will allow embedders to block images based on where the image is loaded from, instead of just blocking all images in a given frame. |
+ |
+ Reviewed by Adam Barth. |
+ |
+ * html/ImageDocument.cpp: |
+ (WebCore::ImageDocumentParser::appendBytes): |
+ * loader/FrameLoaderClient.h: |
+ (WebCore::FrameLoaderClient::allowImage): |
+ * loader/cache/CachedResourceLoader.cpp: |
+ (WebCore::CachedResourceLoader::requestImage): |
+ |
+2011-09-16 Tom Sepez <tsepez@chromium.org> |
+ |
+ Make XSSAuditor truncate inline snippets at a reasonable length before comparison |
+ respecting boundaries of multiply urlencoded sequences. |
+ https://bugs.webkit.org/show_bug.cgi?id=68092 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: http/tests/security/xssAuditor/property-escape-long.html |
+ |
+ * html/parser/XSSAuditor.cpp: |
+ (WebCore::XSSAuditor::filterTokenAfterScriptStartTag): |
+ (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected): |
+ (WebCore::XSSAuditor::eraseAttributeIfInjected): |
+ (WebCore::XSSAuditor::decodedSnippetForAttribute): |
+ (WebCore::XSSAuditor::isContainedInRequest): |
+ * html/parser/XSSAuditor.h: |
+ |
+2011-09-16 Shawn Singh <shawnsingh@chromium.org> |
+ |
+ Remove m_contentsDirty from LayerChromium because it |
+ is redundant with m_dirtyRect. |
+ https://bugs.webkit.org/show_bug.cgi?id=68213 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Code cleanup towards unit testing. |
+ |
+ * platform/graphics/chromium/Canvas2DLayerChromium.cpp: |
+ (WebCore::Canvas2DLayerChromium::updateCompositorResources): |
+ * platform/graphics/chromium/ContentLayerChromium.cpp: |
+ (WebCore::ContentLayerChromium::paintContentsIfDirty): |
+ * platform/graphics/chromium/ImageLayerChromium.cpp: |
+ (WebCore::ImageLayerChromium::paintContentsIfDirty): |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::LayerChromium): |
+ (WebCore::LayerChromium::setNeedsDisplay): |
+ (WebCore::LayerChromium::resetNeedsDisplay): |
+ * platform/graphics/chromium/LayerChromium.h: |
+ * platform/graphics/chromium/VideoLayerChromium.cpp: |
+ (WebCore::VideoLayerChromium::updateCompositorResources): |
+ * platform/graphics/chromium/WebGLLayerChromium.cpp: |
+ (WebCore::WebGLLayerChromium::updateCompositorResources): |
+ |
+2011-09-16 Dmitry Lomov <dslomov@google.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=66714 |
+ Add webkitPostMessage to allow for adding transferable support. |
+ This adds webkitPostMessage, currently identical to postMessage, which |
+ would later be a vehicle for adding transferable support for messaging. |
+ |
+ Based on patch by Luke Zarko. |
+ |
+ Reviewed by David Levin. |
+ |
+ * bindings/js/JSDOMWindowCustom.cpp: |
+ (WebCore::JSDOMWindow::webkitPostMessage): |
+ * bindings/js/JSDedicatedWorkerContextCustom.cpp: |
+ (WebCore::JSDedicatedWorkerContext::webkitPostMessage): |
+ * bindings/js/JSMessageEventCustom.cpp: |
+ (WebCore::JSMessageEvent::webkitInitMessageEvent): |
+ * bindings/js/JSMessagePortCustom.cpp: |
+ (WebCore::JSMessagePort::webkitPostMessage): |
+ * bindings/js/JSWorkerCustom.cpp: |
+ (WebCore::JSWorker::postMessage): |
+ (WebCore::JSWorker::webkitPostMessage): |
+ * bindings/v8/custom/V8DOMWindowCustom.cpp: |
+ (WebCore::handlePostMessageCallback): |
+ (WebCore::V8DOMWindow::postMessageCallback): |
+ (WebCore::V8DOMWindow::webkitPostMessageCallback): |
+ * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: |
+ (WebCore::handlePostMessageCallback): |
+ (WebCore::V8DedicatedWorkerContext::postMessageCallback): |
+ (WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback): |
+ * bindings/v8/custom/V8MessageEventCustom.cpp: |
+ (WebCore::V8MessageEvent::initMessageEventCallback): |
+ (WebCore::V8MessageEvent::webkitInitMessageEventCallback): |
+ * bindings/v8/custom/V8MessagePortCustom.cpp: |
+ (WebCore::handlePostMessageCallback): |
+ (WebCore::V8MessagePort::postMessageCallback): |
+ (WebCore::V8MessagePort::webkitPostMessageCallback): |
+ * bindings/v8/custom/V8WorkerCustom.cpp: |
+ (WebCore::handlePostMessageCallback): |
+ (WebCore::V8Worker::postMessageCallback): |
+ (WebCore::V8Worker::webkitPostMessageCallback): |
+ * dom/MessageEvent.idl: |
+ * dom/MessagePort.idl: |
+ * page/DOMWindow.idl: |
+ * workers/DedicatedWorkerContext.idl: |
+ * workers/Worker.idl: |
+ |
+2011-09-16 Alexei Svitkine <asvitkine@chromium.org> |
+ |
+ Chromium: Fix repaint of rubber-band overhang area under composited path |
+ https://bugs.webkit.org/show_bug.cgi?id=68246 |
+ |
+ I accidently removed these two lines from the last patch on: https://bugs.webkit.org/show_bug.cgi?id=66969 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Test: platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::scrollContents): |
+ |
+2011-09-16 Peter Beverloo <peter@chromium.org> |
+ |
+ Depend on harfbuzz for OS=Android as well |
+ https://bugs.webkit.org/show_bug.cgi?id=68239 |
+ |
+ Like GTK, Android depends on harfbuzz as well, so reflect that in |
+ the project file. Furthermore, fix a compile error in PopupListBox.cpp |
+ by explicitly including ctype.h, as isspace otherwise won't be declared. |
+ |
+ Reviewed by Steve Block. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ * platform/chromium/PopupListBox.cpp: |
+ |
+2011-09-16 Tony Chang <tony@chromium.org> |
+ |
+ Rename flex-align values to match the spec |
+ https://bugs.webkit.org/show_bug.cgi?id=67741 |
+ |
+ Reviewed by Ojan Vafai. |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseValue): |
+ * css/CSSPrimitiveValueMappings.h: |
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): |
+ (WebCore::CSSPrimitiveValue::operator EFlexAlign): |
+ * css/CSSValueKeywords.in: |
+ * rendering/style/RenderStyleConstants.h: |
+ |
+2011-09-16 Kentaro Hara <haraken@chromium.org> |
+ |
+ Implement an ErrorEvent constructor for JSC |
+ https://bugs.webkit.org/show_bug.cgi?id=68148 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ The spec for the ErrorEvent constructor is here: |
+ http://dev.w3.org/html5/workers/#errorevent |
+ |
+ Test: fast/events/constructors/error-event-constructor.html |
+ |
+ * bindings/generic/EventConstructors.h: Added a definition for the ErrorEvent constructor. |
+ * bindings/js/JSEventConstructors.cpp: Added #includes for ErrorEvent. |
+ * dom/ErrorEvent.cpp: |
+ (WebCore::ErrorEventInit::ErrorEventInit): |
+ (WebCore::ErrorEvent::ErrorEvent): |
+ (WebCore::ErrorEvent::initErrorEvent): |
+ (WebCore::ErrorEvent::isErrorEvent): |
+ * dom/ErrorEvent.h: Added a definition for ErrorEventInit. |
+ (WebCore::ErrorEvent::create): |
+ (WebCore::ErrorEvent::message): |
+ (WebCore::ErrorEvent::filename): |
+ (WebCore::ErrorEvent::lineno): |
+ * dom/ErrorEvent.idl: Makes ErrorEvent constructible. |
+ |
+2011-09-16 Kentaro Hara <haraken@google.com> |
+ |
+ Overhangs a ruby by no more than half the width of the neighboring text. |
+ https://bugs.webkit.org/show_bug.cgi?id=62684 |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Assume two rubies between which a narrow text exists, like |
+ "<ruby>x<rt>xxxxxx</rt></ruby>l<ruby>y<rt>yyyyyy</rt></ruby>". |
+ In order to avoid the two rubies overlapping with each other, |
+ this patch overhangs the ruby by no more than half the ruby font |
+ size and no more than half the width of the neighboring text. |
+ |
+ Tests: fast/ruby/overhang-horizontal-no-overlap1.html |
+ fast/ruby/overhang-horizontal-no-overlap2.html |
+ fast/ruby/overhang-vertical-no-overlap1.html |
+ fast/ruby/overhang-vertical-no-overlap2.html |
+ |
+ * rendering/RenderRubyRun.cpp: |
+ (WebCore::RenderRubyRun::getOverhang): Calculates the width of ruby overhanging. |
+ |
+2011-09-16 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95304. |
+ http://trac.webkit.org/changeset/95304 |
+ https://bugs.webkit.org/show_bug.cgi?id=68299 |
+ |
+ Broke GTK+ builds. It pulls derived headers into main.c |
+ (Requested by rniwa on #webkit). |
+ |
+ * bindings/scripts/CodeGeneratorGObject.pm: |
+ (): |
+ * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: |
+ * bindings/scripts/test/GObject/WebKitDOMTestCallback.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: |
+ * bindings/scripts/test/GObject/WebKitDOMTestInterface.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp: |
+ * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: |
+ (webkit_dom_test_obj_conditional_method1): |
+ (webkit_dom_test_obj_conditional_method2): |
+ (webkit_dom_test_obj_conditional_method3): |
+ (webkit_dom_test_obj_get_conditional_attr1): |
+ (webkit_dom_test_obj_set_conditional_attr1): |
+ (webkit_dom_test_obj_get_conditional_attr2): |
+ (webkit_dom_test_obj_set_conditional_attr2): |
+ (webkit_dom_test_obj_get_conditional_attr3): |
+ (webkit_dom_test_obj_set_conditional_attr3): |
+ (webkit_dom_test_obj_set_property): |
+ (webkit_dom_test_obj_get_property): |
+ (webkit_dom_test_obj_class_init): |
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: |
+ * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: |
+ |
+2011-09-16 Shawn Singh <shawnsingh@chromium.org> |
+ |
+ Re-named isRootLayer to isNonCompositedContent because |
+ that is what the flag actually means. |
+ https://bugs.webkit.org/show_bug.cgi?id=68214 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Code cleanup towards unit testing. |
+ |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::LayerChromium): |
+ (WebCore::LayerChromium::pushPropertiesTo): |
+ * platform/graphics/chromium/LayerChromium.h: |
+ (WebCore::LayerChromium::setIsNonCompositedContent): |
+ (WebCore::LayerChromium::isNonCompositedContent): |
+ * platform/graphics/chromium/NonCompositedContentHost.cpp: |
+ (WebCore::NonCompositedContentHost::NonCompositedContentHost): |
+ * platform/graphics/chromium/TiledLayerChromium.cpp: |
+ (WebCore::TiledLayerChromium::setLayerTreeHost): |
+ * platform/graphics/chromium/cc/CCLayerImpl.cpp: |
+ (WebCore::CCLayerImpl::CCLayerImpl): |
+ * platform/graphics/chromium/cc/CCLayerImpl.h: |
+ (WebCore::CCLayerImpl::setIsNonCompositedContent): |
+ (WebCore::CCLayerImpl::isNonCompositedContent): |
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: |
+ (WebCore::CCTiledLayerImpl::draw): |
+ |
+2011-09-16 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms |
+ https://bugs.webkit.org/show_bug.cgi?id=68134 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Add a new setting to control whether the mock scrollbar theme is used. |
+ This is a global setting, so that it can be set without having to |
+ access a specific Settings object. |
+ |
+ * page/Settings.h: |
+ (WebCore::Settings::setMockScrollbarsEnabled): |
+ (WebCore::Settings::mockScrollbarsEnabled): |
+ |
+2011-09-16 Ben Wells <benwells@chromium.org> |
+ |
+ Large canvas fills should not crash or create unnecessarily large image buffers |
+ https://bugs.webkit.org/show_bug.cgi?id=67988 |
+ |
+ When using source-in, destination-in, source-out, or destination-atop a temporary |
+ buffer is created. This buffer only needs to be big enough to cover the intersection |
+ of the path and the canvas. If the area of intersection between the fill and the |
+ canvas is empty the canvas is completely cleared and a temporary buffer is not used. |
+ |
+ This change also adds some null checks for failures to create contexts or buffers. |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Test: fast/canvas/canvas-large-fills.html |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::clearCanvas): |
+ (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere): |
+ |
+2011-09-16 Shawn Singh <shawnsingh@chromium.org> |
+ |
+ Remove default NULL argument in LayerChromium::create(). |
+ https://bugs.webkit.org/show_bug.cgi?id=68211 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Code cleanup related to creating unit testing. |
+ |
+ * platform/graphics/chromium/LayerChromium.h: |
+ |
+2011-09-16 Adrienne Walker <enne@google.com> |
+ |
+ [chromium] Move quad drawing code from LayerChromium to LayerRendererChromium |
+ https://bugs.webkit.org/show_bug.cgi?id=68272 |
+ |
+ Reviewed by James Robinson. |
+ |
+ All the OpenGL code is in LayerRendererChromium and the CCLayerImpl |
+ tree, so move the static drawTexturedQuad/toGLMatrix functions to |
+ LayerRendererChromium, where they really belong. |
+ |
+ Just moving code around. Tested by existing compositor tests. |
+ |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ * platform/graphics/chromium/LayerChromium.h: |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::toGLMatrix): |
+ (WebCore::LayerRendererChromium::drawTexturedQuad): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: |
+ (WebCore::CCCanvasLayerImpl::draw): |
+ * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: |
+ (WebCore::CCHeadsUpDisplay::draw): |
+ * platform/graphics/chromium/cc/CCLayerImpl.cpp: |
+ (WebCore::CCLayerImpl::drawDebugBorder): |
+ * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: |
+ (WebCore::CCPluginLayerImpl::draw): |
+ * platform/graphics/chromium/cc/CCRenderSurface.cpp: |
+ (WebCore::CCRenderSurface::drawSurface): |
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: |
+ (WebCore::CCTiledLayerImpl::drawTiles): |
+ * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: |
+ (WebCore::CCVideoLayerImpl::drawYUV): |
+ (WebCore::CCVideoLayerImpl::drawRGBA): |
+ |
+2011-09-16 Shawn Singh <shawnsingh@chromium.org> |
+ |
+ Fixed const correctness on accessors in LayerChromium |
+ https://bugs.webkit.org/show_bug.cgi?id=68210 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Code cleanup related to creating unit testing. |
+ |
+ * platform/graphics/chromium/LayerChromium.h: |
+ (WebCore::LayerChromium::preserves3D): |
+ (WebCore::LayerChromium::replicaLayer): |
+ |
+2011-09-14 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Deleting line break before h1 converts h1 to span |
+ https://bugs.webkit.org/show_bug.cgi?id=45784 |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ Fixed the bug by treating h1 and other elements that retain structure like Mail blockquote. |
+ |
+ We already had a logic to overriding styles of merged paragraphs by Mail blockquote so |
+ just extend this logic for h1-h6, pre, etc... |
+ |
+ Tests: editing/deleting/merge-paragraph-from-address.html |
+ editing/deleting/merge-paragraph-from-h6-with-style.html |
+ editing/deleting/merge-paragraph-from-h6.html |
+ editing/deleting/merge-paragraph-from-listing.html |
+ editing/deleting/merge-paragraph-into-h1-with-style.html |
+ editing/deleting/merge-paragraph-into-h1.html |
+ editing/deleting/merge-paragraph-into-pre.html |
+ |
+ * editing/ReplaceSelectionCommand.cpp: |
+ (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): |
+ * editing/markup.cpp: |
+ (WebCore::isBlockNodeToRetainAppearance): Extracted from ancestorToRetainStructureAndAppearance. |
+ (WebCore::StyledMarkupAccumulator::serializeNodes): |
+ (WebCore::ancestorToRetainStructureAndAppearance): |
+ * editing/markup.h: |
+ |
+2011-09-16 Max Perepelitsyn <pph34r@gmail.com> |
+ |
+ Set but not used variables cleanup (gcc 4.6) |
+ https://bugs.webkit.org/show_bug.cgi?id=68157 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ * platform/audio/ReverbConvolverStage.cpp: |
+ (WebCore::ReverbConvolverStage::process): |
+ * rendering/RenderMediaControlsChromium.cpp: |
+ (WebCore::paintMediaButton): |
+ |
+2011-09-16 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Removed undetectable style.filter. |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ This feature was added in http://trac.webkit.org/changeset/15557 to |
+ support housingmaps.com. But housingmaps.com no longer needs this hack, |
+ we don't know of other websites that need it, and we don't know of |
+ any other browsers that have implemented this feature. |
+ |
+ * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Removed. |
+ * WebCore.order: |
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp: |
+ (WebCore::JSCSSStyleDeclaration::nameGetter): |
+ |
+2011-09-16 Adam Barth <abarth@webkit.org> |
+ |
+ Update JSC results to account for intrinsics change. |
+ |
+ * bindings/scripts/test/JS/JSTestInterface.cpp: |
+ * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: |
+ * bindings/scripts/test/JS/JSTestObj.cpp: |
+ * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: |
+ |
+2011-09-16 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95312. |
+ http://trac.webkit.org/changeset/95312 |
+ https://bugs.webkit.org/show_bug.cgi?id=68277 |
+ |
+ It's innocent, innocent I tell you! (Requested by jamesr_ on |
+ #webkit). |
+ |
+ * platform/graphics/chromium/ContentLayerChromium.cpp: |
+ (WebCore::ContentLayerChromium::createTextureUpdater): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::LayerRendererChromium): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: |
+ * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
+ (WebCore::CCThreadProxy::context): |
+ (WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread): |
+ (WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread): |
+ (WebCore::CCThreadProxy::setNeedsRedrawOnCCThread): |
+ |
+2011-09-16 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95309. |
+ http://trac.webkit.org/changeset/95309 |
+ https://bugs.webkit.org/show_bug.cgi?id=68271 |
+ |
+ Broke many chromium gpu tests. (Requested by dave_levin on |
+ #webkit). |
+ |
+ * platform/graphics/chromium/ContentLayerChromium.cpp: |
+ (WebCore::ContentLayerChromium::createTextureUpdater): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::LayerRendererChromium): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: |
+ * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
+ (WebCore::CCThreadProxy::context): |
+ (WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread): |
+ (WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread): |
+ (WebCore::CCThreadProxy::setNeedsRedrawOnCCThread): |
+ |
+2011-09-16 Filip Pizlo <fpizlo@apple.com> |
+ |
+ DFG JIT should inline Math.abs |
+ https://bugs.webkit.org/show_bug.cgi?id=68227 |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ Added JavaScriptCore/dfg to include path path. Changed the bindings |
+ scripts to handle the presence of intrinsics. |
+ |
+ * CMakeLists.txt: |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ (GenerateHashTable): |
+ |
+2011-09-16 Iain Merrick <husky@google.com> |
+ |
+ [chromium] Fix CCLayerTreeHostTest |
+ https://bugs.webkit.org/show_bug.cgi?id=67418 |
+ |
+ This is a minimal set of changes to get CCLayerTreeHostTest |
+ compiling, running and passing with USE_THREADED_COMPOSITING |
+ enabled. |
+ |
+ Reviewed by James Robinson. |
+ |
+ * platform/graphics/chromium/ContentLayerChromium.cpp: |
+ (WebCore::ContentLayerChromium::createTextureUpdater): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::LayerRendererChromium): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
+ (WebCore::CCLayerTreeHost::createLayerTreeHostImpl): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: |
+ * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
+ (WebCore::CCThreadProxy::context): |
+ (WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread): |
+ (WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread): |
+ (WebCore::CCThreadProxy::setNeedsRedrawOnCCThread): |
+ |
+2011-09-16 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95227. |
+ http://trac.webkit.org/changeset/95227 |
+ https://bugs.webkit.org/show_bug.cgi?id=68262 |
+ |
+ Broke a bunch of SVG tests (Requested by andersca on #webkit). |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::contentsSize): |
+ (WebCore::ScrollView::wheelEvent): |
+ * platform/ScrollView.h: |
+ * platform/mac/ScrollViewMac.mm: |
+ (WebCore::ScrollView::platformContentsSize): |
+ * platform/wx/ScrollViewWx.cpp: |
+ (WebCore::ScrollView::platformContentsSize): |
+ |
+2011-09-16 James Simonsen <simonjam@chromium.org> |
+ |
+ Fix HTML5 parser's adoption agency algorithm to reparent correctly |
+ https://bugs.webkit.org/show_bug.cgi?id=68147 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ * html/parser/HTMLTreeBuilder.cpp: |
+ (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): |
+ |
+2011-09-16 Adam Barth <abarth@webkit.org> |
+ |
+ CodeGeneratorGObject should use C++ style comments for ENABLE guards |
+ https://bugs.webkit.org/show_bug.cgi?id=68256 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ This patch should have not behavioral effect. It just cleans up the |
+ GObject code generator to use C++-style comments for ENABLE guards and |
+ to use the usual comment style for license blocks. |
+ |
+ * bindings/scripts/CodeGeneratorGObject.pm: |
+ * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: |
+ * bindings/scripts/test/GObject/WebKitDOMTestCallback.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: |
+ * bindings/scripts/test/GObject/WebKitDOMTestInterface.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp: |
+ * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: |
+ (webkit_dom_test_obj_conditional_method1): |
+ (webkit_dom_test_obj_conditional_method2): |
+ (webkit_dom_test_obj_conditional_method3): |
+ (webkit_dom_test_obj_get_conditional_attr1): |
+ (webkit_dom_test_obj_set_conditional_attr1): |
+ (webkit_dom_test_obj_get_conditional_attr2): |
+ (webkit_dom_test_obj_set_conditional_attr2): |
+ (webkit_dom_test_obj_get_conditional_attr3): |
+ (webkit_dom_test_obj_set_conditional_attr3): |
+ (webkit_dom_test_obj_set_property): |
+ (webkit_dom_test_obj_get_property): |
+ (webkit_dom_test_obj_class_init): |
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: |
+ * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: |
+ |
+2011-09-16 Csaba Osztrogonác <ossy@webkit.org> |
+ |
+ [Qt] REGRESSION(r95091) It made many tests flakey |
+ https://bugs.webkit.org/show_bug.cgi?id=68232 |
+ |
+ Unreviewed rolling out r95091 and followup patches. |
+ |
+ * English.lproj/localizedStrings.js: |
+ * bindings/v8/V8Proxy.cpp: |
+ (WebCore::V8Proxy::callFunction): |
+ * bindings/v8/V8Proxy.h: |
+ * bindings/v8/custom/V8CustomVoidCallback.cpp: |
+ (WebCore::invokeCallback): |
+ * dom/ScriptedAnimationController.cpp: |
+ (WebCore::ScriptedAnimationController::registerCallback): |
+ (WebCore::ScriptedAnimationController::cancelCallback): |
+ (WebCore::ScriptedAnimationController::serviceScriptedAnimations): |
+ * inspector/InspectorInstrumentation.cpp: |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::willCallFunction): |
+ * inspector/InspectorTimelineAgent.cpp: |
+ * inspector/InspectorTimelineAgent.h: |
+ * inspector/TimelineRecordFactory.cpp: |
+ * inspector/TimelineRecordFactory.h: |
+ * inspector/front-end/TimelineAgent.js: |
+ * inspector/front-end/TimelinePanel.js: |
+ (WebInspector.TimelinePanel): |
+ (WebInspector.TimelinePanel.prototype.get _recordStyles): |
+ (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): |
+ (WebInspector.TimelinePanel.prototype._clearPanel): |
+ (WebInspector.TimelinePanel.FormattedRecord): |
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): |
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): |
+ |
+2011-09-16 Abhishek Arya <inferno@chromium.org> |
+ |
+ cachedFont not getting updated for inline SVG text. |
+ https://bugs.webkit.org/show_bug.cgi?id=68060 |
+ |
+ Reviewed by Nikolas Zimmermann. |
+ |
+ The cached scaledFont needs to be updated on every style set call. It |
+ is not similar to m_style which can get derived from parent's style and |
+ hence will get automatically updated on ancestor's style change. This is |
+ required, otherwise we will maintain stale font list in cached scaledFont |
+ when custom fonts are retired on Document::recalcStyle. |
+ |
+ Test: svg/text/text-style-recalc-crash.html |
+ |
+ * rendering/svg/RenderSVGInlineText.cpp: |
+ (WebCore::RenderSVGInlineText::styleDidChange): |
+ (WebCore::RenderSVGInlineText::setStyle): |
+ * rendering/svg/RenderSVGInlineText.h: |
+ |
+2011-09-16 Antti Koivisto <antti@apple.com> |
+ |
+ REGRESSION (r95052): SelectorChecker identifier filter not working |
+ https://bugs.webkit.org/show_bug.cgi?id=68244 |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Missing &. |
+ |
+ * css/SelectorChecker.cpp: |
+ (WebCore::collectDescendantSelectorIdentifierHashes): |
+ |
+2011-09-16 Csaba Osztrogonác <ossy@webkit.org> |
+ |
+ Unreviewed typo fix after r95271. |
+ |
+ * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: |
+ |
+2011-09-16 Andrey Kosyakov <caseq@chromium.org> |
+ |
+ Web Inspector: [Extensions API] support extensions for remote inspector front-end |
+ https://bugs.webkit.org/show_bug.cgi?id=67840 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ - Merge ExtensionCommon.js into ExtensionAPI.js |
+ - refactor building of extension API for better reuse |
+ - expose interface for extension registration |
+ |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * inspector/front-end/ExtensionAPI.js: |
+ (defineCommonExtensionSymbols): |
+ (buildExtensionAPIInjectedScript): |
+ * inspector/front-end/ExtensionCommon.js: |
+ * inspector/front-end/ExtensionServer.js: |
+ (WebInspector.ExtensionServer.prototype._addExtensions): |
+ (WebInspector.ExtensionServer.prototype._addExtension): |
+ (WebInspector.ExtensionServer.prototype._buildExtensionAPIScript): |
+ (WebInspector.ExtensionServer.prototype._onWindowMessage): |
+ (WebInspector.ExtensionServer.prototype._registerExtension): |
+ (WebInspector.ExtensionServer.prototype._expandResourcePath): |
+ * inspector/front-end/WebKit.qrc: |
+ * inspector/front-end/inspector.html: |
+ |
+2011-09-16 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Web Inspector: change WebInspector.currentPanel getter/setter to functions. |
+ https://bugs.webkit.org/show_bug.cgi?id=68242 |
+ |
+ This is necessary for the panel switching performance tests. |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/Drawer.js: |
+ (WebInspector.Drawer.prototype.show.animationFinished): |
+ (WebInspector.Drawer.prototype.show): |
+ (WebInspector.Drawer.prototype.hide): |
+ (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): |
+ (WebInspector.Drawer.prototype._animateDrawerHeight): |
+ (WebInspector.Drawer.prototype._statusBarDragging): |
+ * inspector/front-end/ElementsPanel.js: |
+ (WebInspector.ElementsPanel.prototype.switchToAndFocus): |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.ResourcesPanel.prototype.showAnchorLocation): |
+ * inspector/front-end/ScriptsPanel.js: |
+ * inspector/front-end/SearchController.js: |
+ (WebInspector.SearchController.prototype.updateSearchMatchesCount): |
+ (WebInspector.SearchController.prototype.updateCurrentMatchIndex): |
+ (WebInspector.SearchController.prototype.updateSearchLabel): |
+ (WebInspector.SearchController.prototype.handleShortcut): |
+ (WebInspector.SearchController.prototype._performSearch): |
+ * inspector/front-end/Toolbar.js: |
+ (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked): |
+ (WebInspector.Toolbar.createPanelToolbarItem): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.currentPanel): |
+ (WebInspector._updateFocusedNode): |
+ (WebInspector.windowResize): |
+ (WebInspector.documentKeyDown): |
+ (WebInspector.documentCanCopy): |
+ (WebInspector.documentCopy): |
+ (WebInspector.showPanel): |
+ (WebInspector.startUserInitiatedDebugging): |
+ (WebInspector.inspect): |
+ (WebInspector._showAnchorLocationInPanel): |
+ (WebInspector._toolbarItemClicked): |
+ (WebInspector.PanelHistory.prototype.goBack): |
+ (WebInspector.PanelHistory.prototype.goForward): |
+ |
+2011-09-15 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc. |
+ https://bugs.webkit.org/show_bug.cgi?id=68165 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * inspector/InjectedScriptHost.cpp: |
+ (WebCore::InjectedScriptHost::clearConsoleMessages): |
+ * inspector/Inspector.json: |
+ * inspector/InspectorConsoleAgent.cpp: |
+ (WebCore::InspectorConsoleAgent::clearMessages): |
+ * inspector/InspectorConsoleAgent.h: |
+ * inspector/front-end/ConsoleModel.js: |
+ (WebInspector.ConsoleModel.prototype.requestClearMessages): |
+ |
+2011-09-16 Alejandro G. Castro <alex@igalia.com> |
+ |
+ Fix GTK build after r95245. |
+ |
+ * GNUmakefile.list.am: |
+ |
+2011-09-16 Leo Yang <leo.yang@torchmobile.com.cn> |
+ |
+ [Qt] Crash when dragging google maps. |
+ https://bugs.webkit.org/show_bug.cgi?id=68223 |
+ |
+ The custom image for a cursor might not be ready when WebKit trying |
+ to use it to construct the cursor in Qt porting. This patch is using |
+ arrow image to substitute the unready custom image. |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: fast/css/crash-on-custom-cursor-when-loading.html |
+ |
+ * platform/qt/CursorQt.cpp: |
+ (WebCore::createCustomCursor): |
+ (WebCore::Cursor::ensurePlatformCursor): |
+ |
+2011-09-15 Adam Barth <abarth@webkit.org> |
+ |
+ Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE) |
+ https://bugs.webkit.org/show_bug.cgi?id=68205 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ As discussed on webkit-dev. |
+ |
+ * CMakeLists.txt: |
+ * Configurations/FeatureDefines.xcconfig: |
+ * GNUmakefile.am: |
+ * GNUmakefile.list.am: |
+ * UseJSC.cmake: |
+ * bindings/generic/RuntimeEnabledFeatures.cpp: |
+ * bindings/generic/RuntimeEnabledFeatures.h: |
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp: |
+ * bindings/js/JSDOMBinding.cpp: |
+ (WebCore::setDOMException): |
+ * bindings/js/JSExceptionBase.cpp: |
+ (WebCore::toExceptionBase): |
+ * bindings/js/JSInjectedScriptHostCustom.cpp: |
+ (WebCore::JSInjectedScriptHost::databaseId): |
+ * bindings/js/JSSQLResultSetRowListCustom.cpp: |
+ * bindings/js/JSSQLTransactionCustom.cpp: |
+ * bindings/js/JSSQLTransactionSyncCustom.cpp: |
+ * bindings/scripts/test/CPP/WebDOMTestCallback.cpp: |
+ * bindings/scripts/test/CPP/WebDOMTestCallback.h: |
+ * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: |
+ * bindings/scripts/test/JS/JSTestCallback.cpp: |
+ * bindings/scripts/test/JS/JSTestCallback.h: |
+ * bindings/scripts/test/ObjC/DOMTestCallback.mm: |
+ * bindings/scripts/test/TestCallback.idl: |
+ * bindings/scripts/test/V8/V8TestCallback.cpp: |
+ * bindings/scripts/test/V8/V8TestCallback.h: |
+ * bindings/v8/V8Proxy.cpp: |
+ (WebCore::V8Proxy::setDOMException): |
+ * bindings/v8/V8Proxy.h: |
+ * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: |
+ * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: |
+ (WebCore::V8InjectedScriptHost::databaseIdCallback): |
+ * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: |
+ * bindings/v8/custom/V8SQLTransactionCustom.cpp: |
+ * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp: |
+ * dom/Document.cpp: |
+ * dom/Document.h: |
+ * dom/ExceptionCode.cpp: |
+ (WebCore::getExceptionCodeDescription): |
+ * dom/ExceptionCode.h: |
+ * dom/ScriptExecutionContext.cpp: |
+ (WebCore::ScriptExecutionContext::ScriptExecutionContext): |
+ (WebCore::ScriptExecutionContext::~ScriptExecutionContext): |
+ * dom/ScriptExecutionContext.h: |
+ * features.pri: |
+ * history/PageCache.cpp: |
+ (WebCore::logCanCacheFrameDecision): |
+ (WebCore::PageCache::canCachePageContainingThisFrame): |
+ * inspector/InjectedScriptHost.cpp: |
+ (WebCore::InjectedScriptHost::InjectedScriptHost): |
+ (WebCore::InjectedScriptHost::disconnect): |
+ * inspector/InjectedScriptHost.h: |
+ (WebCore::InjectedScriptHost::init): |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::InspectorController): |
+ (WebCore::InspectorController::connectFrontend): |
+ (WebCore::InspectorController::disconnectFrontend): |
+ (WebCore::InspectorController::restoreInspectorStateFromCookie): |
+ * inspector/InspectorController.h: |
+ * inspector/InspectorDatabaseAgent.cpp: |
+ * inspector/InspectorDatabaseInstrumentation.h: |
+ * inspector/InspectorDatabaseResource.cpp: |
+ * inspector/InspectorDatabaseResource.h: |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::didCommitLoadImpl): |
+ * inspector/InspectorInstrumentation.h: |
+ * inspector/InstrumentingAgents.h: |
+ (WebCore::InstrumentingAgents::InstrumentingAgents): |
+ * inspector/WorkerInspectorController.cpp: |
+ (WebCore::WorkerInspectorController::WorkerInspectorController): |
+ (WebCore::WorkerInspectorController::connectFrontend): |
+ * loader/EmptyClients.h: |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::stopLoading): |
+ * page/ChromeClient.h: |
+ * page/DOMWindow.cpp: |
+ * page/DOMWindow.h: |
+ * page/DOMWindow.idl: |
+ * platform/sql/SQLiteAuthorizer.cpp: |
+ * platform/sql/SQLiteDatabase.cpp: |
+ * platform/sql/SQLiteFileSystem.cpp: |
+ * platform/sql/SQLiteStatement.cpp: |
+ * platform/sql/SQLiteTransaction.cpp: |
+ * storage/AbstractDatabase.cpp: |
+ * storage/AbstractDatabase.h: |
+ * storage/ChangeVersionWrapper.cpp: |
+ * storage/ChangeVersionWrapper.h: |
+ * storage/Database.cpp: |
+ * storage/Database.h: |
+ * storage/Database.idl: |
+ * storage/DatabaseAuthorizer.cpp: |
+ * storage/DatabaseCallback.h: |
+ * storage/DatabaseCallback.idl: |
+ * storage/DatabaseDetails.h: |
+ * storage/DatabaseSync.cpp: |
+ * storage/DatabaseSync.h: |
+ * storage/DatabaseSync.idl: |
+ * storage/DatabaseTask.cpp: |
+ * storage/DatabaseTask.h: |
+ * storage/DatabaseThread.cpp: |
+ * storage/DatabaseThread.h: |
+ * storage/DatabaseTracker.cpp: |
+ * storage/DatabaseTracker.h: |
+ * storage/DatabaseTrackerClient.h: |
+ * storage/OriginQuotaManager.cpp: |
+ * storage/OriginQuotaManager.h: |
+ * storage/OriginUsageRecord.cpp: |
+ * storage/OriginUsageRecord.h: |
+ * storage/SQLCallbackWrapper.h: |
+ * storage/SQLError.h: |
+ * storage/SQLError.idl: |
+ * storage/SQLException.h: |
+ * storage/SQLException.idl: |
+ * storage/SQLResultSet.cpp: |
+ * storage/SQLResultSet.h: |
+ * storage/SQLResultSet.idl: |
+ * storage/SQLResultSetRowList.cpp: |
+ * storage/SQLResultSetRowList.h: |
+ * storage/SQLResultSetRowList.idl: |
+ * storage/SQLStatement.cpp: |
+ * storage/SQLStatement.h: |
+ * storage/SQLStatementCallback.h: |
+ * storage/SQLStatementCallback.idl: |
+ * storage/SQLStatementErrorCallback.h: |
+ * storage/SQLStatementErrorCallback.idl: |
+ * storage/SQLStatementSync.cpp: |
+ * storage/SQLStatementSync.h: |
+ * storage/SQLTransaction.cpp: |
+ * storage/SQLTransaction.h: |
+ * storage/SQLTransaction.idl: |
+ * storage/SQLTransactionCallback.h: |
+ * storage/SQLTransactionCallback.idl: |
+ * storage/SQLTransactionClient.cpp: |
+ * storage/SQLTransactionClient.h: |
+ * storage/SQLTransactionCoordinator.cpp: |
+ * storage/SQLTransactionCoordinator.h: |
+ * storage/SQLTransactionErrorCallback.h: |
+ * storage/SQLTransactionErrorCallback.idl: |
+ * storage/SQLTransactionSync.cpp: |
+ * storage/SQLTransactionSync.h: |
+ * storage/SQLTransactionSync.idl: |
+ * storage/SQLTransactionSyncCallback.h: |
+ * storage/SQLTransactionSyncCallback.idl: |
+ * storage/chromium/DatabaseObserver.h: |
+ * storage/chromium/DatabaseTrackerChromium.cpp: |
+ * storage/chromium/QuotaTracker.cpp: |
+ * storage/chromium/QuotaTracker.h: |
+ * storage/chromium/SQLTransactionClientChromium.cpp: |
+ * workers/WorkerContext.cpp: |
+ * workers/WorkerContext.h: |
+ * workers/WorkerContext.idl: |
+ * workers/WorkerThread.cpp: |
+ (WebCore::WorkerThreadShutdownStartTask::performTask): |
+ (WebCore::WorkerThread::stop): |
+ |
+2011-09-15 Alexandru Chiculita <achicu@adobe.com> |
+ |
+ [CSSRegions] Regions should not slice line box rendering |
+ https://bugs.webkit.org/show_bug.cgi?id=66198 |
+ |
+ Created a new LayoutState constructor for the RenderFlowThread. It will |
+ set m_isPaginated to true and force a pageHeight if 1. The actual pageHeight is |
+ not used, because pageLogicalHeightForOffset will actually redirect the call |
+ to RenderFlowThread. |
+ |
+ Removed some of the duplicate code that calculated the page logical offset. |
+ Added new methods like logicalPageOffset, pageLogicalHeightForOffset, |
+ pageRemainingLogicalHeightForOffset. |
+ |
+ There are still some issues related to incremental layout and different region widths. |
+ Those issues will be addressed in different patches. |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Tests: fast/regions/text-region-breaks.html |
+ fast/regions/text-region-split-horizontal-bt.html |
+ fast/regions/text-region-split-vertical-rl.html |
+ fast/regions/text-region-split-vertical.html |
+ fast/regions/text-region-split.html |
+ |
+ * rendering/LayoutState.cpp: |
+ (WebCore::LayoutState::LayoutState): |
+ * rendering/LayoutState.h: |
+ (WebCore::LayoutState::LayoutState): |
+ (WebCore::LayoutState::isPaginated): |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::positionNewFloats): |
+ (WebCore::RenderBlock::adjustForRegionFittingIfNeeded): |
+ (WebCore::RenderBlock::nextPageLogicalTopExcludingBoundaryPoint): |
+ (WebCore::RenderBlock::nextPageLogicalTopIncludingBoundaryPoint): |
+ (WebCore::inNormalFlow): |
+ (WebCore::RenderBlock::applyBeforeBreak): |
+ (WebCore::RenderBlock::applyAfterBreak): |
+ (WebCore::RenderBlock::logicalPageOffset): |
+ (WebCore::RenderBlock::pageLogicalHeightForOffset): |
+ (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset): |
+ (WebCore::RenderBlock::adjustForUnsplittableChild): |
+ (WebCore::RenderBlock::adjustLinePositionForPagination): |
+ * rendering/RenderBlock.h: |
+ * rendering/RenderFlowThread.cpp: |
+ (WebCore::RenderFlowThread::layout): |
+ (WebCore::RenderFlowThread::regionLogicalHeightForLine): |
+ (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine): |
+ * rendering/RenderFlowThread.h: |
+ * rendering/RenderView.cpp: |
+ (WebCore::RenderView::pushLayoutState): |
+ * rendering/RenderView.h: |
+ (WebCore::LayoutStateMaintainer::LayoutStateMaintainer): |
+ (WebCore::LayoutStateMaintainer::push): |
+ |
+2011-09-15 Kentaro Hara <haraken@google.com> |
+ |
+ Implement a PopStateEvent constructor for JSC |
+ https://bugs.webkit.org/show_bug.cgi?id=67977 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Test: fast/events/constructors/pop-state-event-constructor.html |
+ |
+ * bindings/generic/EventConstructors.h: Added a definition for the PopStateEvent constructor. |
+ * bindings/js/JSEventConstructors.cpp: Added #includes for PopStateEvent. |
+ * dom/PopStateEvent.cpp: |
+ (WebCore::PopStateEventInit::PopStateEventInit): |
+ (WebCore::PopStateEvent::PopStateEvent): |
+ (WebCore::PopStateEvent::create): |
+ * dom/PopStateEvent.h: Added a definition for PopStateEventInit. |
+ * dom/PopStateEvent.idl: Makes PopStateEvent constructible. |
+ |
+2011-09-15 Mihai Parparita <mihaip@chromium.org> |
+ |
+ Fragment navigations should interrupt a provisional load of a different document |
+ https://bugs.webkit.org/show_bug.cgi?id=64556 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Tests: http/tests/history/back-with-fragment-change.php |
+ http/tests/navigation/navigation-interrupted-by-fragment.html |
+ |
+ * loader/FrameLoader.cpp: Stop provisional load if a fragment commits. |
+ * loader/HistoryController.cpp: Don't commit the wrong provisional item. |
+ |
+2011-09-15 Adrienne Walker <enne@google.com> |
+ |
+ [chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash |
+ https://bugs.webkit.org/show_bug.cgi?id=68204 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Add CRASH calls to determine which assumptions are being violated. |
+ |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
+ (WebCore::CCLayerTreeHost::commitTo): |
+ |
+2011-09-15 Mark Hahnenberg <mhahnenberg@apple.com> |
+ |
+ Unzip initialization lists and constructors in JSCell hierarchy (7/7) |
+ https://bugs.webkit.org/show_bug.cgi?id=68122 |
+ |
+ Reviewed by Geoffrey Garen. |
+ |
+ No new tests. |
+ |
+ Completed the seventh and final level of the refactoring to add finishCreation() |
+ methods to all classes within the JSCell hierarchy with non-trivial |
+ constructor bodies. |
+ |
+ This consists of moving the finishCreation() method call into the create methods |
+ of the sixth level of the hierarchy as was done in previous patches. |
+ |
+ The special cases for JSAudioConstructor, JSOptionConstructor, and JSImageConstructor |
+ were also lumped in and given finishCreation() methods that are called in their |
+ create methods because we are at the end and want to avoid a trivial patch just |
+ for moving their finishCreation() methods from their constructor to their create method. |
+ |
+ * bindings/js/JSAudioConstructor.cpp: |
+ (WebCore::JSAudioConstructor::JSAudioConstructor): |
+ (WebCore::JSAudioConstructor::finishCreation): |
+ * bindings/js/JSAudioConstructor.h: |
+ (WebCore::JSAudioConstructor::create): |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument): |
+ * bindings/js/JSDOMWindowBase.cpp: |
+ (WebCore::JSDOMWindowBase::JSDOMWindowBase): |
+ * bindings/js/JSImageConstructor.cpp: |
+ (WebCore::JSImageConstructor::JSImageConstructor): |
+ (WebCore::JSImageConstructor::finishCreation): |
+ * bindings/js/JSImageConstructor.h: |
+ (WebCore::JSImageConstructor::create): |
+ * bindings/js/JSOptionConstructor.cpp: |
+ (WebCore::JSOptionConstructor::JSOptionConstructor): |
+ (WebCore::JSOptionConstructor::finishCreation): |
+ * bindings/js/JSOptionConstructor.h: |
+ (WebCore::JSOptionConstructor::create): |
+ * bindings/js/JSWorkerContextBase.cpp: |
+ (WebCore::JSWorkerContextBase::JSWorkerContextBase): |
+ |
+ The bindings generation script was also changed to move the finishCreation() call into the |
+ create methods for descendants of JSWorkerContextBase and JSDOMWindowBase because those base |
+ classes had it removed from their constructors. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ (GenerateHeader): |
+ * bridge/c/c_instance.cpp: |
+ (JSC::Bindings::CRuntimeMethod::create): |
+ (JSC::Bindings::CRuntimeMethod::CRuntimeMethod): |
+ * bridge/jni/jsc/JavaInstanceJSC.cpp: |
+ (JavaRuntimeMethod::create): |
+ (JavaRuntimeMethod::JavaRuntimeMethod): |
+ * bridge/objc/objc_instance.mm: |
+ (ObjCRuntimeMethod::create): |
+ (ObjCRuntimeMethod::ObjCRuntimeMethod): |
+ * bridge/qt/qt_runtime.cpp: |
+ (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): |
+ (JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod): |
+ * bridge/qt/qt_runtime.h: |
+ (JSC::Bindings::QtRuntimeMetaMethod::create): |
+ (JSC::Bindings::QtRuntimeConnectionMethod::create): |
+ |
+2011-09-15 Kentaro Hara <haraken@google.com> |
+ |
+ A single line must not be split into two pages. |
+ https://bugs.webkit.org/show_bug.cgi?id=65005 |
+ |
+ Reviewed by David Hyatt. |
+ |
+ When the document width of a page is overflowed, the last line of the page can be |
+ split into the next page. This is the regression caused by r88737. r88737 tried to |
+ fix rounding errors in rendering calculations by expanding and shrinking a page |
+ using one common method, resizePageRectsKeepingRatio(), but overlooked the case where |
+ a document width gets overflowed. |
+ |
+ This patch fixes the problem by also using resizePageRectsKeepingRatio() for the case |
+ where the document width gets overflowed. |
+ |
+ Test: printing/single-line-must-not-be-split-into-two-pages.html |
+ |
+ * WebCore.exp.in: Updated the signature of forceLayoutForPagination(). |
+ * page/Frame.cpp: |
+ (WebCore::Frame::setPrinting): Added a new argument |originalPageSize|, which is an original page size before being expanded or shrunk. |
+ * page/Frame.h: |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::forceLayoutForPagination): Uses resizePageRectsKeepingRatio() in the case where the document width gets overflowed. |
+ * page/FrameView.h: |
+ * page/PrintContext.cpp: |
+ (WebCore::PrintContext::begin): Passes an original page size to setPrinting(). |
+ (WebCore::PrintContext::end): Ditto. |
+ |
+2011-09-15 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95243 and r95246. |
+ http://trac.webkit.org/changeset/95243 |
+ http://trac.webkit.org/changeset/95246 |
+ https://bugs.webkit.org/show_bug.cgi?id=68202 |
+ |
+ Broke the Windows build (Requested by smfr on #webkit). |
+ |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * platform/graphics/ca/win/LayerChangesFlusher.cpp: |
+ (WebCore::LayerChangesFlusher::hookCallback): |
+ * platform/graphics/ca/win/PlatformCAAnimationWin.cpp: |
+ (PlatformCAAnimation::copy): |
+ * platform/win/StructuredExceptionHandlerSupressor.h: Removed. |
+ |
+2011-09-15 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Attempt to fix Windows build after r95243. |
+ |
+ * WebCore.vcproj/WebCore.vcproj: |
+ |
+2011-09-15 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Make custom scrollbar theme for use in DRT, to reduce pixel differences between platforms |
+ https://bugs.webkit.org/show_bug.cgi?id=68134 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Add new scrollbar theme, called ScrollbarThemeMock, for use in layout |
+ tests. The mock scrollbar simply draws a light gray box in the track, |
+ with a dark gray box for the thumb. |
+ |
+ Add ScrollbarThemeMock files to the build on all platforms. It isn't hooked up yet. |
+ |
+ * CMakeLists.txt: |
+ * CMakeListsEfl.txt: |
+ * CMakeListsWinCE.txt: |
+ * GNUmakefile.list.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarTheme::nativeTheme): |
+ * platform/mock/ScrollbarThemeMock.cpp: Added. |
+ (WebCore::ScrollbarThemeMock::trackRect): |
+ (WebCore::ScrollbarThemeMock::scrollbarThickness): |
+ (WebCore::ScrollbarThemeMock::paintTrackBackground): |
+ (WebCore::ScrollbarThemeMock::paintThumb): |
+ * platform/mock/ScrollbarThemeMock.h: Added. |
+ (WebCore::ScrollbarThemeMock::hasButtons): |
+ (WebCore::ScrollbarThemeMock::hasThumb): |
+ (WebCore::ScrollbarThemeMock::backButtonRect): |
+ (WebCore::ScrollbarThemeMock::forwardButtonRect): |
+ |
+2011-09-15 Beth Dakin <bdakin@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=67884 |
+ Delete button icon does not properly update when the device resolution changes |
+ dynamically |
+ -and corresponding- |
+ <rdar://problem/10104632> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ In DeleteButtonController::deviceScaleFactorChanged(), if the delete button is |
+ currently showing, hide it and re-show it, forcing it to re-create the deletion |
+ UI. |
+ * editing/DeleteButtonController.cpp: |
+ (WebCore::DeleteButtonController::deviceScaleFactorChanged): |
+ * editing/DeleteButtonController.h: |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::deviceScaleFactorChanged): |
+ * editing/Editor.h: |
+ |
+ Iterate through all of the frames and propagate the deviceScaleFactorChange() |
+ message to Editor. |
+ * page/Page.cpp: |
+ (WebCore::Page::setDeviceScaleFactor): |
+ |
+2011-09-15 Chris Marrin <cmarrin@apple.com> |
+ |
+ Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction |
+ https://bugs.webkit.org/show_bug.cgi?id=67510 |
+ |
+ Reviewed by Adam Roben. |
+ |
+ Another fix to take care of one last crash when running pause-crash.html. |
+ CACF can't deal with null valueFunctions, so avoid setting it when it doesn't |
+ exist. |
+ |
+ This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it |
+ from catching the null pointer exception generated by the pause-crash.html test |
+ before this bug was fixed. Windows was ignoring the exception, so the testcase |
+ would appear to succeed, even though it should have crashed. |
+ |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * platform/graphics/ca/win/LayerChangesFlusher.cpp: |
+ (WebCore::LayerChangesFlusher::hookCallback): |
+ * platform/graphics/ca/win/PlatformCAAnimationWin.cpp: |
+ (PlatformCAAnimation::copy): |
+ * platform\win\StructuredExceptionHandlerSupressor.h: New file to encapsulate the exception handling supression. |
+ |
+2011-09-15 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=27579 |
+ |
+ Make sure that the border shorthand also resets border-image. |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ Added fast/borders/border-image-reset-by-border-shorthand.html. |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseValue): |
+ |
+2011-09-15 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=50072 |
+ |
+ Make overflow clipping to border-radius work across layers. This patch makes painting |
+ work but does not attempt to fix hit testing. It also doesn't work when a composited |
+ layer is clipped by a non-composited ancestor. |
+ |
+ Add a new ClipRect class (used by ClipRects and RenderLayer) that is basically just tracking |
+ a rect and a border radius taint. At the time we set a clip, if the rectangle is listed |
+ as also being clipped by a radius, then we walk up the layer tree and push those inner border |
+ rounded rect clips for any overflow areas in the containing block chain. |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ Added new tests in fast/clip. |
+ |
+ * rendering/RenderBox.cpp: |
+ (WebCore::RenderBox::pushContentsClip): |
+ * rendering/RenderLayer.cpp: |
+ (WebCore::inContainingBlockChain): |
+ (WebCore::RenderLayer::clipToRect): |
+ (WebCore::RenderLayer::restoreClip): |
+ (WebCore::RenderLayer::paintLayer): |
+ (WebCore::RenderLayer::hitTestLayer): |
+ (WebCore::RenderLayer::calculateClipRects): |
+ (WebCore::RenderLayer::backgroundClipRect): |
+ (WebCore::RenderLayer::calculateRects): |
+ (WebCore::RenderLayer::childrenClipRect): |
+ (WebCore::RenderLayer::selfClipRect): |
+ * rendering/RenderLayer.h: |
+ (WebCore::ClipRect::ClipRect): |
+ (WebCore::ClipRect::rect): |
+ (WebCore::ClipRect::setRect): |
+ (WebCore::ClipRect::hasRadius): |
+ (WebCore::ClipRect::setHasRadius): |
+ (WebCore::ClipRect::operator==): |
+ (WebCore::ClipRect::intersect): |
+ (WebCore::ClipRect::move): |
+ (WebCore::ClipRect::isEmpty): |
+ (WebCore::ClipRect::intersects): |
+ (WebCore::intersection): |
+ (WebCore::ClipRects::overflowClipRect): |
+ (WebCore::ClipRects::setOverflowClipRect): |
+ (WebCore::ClipRects::fixedClipRect): |
+ (WebCore::ClipRects::setFixedClipRect): |
+ (WebCore::ClipRects::posClipRect): |
+ (WebCore::ClipRects::setPosClipRect): |
+ * rendering/RenderLayerBacking.cpp: |
+ (WebCore::RenderLayerBacking::updateCompositedBounds): |
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): |
+ (WebCore::RenderLayerBacking::paintIntoLayer): |
+ * rendering/RenderLayerCompositor.cpp: |
+ (WebCore::RenderLayerCompositor::addToOverlapMap): |
+ (WebCore::RenderLayerCompositor::clippedByAncestor): |
+ * rendering/RenderTreeAsText.cpp: |
+ (WebCore::writeLayers): |
+ |
+2011-09-15 Julien Chaffraix <jchaffraix@webkit.org> |
+ |
+ Crash in RenderBox::paintMaskImages due to a mask without an associated image |
+ https://bugs.webkit.org/show_bug.cgi?id=50151 |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ Test: fast/css/empty-webkit-mask-crash.html |
+ |
+ The crash stems from the fact that FillLayer::hasImage would walk over the linked list |
+ of FillLayers and return true if one had an image. This means that hasImage() is true |
+ does not mean that image() is non-NULL on all FillLayers. |
+ |
+ * rendering/RenderBox.cpp: |
+ (WebCore::RenderBox::paintMaskImages): Simplify the logic by doing the hasImage() check up-front |
+ and properly check image() for each FillLayers. This has the nice benefit of changing the complexity |
+ from O(n^2) to O(n), which was what the code expected anyway. |
+ |
+2011-09-15 Eric Seidel <eric@webkit.org> |
+ |
+ Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default |
+ https://bugs.webkit.org/show_bug.cgi?id=68182 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ * Configurations/FeatureDefines.xcconfig: |
+ * DerivedSources.make: |
+ * GNUmakefile.am: |
+ * features.pri: |
+ * loader/cache/CachedImage.cpp: |
+ (WebCore::CachedImage::createImage): |
+ |
+2011-09-15 Andy Estes <aestes@apple.com> |
+ |
+ Having an empty listener to beforeload events changes the behavior of other scripts |
+ https://bugs.webkit.org/show_bug.cgi?id=45586 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Test: fast/dom/beforeload/cached-image-before-load.html |
+ |
+ When loading a cached image after a beforeload handler has been |
+ installed on the document, ImageLoader would dispatch both the |
+ beforeload and load events asynchronously in such a way that caused |
+ load to fire first. Since a side effect of firing the beforeload event |
+ is to wire up the CachedImage to its associated RenderImage object, |
+ this work was not done by the time load fired, and scripts that queried |
+ renderer-dependent attributes of the image in an onload handler would |
+ get bogus values in return. |
+ |
+ Fix this by ensuring load fires after beforeload in the cached image case. |
+ |
+ * loader/ImageLoader.cpp: |
+ (WebCore::ImageLoader::updateFromElement): Call setClient() after |
+ dispatching beforeload, since setClient() will dispatch the load event |
+ if the image is cached. |
+ |
+2011-09-15 Anders Carlsson <andersca@apple.com> |
+ |
+ Remove ScrollView::platformContentsSize |
+ https://bugs.webkit.org/show_bug.cgi?id=68188 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Since ScrollView keeps track of the contents size in ScrollView::m_contentsSize, we never |
+ have to ask the underlying platform scroll view for contents size since it should always just |
+ be equal to m_contentsSize. |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::contentsSize): |
+ (WebCore::ScrollView::wheelEvent): |
+ * platform/ScrollView.h: |
+ * platform/mac/ScrollViewMac.mm: |
+ * platform/wx/ScrollViewWx.cpp: |
+ |
+2011-09-15 Jon Lee <jonlee@apple.com> |
+ |
+ Submitting a form with target=_blank works only once |
+ https://bugs.webkit.org/show_bug.cgi?id=28633 |
+ <rdar://problem/7357787> |
+ |
+ Reviewed by Andy Estes. |
+ |
+ Test: fast/forms/submit-to-blank-multiple-times.html |
+ |
+ The call to reset the multiple form submission bool is pushed down from the mouseDown handler to |
+ handleMousePressEvent(), to include WK2 coverage, similar to keyEvent. |
+ |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::handleMousePressEvent): |
+ (WebCore::EventHandler::keyEvent): clarified old FIXME comment. Both key events and mouse events |
+ may submit a form multiple times, but the call to reset the handler should probably be in another |
+ abstraction layer. |
+ * page/mac/EventHandlerMac.mm: |
+ (WebCore::EventHandler::mouseDown): |
+ |
+2011-09-15 Peter Rybin <peter.rybin@gmail.com> |
+ |
+ XMLDocumentParserQt.cpp incorrectly converts 0-based number into 1-based number |
+ https://bugs.webkit.org/show_bug.cgi?id=63540 |
+ |
+ ZeroBasedNumber/OneBasedNumber are used in more places, inconsistency |
+ in xml parser is fixed. |
+ |
+ Reviewed by Adam Barth. |
+ |
+ * bindings/js/ScriptController.cpp: |
+ (WebCore::ScriptController::eventHandlerLineNumber): |
+ * dom/ScriptableDocumentParser.h: |
+ * dom/StyleElement.cpp: |
+ (WebCore::StyleElement::StyleElement): |
+ * dom/ViewportArguments.cpp: |
+ (WebCore::parserLineNumber): |
+ * html/parser/HTMLDocumentParser.cpp: |
+ (WebCore::HTMLDocumentParser::lineNumber): |
+ * html/parser/HTMLDocumentParser.h: |
+ * inspector/InspectorResourceAgent.cpp: |
+ (WebCore::InspectorResourceAgent::buildInitiatorObject): |
+ * svg/SVGDocumentExtensions.cpp: |
+ (WebCore::parserLineNumber): |
+ * xml/parser/NewXMLDocumentParser.cpp: |
+ (WebCore::NewXMLDocumentParser::lineNumber): |
+ * xml/parser/NewXMLDocumentParser.h: |
+ * xml/parser/XMLDocumentParser.cpp: |
+ (WebCore::XMLDocumentParser::pushCurrentNode): |
+ * xml/parser/XMLDocumentParser.h: |
+ * xml/parser/XMLDocumentParserLibxml2.cpp: |
+ (WebCore::PendingCallbacks::appendErrorCallback): |
+ (WebCore::XMLDocumentParser::doWrite): |
+ (WebCore::XMLDocumentParser::startElementNs): |
+ (WebCore::XMLDocumentParser::error): |
+ (WebCore::XMLDocumentParser::lineNumber): |
+ (WebCore::XMLDocumentParser::columnNumber): |
+ (WebCore::XMLDocumentParser::textPosition): |
+ * xml/parser/XMLDocumentParserQt.cpp: |
+ (WebCore::XMLDocumentParser::doWrite): |
+ (WebCore::XMLDocumentParser::doEnd): |
+ (WebCore::XMLDocumentParser::lineNumber): |
+ (WebCore::XMLDocumentParser::columnNumber): |
+ (WebCore::XMLDocumentParser::textPosition): |
+ (WebCore::XMLDocumentParser::parse): |
+ (WebCore::XMLDocumentParser::parseStartElement): |
+ |
+2011-09-15 Peter Kasting <pkasting@google.com> |
+ |
+ Fix WebCore.gypi after r95130. |
+ |
+ Unreviewed, build fix. |
+ |
+ * WebCore.gypi: |
+ |
+2011-09-15 Eric Seidel <eric@webkit.org> |
+ |
+ Remove ENABLE_SVG_ANIMATION as all major ports have it on by default |
+ https://bugs.webkit.org/show_bug.cgi?id=68022 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ * Configurations/FeatureDefines.xcconfig: |
+ * DerivedSources.make: |
+ * GNUmakefile.am: |
+ * features.pri: |
+ * page/DOMWindow.idl: |
+ * svg/svgtags.in: |
+ |
+2011-09-15 Matthew Delaney <mdelaney@apple.com> |
+ |
+ REGRESSION (Safari 5.1-r95043): Incorrect box-shadow offset |
+ https://bugs.webkit.org/show_bug.cgi?id=68041 |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Test: fast/box-shadow/no-blur-multiple-offsets.html |
+ |
+ * platform/graphics/cg/GraphicsContextCG.cpp: |
+ (WebCore::GraphicsContext::setPlatformShadow): Add hack back in for Lion if |
+ context is not accelerated. |
+ |
+2011-09-15 James Simonsen <simonjam@chromium.org> |
+ |
+ Ref protect HTMLObjectElement and HTMLEmbedElement while requesting plugins |
+ https://bugs.webkit.org/show_bug.cgi?id=68014 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: plugins/destroy-during-npp-new.html under valgrind |
+ plugins/destroy-during-npp-new-object-with-fallback-content.html under valgrind |
+ |
+ * html/HTMLEmbedElement.cpp: |
+ (WebCore::HTMLEmbedElement::updateWidget): |
+ * html/HTMLObjectElement.cpp: |
+ (WebCore::HTMLObjectElement::updateWidget): |
+ |
+2011-09-15 Sam Weinig <sam@webkit.org> |
+ |
+ Experiment with removing ability to call a collection (except document.all) |
+ https://bugs.webkit.org/show_bug.cgi?id=67579 |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ At the request of the public-script-coord mailing list (specifically Brendan Eich, see |
+ http://lists.w3.org/Archives/Public/public-script-coord/2011JulSep/0360.html), this |
+ patch removes the ability to call a collection (either a NodeList or HTMLCollection, |
+ but not an HTMLAllCollection) as function, a syntax that we adopted to emulate IE. |
+ It is being landed to find out if there are any sites relying on this behavior of WebKit, |
+ or, if it is only used in IE only paths. If we find sites are breaking, it should be rolled |
+ out and we should inform the public-script-coord mailing list. |
+ |
+ * bindings/js/JSHTMLAllCollectionCustom.cpp: |
+ Update comment. |
+ |
+ * bindings/js/JSHTMLCollectionCustom.cpp: |
+ * bindings/js/JSNodeListCustom.cpp: |
+ Remove custom call code. |
+ |
+ * bindings/scripts/CodeGeneratorV8.pm: |
+ Add support for V8CustomCall. |
+ |
+ * dom/NodeList.idl: |
+ * html/HTMLCollection.idl: |
+ Remove CustomCall. |
+ |
+2011-09-15 Andreas Kling <kling@webkit.org> |
+ |
+ CanvasRenderingContext2D::State copy ctor should use initializer list. |
+ https://bugs.webkit.org/show_bug.cgi?id=68152 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::State::State): |
+ |
+2011-09-15 Andreas Kling <kling@webkit.org> |
+ |
+ Don't bother calculating dirty rect for accelerated 2D canvases. |
+ https://bugs.webkit.org/show_bug.cgi?id=68158 |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ For accelerated CanvasRenderingContext2D, didDraw() simply calls out |
+ to RenderLayer::contentChanged(). Move this to the top of didDraw() |
+ so we don't waste time calculating a precise dirty rect. |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::didDraw): |
+ |
+2011-09-15 Brian Salomon <bsalomon@google.com> |
+ |
+ [Skia/Chrome] Cleanup unneeded code now that GrGLInterface is used to set GL ctx per GL call. |
+ https://bugs.webkit.org/show_bug.cgi?id=68096 |
+ |
+ Reviewed by Stephen White. |
+ |
+ This change removes PlatformContextSkia::makeGrContextCurrent now that |
+ GrGLInterface is used to set the context on every Skia GL call. |
+ |
+ Tested by every canvas layout test. |
+ |
+ * platform/graphics/chromium/FontLinux.cpp: |
+ (WebCore::Font::drawGlyphs): |
+ * platform/graphics/skia/FontSkia.cpp: |
+ (WebCore::Font::drawGlyphs): |
+ * platform/graphics/skia/GraphicsContextSkia.cpp: |
+ (WebCore::GraphicsContext::clearRect): |
+ (WebCore::GraphicsContext::clip): |
+ (WebCore::GraphicsContext::drawConvexPolygon): |
+ (WebCore::GraphicsContext::drawEllipse): |
+ (WebCore::GraphicsContext::drawFocusRing): |
+ (WebCore::GraphicsContext::drawLine): |
+ (WebCore::GraphicsContext::drawLineForTextChecking): |
+ (WebCore::GraphicsContext::drawLineForText): |
+ (WebCore::GraphicsContext::drawRect): |
+ (WebCore::GraphicsContext::fillPath): |
+ (WebCore::GraphicsContext::fillRect): |
+ (WebCore::GraphicsContext::fillRoundedRect): |
+ (WebCore::GraphicsContext::strokeArc): |
+ (WebCore::GraphicsContext::strokePath): |
+ (WebCore::GraphicsContext::strokeRect): |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::ImageBuffer::ImageBuffer): |
+ (WebCore::ImageBuffer::~ImageBuffer): |
+ (WebCore::ImageBuffer::copyImage): |
+ (WebCore::ImageBuffer::draw): |
+ (WebCore::ImageBuffer::drawPattern): |
+ (WebCore::ImageBuffer::getUnmultipliedImageData): |
+ (WebCore::ImageBuffer::getPremultipliedImageData): |
+ (WebCore::ImageBuffer::putUnmultipliedImageData): |
+ (WebCore::ImageBuffer::putPremultipliedImageData): |
+ (WebCore::ImageBuffer::toDataURL): |
+ * platform/graphics/skia/ImageSkia.cpp: |
+ (WebCore::BitmapImage::draw): |
+ (WebCore::BitmapImageSingleFrameSkia::draw): |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::PlatformContextSkia::clipPathAntiAliased): |
+ (WebCore::PlatformContextSkia::setGraphicsContext3D): |
+ * platform/graphics/skia/PlatformContextSkia.h: |
+ * platform/graphics/skia/SkiaFontWin.cpp: |
+ (WebCore::paintSkiaText): |
+ |
+2011-09-15 Peter Beverloo <peter@chromium.org> |
+ |
+ [Chromium] Make sure that the ARM NEON files build with -marm |
+ https://bugs.webkit.org/show_bug.cgi?id=68088 |
+ |
+ Simply adding the -marm cflag for OS=Android compiles results in it |
+ being overridden by an -mthumb cflag later in the project generating |
+ process. Therefore we should explicitly exclude -mthumb. |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ |
+2011-09-15 Keishi Hattori <keishi@webkit.org> |
+ |
+ [chromium] Build fix: Remove use of GraphicsContext::setIsAcceleratedContext |
+ |
+ r95174 introduced GraphicsContext::setIsAcceleratedContext into Skia code and caused chromium builds to fail. |
+ |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::ImageBuffer::ImageBuffer): |
+ |
+2011-09-15 Yuta Kitamura <yutak@chromium.org> |
+ |
+ ThreadableWebSocketChannelClientWrapper shouldn't have a String in it. |
+ https://bugs.webkit.org/show_bug.cgi?id=67908 |
+ |
+ Reviewed by David Levin. |
+ |
+ Replace a String member variable in ThreadableWebSocketChannelClientWrapper with Vector<UChar>. |
+ |
+ ThreadableWebSocketChannelClientWrapper is derived from ThreadSafeRefCounted. It may be |
+ destroyed on different threads, which will affect String's refcounting. Therefore, classes |
+ derived from ThreadSafeRefCounted must not have a String member variable. |
+ |
+ No change in functionality, thus no new tests. WebSocket worker tests |
+ (tests under http/tests/websocket/tests/{hixie76,hybi}/workers/) should keep passing. |
+ |
+ * websockets/ThreadableWebSocketChannelClientWrapper.cpp: |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol): |
+ Create a String from Vector<UChar>. Note that String constructor taking an empty vector returns |
+ a null string, not an empty string. We want an empty string in that case, so I had to add |
+ special-case handling for an empty vector. |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol): |
+ Copy the content of the given String into Vector. |
+ * websockets/ThreadableWebSocketChannelClientWrapper.h: |
+ |
+2011-09-14 Matthew Delaney <mdelaney@apple.com> |
+ |
+ Use isAcceleratedContext() on the GraphicsContext instead of flags in ImageBuffer |
+ https://bugs.webkit.org/show_bug.cgi?id=68137 |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ No new tests. No change in behavior. |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::isAccelerated): Have all just query the context directly. |
+ (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere): just use isAccelerated directly |
+ * platform/graphics/ImageBuffer.h: |
+ * platform/graphics/cg/ImageBufferCG.cpp: |
+ (WebCore::ImageBuffer::ImageBuffer): Set isAcceleratedContext on the GraphicsContext instead of carrying the |
+ bit around on the ImageBuffer itself. |
+ (WebCore::ImageBuffer::copyNativeImage): Update the check. Same for all below... |
+ (WebCore::ImageBuffer::drawPattern): |
+ (WebCore::ImageBuffer::getUnmultipliedImageData): |
+ (WebCore::ImageBuffer::getPremultipliedImageData): |
+ (WebCore::ImageBuffer::putUnmultipliedImageData): |
+ (WebCore::ImageBuffer::putPremultipliedImageData): |
+ * platform/graphics/skia/ImageBufferSkia.cpp: Set isAcceleratedContext on the GraphicsContext instead of carrying the |
+ bit around on the ImageBuffer itself. |
+ (WebCore::ImageBuffer::ImageBuffer): Remove m_acceleratesRendering flag and getter. |
+ |
+2011-09-14 Jeffrey Pfau <jeffrey@endrift.com> |
+ |
+ libxml2 fragment parser loses prefix namespaces |
+ https://bugs.webkit.org/show_bug.cgi?id=66423 |
+ |
+ This makes the loop over the elements outside of the context actually update the element it's processing. |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Test: fast/parser/innerhtml-with-prefixed-elements.xhtml |
+ |
+ * xml/parser/XMLDocumentParserLibxml2.cpp: |
+ (WebCore::XMLDocumentParser::XMLDocumentParser): |
+ |
+2011-09-14 Nate Chapin <japhet@chromium.org> |
+ |
+ [V8] Null-check the v8::Context in |
+ V8DOMWindowShell:namedItemAdded() before using it. |
+ Also, add some logging to figure out how we're getting |
+ into this bad state. |
+ https://bugs.webkit.org/show_bug.cgi?id=68099 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests, no known repro. |
+ |
+ * bindings/v8/V8DOMWindowShell.cpp: |
+ (WebCore::V8DOMWindowShell::namedItemAdded): |
+ |
+2011-09-14 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Replace ENABLE_XHR_RESPONSE_BLOB preprocessor statements in IDL files with Conditional attribute |
+ https://bugs.webkit.org/show_bug.cgi?id=64960 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ * xml/XMLHttpRequest.idl: |
+ |
+2011-09-14 Alexei Svitkine <asvitkine@chromium.org> |
+ |
+ Chromium: Add a layer for rubber-band overhang painting to the hardware path. |
+ https://bugs.webkit.org/show_bug.cgi?id=66969 |
+ |
+ Also, add layout tests for rubber-band overhang drawing for compositing path. |
+ |
+ Reviewed by James Robinson. |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::layerForOverhangAreas): |
+ * page/FrameView.h: |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::scrollContents): |
+ (WebCore::ScrollView::wheelEvent): |
+ * platform/ScrollView.h: |
+ * platform/ScrollableArea.h: |
+ (WebCore::ScrollableArea::layerForOverhangAreas): |
+ * rendering/RenderLayerCompositor.cpp: |
+ (WebCore::RenderLayerCompositor::frameViewDidChangeSize): |
+ (WebCore::RenderLayerCompositor::paintContents): |
+ (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): |
+ (WebCore::RenderLayerCompositor::destroyRootLayer): |
+ * rendering/RenderLayerCompositor.h: |
+ (WebCore::RenderLayerCompositor::layerForOverhangAreas): |
+ |
+2011-09-14 Antoine Labour <piman@chromium.org> |
+ |
+ Remove the dependency on GraphicsLayer from CCLayerTreeHost. |
+ Move root layer management into the NonCompositedContentHost. |
+ Have WebViewImpl create a NonCompositedContentHost explicitly. |
+ https://bugs.webkit.org/show_bug.cgi?id=67883 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Covered by compositing/ layout tests. |
+ |
+ * platform/graphics/chromium/NonCompositedContentHost.cpp: |
+ (WebCore::NonCompositedContentHost::setRootLayer): |
+ (WebCore::NonCompositedContentHost::setViewport): |
+ (WebCore::NonCompositedContentHost::setVisible): |
+ (WebCore::NonCompositedContentHost::clearRenderSurfacesRecursive): |
+ (WebCore::NonCompositedContentHost::invalidateRect): |
+ * platform/graphics/chromium/NonCompositedContentHost.h: |
+ (WebCore::NonCompositedContentHost::topLevelRootLayer): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
+ (WebCore::CCLayerTreeHost::create): |
+ (WebCore::CCLayerTreeHost::CCLayerTreeHost): |
+ (WebCore::CCLayerTreeHost::initialize): |
+ (WebCore::CCLayerTreeHost::commitTo): |
+ (WebCore::CCLayerTreeHost::didRecreateGraphicsContext): |
+ (WebCore::CCLayerTreeHost::setViewport): |
+ (WebCore::CCLayerTreeHost::setVisible): |
+ (WebCore::CCLayerTreeHost::updateLayers): |
+ (WebCore::CCLayerTreeHost::paintLayerContents): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
+ (WebCore::CCLayerTreeHost::rootLayer): |
+ |
+2011-09-14 Henrik Grunell <grunell@google.com> |
+ |
+ MediaStream API: Change PeerConnection constructor name to webkitPeerConnection |
+ https://bugs.webkit.org/show_bug.cgi?id=67843 |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ Tests for the MediaStream API will be provided by the bug 56587, pending enough landed code. |
+ |
+ * bindings/generic/RuntimeEnabledFeatures.h: |
+ (WebCore::RuntimeEnabledFeatures::webkitPeerConnectionEnabled): |
+ * page/DOMWindow.idl: |
+ |
+2011-09-14 John Bauman <jbauman@chromium.org> |
+ |
+ Make sure to GC decoded images that are only used with WebGL |
+ https://bugs.webkit.org/show_bug.cgi?id=67899 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Tell CachedImage that the WebGL image was drawn so WebGL-only |
+ content will have decoded images collected. |
+ |
+ * platform/graphics/GraphicsContext3D.cpp: |
+ (WebCore::GraphicsContext3D::extractImageData): |
+ |
+2011-09-14 Antoine Labour <piman@chromium.org> |
+ |
+ Added a pure virtual class CCLayerDelegate which helps to isolate |
+ the chromium compositor from the rest of WebCore, and aids unit |
+ testing by being easily mockable. The compositor layers no longer |
+ directly see instances of GraphicsLayerChromium, instead they use |
+ this interface. |
+ https://bugs.webkit.org/show_bug.cgi?id=67750 |
+ |
+ Reviewed by James Robinson. |
+ |
+ No new tests: changes already covered by existing compositing layout |
+ tests. |
+ |
+ * platform/graphics/chromium/CanvasLayerChromium.cpp: |
+ (WebCore::CanvasLayerChromium::CanvasLayerChromium): |
+ * platform/graphics/chromium/CanvasLayerChromium.h: |
+ * platform/graphics/chromium/ContentLayerChromium.cpp: |
+ (WebCore::ContentLayerPainter::create): |
+ (WebCore::ContentLayerPainter::paint): |
+ (WebCore::ContentLayerPainter::ContentLayerPainter): |
+ (WebCore::ContentLayerChromium::create): |
+ (WebCore::ContentLayerChromium::ContentLayerChromium): |
+ (WebCore::ContentLayerChromium::drawsContent): |
+ * platform/graphics/chromium/ContentLayerChromium.h: |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ (WebCore::GraphicsLayerChromium::getDrawsContent): |
+ (WebCore::GraphicsLayerChromium::getPreserves3D): |
+ (WebCore::GraphicsLayerChromium::paintingGoesToWindow): |
+ (WebCore::GraphicsLayerChromium::doPaintGraphicsLayerContents): |
+ (WebCore::GraphicsLayerChromium::notifySyncRequired): |
+ * platform/graphics/chromium/GraphicsLayerChromium.h: |
+ * platform/graphics/chromium/ImageLayerChromium.cpp: |
+ (WebCore::ImageLayerChromium::create): |
+ (WebCore::ImageLayerChromium::ImageLayerChromium): |
+ * platform/graphics/chromium/ImageLayerChromium.h: |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::create): |
+ (WebCore::LayerChromium::LayerChromium): |
+ * platform/graphics/chromium/LayerChromium.h: |
+ (WebCore::CCLayerDelegate::~CCLayerDelegate): |
+ (WebCore::LayerChromium::preserves3D): |
+ (WebCore::LayerChromium::setOwner): |
+ * platform/graphics/chromium/PluginLayerChromium.cpp: |
+ (WebCore::PluginLayerChromium::create): |
+ (WebCore::PluginLayerChromium::PluginLayerChromium): |
+ * platform/graphics/chromium/PluginLayerChromium.h: |
+ * platform/graphics/chromium/TiledLayerChromium.cpp: |
+ (WebCore::TiledLayerChromium::TiledLayerChromium): |
+ * platform/graphics/chromium/TiledLayerChromium.h: |
+ * platform/graphics/chromium/VideoLayerChromium.cpp: |
+ (WebCore::VideoLayerChromium::create): |
+ (WebCore::VideoLayerChromium::VideoLayerChromium): |
+ (WebCore::VideoLayerChromium::updateCompositorResources): |
+ * platform/graphics/chromium/VideoLayerChromium.h: |
+ * platform/graphics/chromium/WebGLLayerChromium.cpp: |
+ (WebCore::WebGLLayerChromium::create): |
+ (WebCore::WebGLLayerChromium::WebGLLayerChromium): |
+ * platform/graphics/chromium/WebGLLayerChromium.h: |
+ |
+2011-09-14 Anders Carlsson <andersca@apple.com> |
+ |
+ Try to fix GTK+ build. |
+ |
+ * GNUmakefile.list.am: |
+ |
+2011-09-14 James Robinson <jamesr@chromium.org> |
+ |
+ [chromium] LayerRendererChromium shouldn't be RefCounted |
+ https://bugs.webkit.org/show_bug.cgi?id=68121 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ LayerRendererChromium is owned exclusively by CCLayerTreeHostImpl, so there's no reason to have it be |
+ refcounted. Making it an OwnPtr<> makes the lifecycle for these objects much cleaner and reduces the chance of |
+ introducing accidental reference cycles. This also removes the LayerRendererChromium pointers from CCLayerImpls |
+ since it only needed at draw time. |
+ |
+ Covered by compositing/ tests. |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::create): |
+ (WebCore::LayerRendererChromium::drawLayers): |
+ (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay): |
+ (WebCore::LayerRendererChromium::useRenderSurface): |
+ (WebCore::LayerRendererChromium::drawLayer): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: |
+ (WebCore::CCCanvasLayerImpl::draw): |
+ * platform/graphics/chromium/cc/CCCanvasLayerImpl.h: |
+ * platform/graphics/chromium/cc/CCLayerImpl.cpp: |
+ (WebCore::CCLayerImpl::CCLayerImpl): |
+ (WebCore::CCLayerImpl::draw): |
+ (WebCore::CCLayerImpl::bindContentsTexture): |
+ (WebCore::CCLayerImpl::drawDebugBorder): |
+ * platform/graphics/chromium/cc/CCLayerImpl.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: |
+ (WebCore::CCLayerTreeHostImpl::initializeLayerRenderer): |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: |
+ * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: |
+ (WebCore::CCPluginLayerImpl::draw): |
+ * platform/graphics/chromium/cc/CCPluginLayerImpl.h: |
+ * platform/graphics/chromium/cc/CCRenderSurface.cpp: |
+ (WebCore::CCRenderSurface::cleanupResources): |
+ (WebCore::CCRenderSurface::prepareContentsTexture): |
+ (WebCore::CCRenderSurface::draw): |
+ (WebCore::CCRenderSurface::drawLayer): |
+ (WebCore::CCRenderSurface::drawSurface): |
+ * platform/graphics/chromium/cc/CCRenderSurface.h: |
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: |
+ (WebCore::CCTiledLayerImpl::bindContentsTexture): |
+ (WebCore::CCTiledLayerImpl::draw): |
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.h: |
+ * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: |
+ (WebCore::CCVideoLayerImpl::draw): |
+ (WebCore::CCVideoLayerImpl::drawYUV): |
+ (WebCore::CCVideoLayerImpl::drawRGBA): |
+ * platform/graphics/chromium/cc/CCVideoLayerImpl.h: |
+ |
+2011-09-14 Anders Carlsson <andersca@apple.com> |
+ |
+ Get rid of WebCoreViewFactory and its WebViewFactory subclass |
+ https://bugs.webkit.org/show_bug.cgi?id=68124 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ * WebCore.exp.in: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * editing/mac/FrameSelectionMac.mm: |
+ * page/mac/FrameMac.mm: |
+ * page/mac/WebCoreViewFactory.h: Removed. |
+ * page/mac/WebCoreViewFactory.m: Removed. |
+ |
+2011-09-14 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=52736 |
+ |
+ Tiles were not being properly centered within border image sides for the "repeat" |
+ keyword. This patch fixes the buggy math behind the pattern tiling to actually get |
+ the initial phases correct. |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Added new tests in fast/borders and updated broken existing tests. |
+ |
+ * platform/graphics/Image.cpp: |
+ (WebCore::Image::drawTiled): |
+ |
+2011-09-14 Anders Carlsson <andersca@apple.com> |
+ |
+ Remove DocTypeStrings.gperf |
+ https://bugs.webkit.org/show_bug.cgi?id=68119 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ * CMakeLists.txt: |
+ * CodeGenerators.pri: |
+ * DerivedSources.make: |
+ * GNUmakefile.am: |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * html/DocTypeStrings.gperf: Removed. |
+ * make-hash-tools.pl: |
+ * platform/HashTools.h: |
+ |
+2011-09-14 Chris Rogers <crogers@google.com> |
+ |
+ Address lifetime issues in OfflineAudioDestinationNode (take 2) |
+ https://bugs.webkit.org/show_bug.cgi?id=68111 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ No new tests. This fixes existing layout tests. |
+ |
+ * webaudio/OfflineAudioDestinationNode.cpp: |
+ (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode): |
+ (WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode): |
+ (WebCore::OfflineAudioDestinationNode::startRendering): |
+ (WebCore::OfflineAudioDestinationNode::render): |
+ |
+2011-09-14 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=68103 |
+ |
+ Centered portions of border images don't render correctly. Make the tile scale factor have to be |
+ explicitly passed in and modify paintNinePieceImage to compute it for all sides. The attempts to |
+ implicitly compute the scale for the pattern based off the source and destination rects just don't |
+ work, since the center image rects don't provide the right information to be able to infer the |
+ scale factor. |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Reset all the existing fast/borders pixel results to Lion for these changes. |
+ |
+ * platform/graphics/GraphicsContext.cpp: |
+ (WebCore::GraphicsContext::drawTiledImage): |
+ * platform/graphics/GraphicsContext.h: |
+ * platform/graphics/Image.cpp: |
+ (WebCore::Image::drawTiled): |
+ * platform/graphics/Image.h: |
+ * rendering/RenderBoxModelObject.cpp: |
+ (WebCore::RenderBoxModelObject::paintNinePieceImage): |
+ |
+2011-09-14 Anders Carlsson <andersca@apple.com> |
+ |
+ Get rid of ResourceHandle::bufferedData() |
+ https://bugs.webkit.org/show_bug.cgi?id=68112 |
+ |
+ Reviewed by David Hyatt. |
+ |
+ ResourceHandle::bufferedData() was only implemented on Mac, and the support in the underlying |
+ NSURLConnection class hasn't been there for several OS releases. |
+ |
+ * loader/ResourceLoader.cpp: |
+ (WebCore::ResourceLoader::resourceData): |
+ (WebCore::ResourceLoader::addData): |
+ * platform/network/ResourceHandle.h: |
+ * platform/network/cf/ResourceHandleCFNet.cpp: |
+ * platform/network/curl/ResourceHandleCurl.cpp: |
+ * platform/network/mac/ResourceHandleMac.mm: |
+ * platform/network/qt/ResourceHandleQt.cpp: |
+ * platform/network/soup/ResourceHandleSoup.cpp: |
+ * platform/network/win/ResourceHandleWin.cpp: |
+ |
+2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com> |
+ |
+ REGRESSION: r95108 broke Qt Linux tests |
+ https://bugs.webkit.org/show_bug.cgi?id=68104 |
+ |
+ Reviewed by Csaba Osztrogonác. |
+ |
+ No new tests. |
+ |
+ Build fix for Qt tests broken in r95108. |
+ |
+ * bridge/qt/qt_runtime.cpp: |
+ (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): |
+ (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): |
+ (JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod): |
+ * bridge/qt/qt_runtime.h: |
+ |
+2011-09-14 James Robinson <jamesr@chromium.org> |
+ |
+ [skia] fast/canvas/setWidthResetAfterForcedRender is flaky |
+ https://bugs.webkit.org/show_bug.cgi?id=67955 |
+ |
+ Reviewed by Stephen White. |
+ |
+ When destroying an ImageBuffer due to a canvas resize, we weren't clearing the texture ID on the layer, |
+ resulting in future compositor draw calls binding an invalid texture. This results in the test failing and |
+ possibly drawing from a bad texture. |
+ |
+ Covered by fast/canvas/setWidthResetAfterForcedRender.html in the GPU configuration. |
+ |
+ * platform/graphics/chromium/Canvas2DLayerChromium.cpp: |
+ (WebCore::Canvas2DLayerChromium::drawsContent) |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::ImageBuffer::~ImageBuffer): |
+ |
+2011-09-14 Eric Seidel <eric@webkit.org> |
+ |
+ Remove ENABLE_SVG_USE as <use> is required by HTML5 |
+ https://bugs.webkit.org/show_bug.cgi?id=68019 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ I missed a couple uses of SVG_USE in my previous patch. |
+ |
+ * dom/DOMImplementation.cpp: |
+ (WebCore::isSVG10Feature): |
+ (WebCore::isSVG11Feature): |
+ * svg/SVGUseElement.cpp: |
+ (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements): |
+ * svg/SVGUseElement.h: |
+ |
+2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com> |
+ |
+ Unzip initialization lists and constructors in JSCell hierarchy (6/7) |
+ https://bugs.webkit.org/show_bug.cgi?id=67692 |
+ |
+ Reviewed by Geoffrey Garen. |
+ |
+ No new tests. |
+ |
+ Completed the sixth level of the refactoring to add finishCreation() |
+ methods to all classes within the JSCell hierarchy with non-trivial |
+ constructor bodies. |
+ |
+ This primarily consists of pushing the calls to finishCreation() down |
+ into the constructors of the subclasses of the fifth level of the hierarchy |
+ as well as pulling the finishCreation() calls out into the class's corresponding |
+ create() method if it has one. Doing both simultaneously allows us to |
+ maintain the invariant that the finishCreation() method chain is called exactly |
+ once during the creation of an object, since calling it any other number of |
+ times (0, 2, or more) will cause an assertion failure. |
+ |
+ * WebCore.exp.in: |
+ * bindings/js/JSDOMBinding.h: |
+ (WebCore::DOMConstructorObject::DOMConstructorObject): |
+ (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument): |
+ (WebCore::DOMConstructorWithDocument::finishCreation): |
+ * bindings/js/JSDOMGlobalObject.cpp: |
+ (WebCore::JSDOMGlobalObject::JSDOMGlobalObject): |
+ * bindings/js/JSDOMGlobalObject.h: |
+ * bindings/js/JSDOMWindowBase.cpp: |
+ (WebCore::JSDOMWindowBase::JSDOMWindowBase): |
+ (WebCore::JSDOMWindowBase::finishCreation): |
+ * bindings/js/JSDOMWindowBase.h: |
+ * bindings/js/JSWorkerContextBase.cpp: |
+ (WebCore::JSWorkerContextBase::JSWorkerContextBase): |
+ (WebCore::JSWorkerContextBase::finishCreation): |
+ * bindings/js/JSWorkerContextBase.h: |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ |
+ Added a finishCreation declaration and Moved the finishCreation call into the |
+ create method for all classes except for subclasses of JSWorkerContextBase and |
+ JSDOMWindowBase because those classes are on the next level, and it's easier |
+ to do all of these classes in one fell swoop rather than level by level. |
+ (GenerateHeader): |
+ Added the implementation of the finishCreation method for the classes described above. |
+ (GenerateImplementation): |
+ Also added the finishCreation calls to the autogenerated DOM constructor classes. |
+ (GenerateConstructorDeclaration): |
+ (GenerateConstructorDefinition): |
+ |
+ * bindings/scripts/test/JS/JSTestInterface.cpp: |
+ (WebCore::JSTestInterfaceConstructor::create): |
+ (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor): |
+ (WebCore::JSTestInterfaceConstructor::finishCreation): |
+ (WebCore::JSTestInterface::JSTestInterface): |
+ (WebCore::JSTestInterface::finishCreation): |
+ * bindings/scripts/test/JS/JSTestInterface.h: |
+ (WebCore::JSTestInterface::create): |
+ (WebCore::JSTestInterfacePrototype::create): |
+ (WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype): |
+ * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: |
+ (WebCore::JSTestMediaQueryListListenerConstructor::create): |
+ (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor): |
+ (WebCore::JSTestMediaQueryListListenerConstructor::finishCreation): |
+ (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): |
+ (WebCore::JSTestMediaQueryListListener::finishCreation): |
+ * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: |
+ (WebCore::JSTestMediaQueryListListener::create): |
+ (WebCore::JSTestMediaQueryListListenerPrototype::create): |
+ (WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype): |
+ * bindings/scripts/test/JS/JSTestObj.cpp: |
+ (WebCore::JSTestObjConstructor::create): |
+ (WebCore::JSTestObjConstructor::JSTestObjConstructor): |
+ (WebCore::JSTestObjConstructor::finishCreation): |
+ (WebCore::JSTestObj::JSTestObj): |
+ (WebCore::JSTestObj::finishCreation): |
+ * bindings/scripts/test/JS/JSTestObj.h: |
+ (WebCore::JSTestObj::create): |
+ (WebCore::JSTestObjPrototype::create): |
+ (WebCore::JSTestObjPrototype::JSTestObjPrototype): |
+ * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: |
+ (WebCore::JSTestSerializedScriptValueInterfaceConstructor::create): |
+ (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor): |
+ (WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation): |
+ (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface): |
+ (WebCore::JSTestSerializedScriptValueInterface::finishCreation): |
+ * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: |
+ (WebCore::JSTestSerializedScriptValueInterface::create): |
+ (WebCore::JSTestSerializedScriptValueInterfacePrototype::create): |
+ (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype): |
+ * bridge/c/CRuntimeObject.cpp: |
+ (JSC::Bindings::CRuntimeObject::CRuntimeObject): |
+ * bridge/c/CRuntimeObject.h: |
+ (JSC::Bindings::CRuntimeObject::create): |
+ * bridge/c/c_instance.cpp: |
+ (JSC::Bindings::CRuntimeMethod::CRuntimeMethod): |
+ (JSC::Bindings::CRuntimeMethod::finishCreation): |
+ * bridge/jni/jsc/JavaInstanceJSC.cpp: |
+ (JavaRuntimeMethod::JavaRuntimeMethod): |
+ (JavaRuntimeMethod::finishCreation): |
+ * bridge/jni/jsc/JavaRuntimeObject.cpp: |
+ (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject): |
+ * bridge/jni/jsc/JavaRuntimeObject.h: |
+ (JSC::Bindings::JavaRuntimeObject::create): |
+ * bridge/objc/ObjCRuntimeObject.h: |
+ (JSC::Bindings::ObjCRuntimeObject::create): |
+ * bridge/objc/ObjCRuntimeObject.mm: |
+ (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject): |
+ * bridge/objc/objc_instance.mm: |
+ (ObjCRuntimeMethod::ObjCRuntimeMethod): |
+ (ObjCRuntimeMethod::finishCreation): |
+ * bridge/qt/qt_instance.cpp: |
+ (JSC::Bindings::QtRuntimeObject::create): |
+ (JSC::Bindings::QtRuntimeObject::QtRuntimeObject): |
+ * bridge/qt/qt_pixmapruntime.cpp: |
+ (JSC::Bindings::QtPixmapRuntimeObject::create): |
+ (JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject): |
+ * bridge/qt/qt_runtime.cpp: |
+ (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): |
+ (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): |
+ (JSC::Bindings::QtRuntimeMetaMethod::finishCreation): |
+ (JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod): |
+ (JSC::Bindings::QtRuntimeConnectionMethod::finishCreation): |
+ * bridge/qt/qt_runtime.h: |
+ (JSC::Bindings::QtRuntimeMetaMethod::create): |
+ * bridge/runtime_method.cpp: |
+ (JSC::RuntimeMethod::RuntimeMethod): |
+ * bridge/runtime_method.h: |
+ (JSC::RuntimeMethod::create): |
+ |
+2011-09-13 Eric Seidel <eric@webkit.org> |
+ |
+ Remove ENABLE_SVG_USE as <use> is required by HTML5 |
+ https://bugs.webkit.org/show_bug.cgi?id=68019 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ * Configurations/FeatureDefines.xcconfig: |
+ * DerivedSources.make: |
+ * GNUmakefile.am: |
+ * features.pri: |
+ |
+2011-09-14 Eric Carlson <eric.carlson@apple.com> |
+ |
+ MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary |
+ https://bugs.webkit.org/show_bug.cgi?id=68056 |
+ |
+ MediaPlayerPrivateAVFoundationObjC creates a "periodic time observer" not because it wants |
+ periodic callbacks, but because a time observer also fires whenever a seek completes. This is |
+ no longer necessary because it now uses but AVPlayerItem's |
+ -seekToTime:toleranceBefore:toleranceAfter:completionHandler to seek, so seek completions are |
+ always notified. |
+ |
+ Reviewed by Darin Adler. |
+ |
+ No new tests, code removed is tested by existing tests. |
+ |
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: |
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): |
+ |
+2011-09-14 Beth Dakin <bdakin@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=68054 |
+ Return an image scale factor as well as an Image* from CachedImage::brokenImage() |
+ |
+ Reviewed by Darin Adler. |
+ |
+ CachedImage::brokenImage() now returns a pair<Image*, float> where the float |
+ represents the image's scale factor. This is important because currently, the |
+ broken image will either be only 1x or 2x, but a deviceScaleFactor could |
+ theoretically be something different (1.5, 3, etc). So it is not safe to assume |
+ that the image's scale factor is equivalent to the deviceScaleFactor, and |
+ hardcoding 2 for now is lame. |
+ * loader/cache/CachedImage.cpp: |
+ (WebCore::CachedImage::brokenImage): |
+ (WebCore::CachedImage::image): |
+ * loader/cache/CachedImage.h: |
+ * rendering/RenderImage.cpp: |
+ (WebCore::RenderImage::imageSizeForError): |
+ (WebCore::RenderImage::paintReplaced): |
+ |
+2011-09-14 James Robinson <jamesr@chromium.org> |
+ |
+ [chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost |
+ https://bugs.webkit.org/show_bug.cgi?id=67440 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ This moves the contents TextureManager over to the CCLayerTreeHost, where it belongs, and adds in a commit path |
+ to make sure that textures are deleted even if the page is not visible. This move also removed the need for |
+ LayerRendererChromium's CCLayerTreeHost pointer, so I removed that as well. That meant moving the |
+ layerTreeAsText() logic over to the CCLayerImpl side, which is where it really belonged anyway. |
+ |
+ Covered by existing compositing/ tests and |
+ platform/chromium/compositor/lost-compositor-context-with-rendersurface.html |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::releaseRenderSurfaceTextures): |
+ (WebCore::LayerRendererChromium::drawLayers): |
+ (WebCore::LayerRendererChromium::initializeSharedObjects): |
+ (WebCore::LayerRendererChromium::cleanupSharedObjects): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ (WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes): |
+ * platform/graphics/chromium/TextureManager.cpp: |
+ (WebCore::TextureManager::highLimitBytes): |
+ (WebCore::TextureManager::reclaimLimitBytes): |
+ (WebCore::TextureManager::lowLimitBytes): |
+ * platform/graphics/chromium/TextureManager.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
+ (WebCore::CCLayerTreeHost::initialize): |
+ (WebCore::CCLayerTreeHost::~CCLayerTreeHost): |
+ (WebCore::CCLayerTreeHost::deleteContentsTextures): |
+ (WebCore::CCLayerTreeHost::commitTo): |
+ (WebCore::CCLayerTreeHost::setVisible): |
+ (WebCore::CCLayerTreeHost::contentsTextureManager): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: |
+ (WebCore::CCLayerTreeHostImpl::setVisible): |
+ * platform/graphics/chromium/cc/CCProxy.h: |
+ * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: |
+ (WebCore::CCSingleThreadProxy::setNeedsCommit): |
+ (WebCore::CCSingleThreadProxy::stop): |
+ * platform/graphics/chromium/cc/CCSingleThreadProxy.h: |
+ * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
+ (WebCore::CCThreadProxy::setNeedsCommit): |
+ (WebCore::CCThreadProxy::setNeedsCommitOnCCThread): |
+ (WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread): |
+ * platform/graphics/chromium/cc/CCThreadProxy.h: |
+ |
+2011-09-14 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=68040 |
+ |
+ Make sure border image sub-properties can be specified in any order. |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ New tests in fast/borders. |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::BorderImageParseContext::BorderImageParseContext): |
+ (WebCore::BorderImageParseContext::canAdvance): |
+ (WebCore::BorderImageParseContext::setCanAdvance): |
+ (WebCore::BorderImageParseContext::allowCommit): |
+ (WebCore::BorderImageParseContext::allowImage): |
+ (WebCore::BorderImageParseContext::allowImageSlice): |
+ (WebCore::BorderImageParseContext::allowSlash): |
+ (WebCore::BorderImageParseContext::requireWidth): |
+ (WebCore::BorderImageParseContext::requireOutset): |
+ (WebCore::BorderImageParseContext::commitImage): |
+ (WebCore::BorderImageParseContext::commitImageSlice): |
+ (WebCore::BorderImageParseContext::commitSlash): |
+ (WebCore::BorderImageParseContext::commitBorderWidth): |
+ (WebCore::BorderImageParseContext::commitBorderOutset): |
+ (WebCore::BorderImageParseContext::commitRepeat): |
+ (WebCore::CSSParser::parseBorderImage): |
+ (WebCore::CSSParser::parseBorderImageRepeat): |
+ (WebCore::CSSParser::parseBorderImageSlice): |
+ (WebCore::CSSParser::parseBorderImageQuad): |
+ * css/CSSParserValues.h: |
+ (WebCore::CSSParserValueList::previous): |
+ |
+2011-09-14 Mike Reed <reed@google.com> |
+ |
+ query SystemParametersInfo for GDI font smoothing settings |
+ https://bugs.webkit.org/show_bug.cgi?id=68080 |
+ |
+ Reviewed by Stephen White. |
+ |
+ No new tests. fixes antialiasing issues based on User settings |
+ |
+ * platform/graphics/skia/SkiaFontWin.cpp: |
+ (WebCore::getDefaultGDITextFlags): |
+ (WebCore::setupPaintForFont): |
+ |
+2011-09-13 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=68050 |
+ |
+ Regressions in some layout tests from making border/mask/reflection nine-piece-image |
+ parsing match the spec, which allows any of the pieces to be omitted and to also be |
+ specifiable in any order. |
+ |
+ When the higher level code suddenly allowed the image slices to be omitted, the fixup |
+ for legacy compatibility for reflections and masks in the parseBorderImageSlice function |
+ no longer happened because that function no longer got called. |
+ |
+ The fix is to properly set the defaults to include the "fill" keyword, so the fixup is |
+ applied to the NinePieceImages you create before you ever map anything in from the rules. |
+ |
+ This also has the side effect of fixing -webkit-max-box-image-slice to actually dump as |
+ "0 fill" instead of just "0", which is the correct initial value for this property. |
+ |
+ Reviewed by Adam Roben. |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseBorderImageSlice): |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ * rendering/style/StyleRareNonInheritedData.cpp: |
+ (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): |
+ * rendering/style/StyleReflection.h: |
+ (WebCore::StyleReflection::StyleReflection): |
+ |
+2011-09-13 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset. |
+ https://bugs.webkit.org/show_bug.cgi?id=67997 |
+ |
+ We should not instrument frameDestroyed event from within Frame's destructor |
+ since frame's m_page pointer is likely to be 0 by that time and appropriate |
+ instrumenting agent won't be found. As a result, stale frame with its id |
+ end up in the inspector. |
+ |
+ This change wipes out frame binding from the inspector upon detach rather |
+ than destroy. |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::frameDetachedImpl): |
+ * inspector/InspectorInstrumentation.h: |
+ * inspector/InspectorPageAgent.cpp: |
+ (WebCore::InspectorPageAgent::frameDetached): |
+ * inspector/InspectorPageAgent.h: |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::detachFromParent): |
+ * page/Frame.cpp: |
+ (WebCore::Frame::~Frame): |
+ (WebCore::Frame::detachFromPage): |
+ * page/Frame.h: |
+ |
+2011-09-14 Pavel Feldman <pfeldman@google.com> |
+ |
+ Not reviewed: rolling out r95089. |
+ |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::frameDestroyedImpl): |
+ (WebCore::InspectorInstrumentation::instrumentingAgentsForPage): |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::frameWindowDiscarded): |
+ (WebCore::InspectorInstrumentation::domContentLoadedEventFired): |
+ (WebCore::InspectorInstrumentation::loadEventFired): |
+ (WebCore::InspectorInstrumentation::didCommitLoad): |
+ (WebCore::InspectorInstrumentation::frameDestroyed): |
+ * inspector/InspectorPageAgent.cpp: |
+ (WebCore::InspectorPageAgent::frameDetached): |
+ (WebCore::InspectorPageAgent::frameDestroyed): |
+ * inspector/InspectorPageAgent.h: |
+ * page/Frame.cpp: |
+ (WebCore::Frame::~Frame): |
+ |
+2011-09-14 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel. |
+ https://bugs.webkit.org/show_bug.cgi?id=67986 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Test: inspector/timeline/timeline-animation-frame.html |
+ |
+ * English.lproj/localizedStrings.js: |
+ * bindings/v8/V8Proxy.cpp: |
+ (WebCore::V8Proxy::callFunction): |
+ (WebCore::V8Proxy::callFunctionWithoutFrame): |
+ (WebCore::V8Proxy::instrumentedCallFunction): |
+ * bindings/v8/V8Proxy.h: |
+ * bindings/v8/custom/V8CustomVoidCallback.cpp: |
+ (WebCore::invokeCallback): |
+ * dom/ScriptedAnimationController.cpp: |
+ (WebCore::ScriptedAnimationController::registerCallback): |
+ (WebCore::ScriptedAnimationController::cancelCallback): |
+ (WebCore::ScriptedAnimationController::serviceScriptedAnimations): |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl): |
+ (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl): |
+ (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl): |
+ (WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl): |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::willCallFunction): |
+ (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback): |
+ (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback): |
+ (WebCore::InspectorInstrumentation::willFireAnimationFrameEvent): |
+ (WebCore::InspectorInstrumentation::didFireAnimationFrameEvent): |
+ * inspector/InspectorTimelineAgent.cpp: |
+ (WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback): |
+ (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback): |
+ (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent): |
+ (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent): |
+ * inspector/InspectorTimelineAgent.h: |
+ * inspector/TimelineRecordFactory.cpp: |
+ (WebCore::TimelineRecordFactory::createAnimationFrameCallbackData): |
+ * inspector/TimelineRecordFactory.h: |
+ * inspector/front-end/TimelineAgent.js: |
+ * inspector/front-end/TimelinePanel.js: |
+ (WebInspector.TimelinePanel): |
+ (WebInspector.TimelinePanel.prototype.get _recordStyles): |
+ (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): |
+ (WebInspector.TimelinePanel.prototype._clearPanel): |
+ (WebInspector.TimelinePanel.FormattedRecord): |
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): |
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): |
+ |
+2011-09-13 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset. |
+ https://bugs.webkit.org/show_bug.cgi?id=67997 |
+ |
+ We should not instrument frameDestroyed event from within Frame's destructor |
+ since frame's m_page pointer is likely to be 0 by that time and appropriate |
+ instrumenting agent won't be found. As a result, stale frame with its id |
+ end up in the inspector. |
+ |
+ This change wipes out frame binding from the inspector upon detach rather |
+ than destroy + adds an assertion into the inspector agents lookup with 0 page. |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::frameDetachedImpl): |
+ (WebCore::InspectorInstrumentation::instrumentingAgentsForPage): |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::frameWindowDiscarded): |
+ (WebCore::InspectorInstrumentation::domContentLoadedEventFired): |
+ (WebCore::InspectorInstrumentation::loadEventFired): |
+ (WebCore::InspectorInstrumentation::frameDetached): |
+ (WebCore::InspectorInstrumentation::didCommitLoad): |
+ * inspector/InspectorPageAgent.cpp: |
+ (WebCore::InspectorPageAgent::frameDetached): |
+ * inspector/InspectorPageAgent.h: |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::detachFromParent): |
+ * page/Frame.cpp: |
+ (WebCore::Frame::~Frame): |
+ (WebCore::Frame::detachFromPage): |
+ (WebCore::Frame::transferChildFrameToNewDocument): |
+ * page/Frame.h: |
+ |
+2011-09-14 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95080. |
+ http://trac.webkit.org/changeset/95080 |
+ https://bugs.webkit.org/show_bug.cgi?id=68070 |
+ |
+ It caused some 2d.composite.uncovered tests fail (Requested by |
+ rgabor on #webkit). |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::clearCanvas): |
+ (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere): |
+ |
+2011-09-13 Pavel Feldman <pfeldman@google.com> |
+ |
+ Web Inspector: [v8] building call frame info for location-less internal script function crashes. |
+ https://bugs.webkit.org/show_bug.cgi?id=67991 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Test: inspector/debugger/debugger-pause-in-internal.html |
+ |
+ * bindings/v8/DebuggerScript.js: |
+ (): |
+ * bindings/v8/ScriptDebugServer.cpp: |
+ (WebCore::ScriptDebugServer::currentCallFrame): |
+ |
+2011-09-14 Ben Wells <benwells@chromium.org> |
+ |
+ Large canvas fills should not crash or create unnecessarily large image buffers |
+ https://bugs.webkit.org/show_bug.cgi?id=67988 |
+ |
+ When using source-in, destination-in, source-out, or destination-atop a temporary |
+ buffer is created. This buffer only needs to be big enough to cover the intersection |
+ of the path and the canvas. |
+ |
+ This change also adds some null checks for failures to create contexts or buffers. |
+ |
+ Reviewed by Stephen White. |
+ |
+ Test: fast/canvas/canvas-large-fills.html |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::clearCanvas): |
+ (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere): |
+ |
+2011-09-14 Kentaro Hara <haraken@google.com> |
+ |
+ Implement a PageTransitionEvent constructor for JSC |
+ https://bugs.webkit.org/show_bug.cgi?id=68048 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ The spec for the PageTransitionEvent constructor is here: |
+ http://www.whatwg.org/specs/web-apps/current-work/#pagetransitionevent |
+ |
+ Test: fast/events/constructors/page-transition-event-constructor.html |
+ |
+ * bindings/generic/EventConstructors.h: Added a definition for the PageTransitionEvent constructor. |
+ * bindings/js/JSEventConstructors.cpp: Added #includes for PageTransitionEvent. |
+ * dom/PageTransitionEvent.cpp: |
+ (WebCore::PageTransitionEventInit::PageTransitionEventInit): |
+ (WebCore::PageTransitionEvent::PageTransitionEvent): |
+ (WebCore::PageTransitionEvent::initPageTransitionEvent): |
+ * dom/PageTransitionEvent.h: Added a definition for PageTransitionEventInit. |
+ (WebCore::PageTransitionEvent::create): |
+ (WebCore::PageTransitionEvent::isPageTransitionEvent): |
+ (WebCore::PageTransitionEvent::persisted): |
+ * dom/PageTransitionEvent.idl: Makes PageTransitionEvent constructible. |
+ |
+2011-09-13 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95058. |
+ http://trac.webkit.org/changeset/95058 |
+ https://bugs.webkit.org/show_bug.cgi?id=68058 |
+ |
+ It made css3/calc/regression-62276.html crash (Requested by |
+ Ossy on #webkit). |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::BorderImageParseContext::BorderImageParseContext): |
+ (WebCore::BorderImageParseContext::allowBreak): |
+ (WebCore::BorderImageParseContext::allowWidth): |
+ (WebCore::BorderImageParseContext::allowOutset): |
+ (WebCore::BorderImageParseContext::allowRepeat): |
+ (WebCore::BorderImageParseContext::commitImage): |
+ (WebCore::BorderImageParseContext::commitImageSlice): |
+ (WebCore::BorderImageParseContext::commitSlash): |
+ (WebCore::BorderImageParseContext::commitBorderWidth): |
+ (WebCore::BorderImageParseContext::commitBorderOutset): |
+ (WebCore::BorderImageParseContext::commitRepeat): |
+ (WebCore::CSSParser::parseBorderImage): |
+ (WebCore::CSSParser::parseBorderImageRepeat): |
+ (WebCore::CSSParser::parseBorderImageSlice): |
+ (WebCore::CSSParser::parseBorderImageQuad): |
+ * css/CSSParserValues.h: |
+ |
+2011-09-13 Abhishek Arya <inferno@chromium.org> |
+ |
+ Crash in RenderScrollbarPart::imageChanged. |
+ https://bugs.webkit.org/show_bug.cgi?id=68009 |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ When a custom scrollbar is removed from its FrameView, its destruction |
+ can be delayed because of RefPtr maintained in EventHandler class |
+ (m_lastScrollbarUnderMouse). Upon removal, we delete all the scrollbar |
+ parts so that they don't link back to scrollbar. However, because of the |
+ delay, we can have a call to updateScrollbarPart which recreates it. |
+ When scrollbar is getting destroyed, we just check to see if there are |
+ remaining scrollbar parts and if yes, we destroy them. |
+ |
+ Test: scrollbars/scrollbar-part-created-with-no-parent-crash.html |
+ |
+ * rendering/RenderScrollbar.cpp: |
+ (WebCore::RenderScrollbar::~RenderScrollbar): |
+ |
+2011-09-13 Adam Klein <adamk@chromium.org> |
+ |
+ Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read |
+ https://bugs.webkit.org/show_bug.cgi?id=68021 |
+ |
+ Reviewed by Tony Chang. |
+ |
+ Reported by valgrind in http://crbug.com/60653. |
+ |
+ Besides fixing the uninitialized read, add support for outputting the |
+ list separator for counters() calls and the list-style name. |
+ |
+ Test: fast/css/counters/counter-cssText.html |
+ |
+ * css/CSSPrimitiveValue.cpp: |
+ (WebCore::CSSPrimitiveValue::cssText): |
+ |
+2011-09-13 Kenichi Ishibashi <bashi@chromium.org> |
+ |
+ WebFont followed tiny monospace text displays weird |
+ https://bugs.webkit.org/show_bug.cgi?id=67996 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Always call wkSetCGFontRenderingMode() in Font::drawGlyphs() so that the rendering mode is set correctly. |
+ |
+ Test: platform/mac/fast/text/webfont-after-tiny-monospace-text.html |
+ |
+ * platform/graphics/mac/FontMac.mm: |
+ (WebCore::Font::drawGlyphs): |
+ |
+2011-09-13 Tom Sepez <tsepez@chromium.org> |
+ |
+ Fix XSS auditor bypass when inline handlers contain comments. |
+ https://bugs.webkit.org/show_bug.cgi?id=27895 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Tests: http/tests/security/xssAuditor/property-escape-comment.html |
+ http/tests/security/xssAuditor/property-escape-entity.html |
+ http/tests/security/xssAuditor/property-escape-quote.html |
+ |
+ * html/parser/XSSAuditor.cpp: |
+ (WebCore::XSSAuditor::snippetForAttribute): |
+ |
+2011-09-13 Kentaro Hara <haraken@google.com> |
+ |
+ Implement a HashChangeEvent constructor for V8 |
+ https://bugs.webkit.org/show_bug.cgi?id=67969 |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ Test: fast/events/constructors/hash-change-event-constructor.html |
+ |
+ * bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor. |
+ * dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute. |
+ |
+2011-09-13 Jeremy Apthorp <jeremya@google.com> |
+ |
+ Fix crash when an iframe element is removed during a transition to |
+ fullscreen. |
+ https://bugs.webkit.org/show_bug.cgi?id=67960 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: fullscreen/full-screen-remove-ancestor-during-transition.html |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::~Document): |
+ Clear the list of elements to which we need to send a fullscreenchange |
+ event. |
+ |
+2011-09-13 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=68040 |
+ |
+ Make sure border image sub-properties can be specified in any order. |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ New tests in fast/borders. |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::BorderImageParseContext::BorderImageParseContext): |
+ (WebCore::BorderImageParseContext::canAdvance): |
+ (WebCore::BorderImageParseContext::setCanAdvance): |
+ (WebCore::BorderImageParseContext::allowCommit): |
+ (WebCore::BorderImageParseContext::allowImage): |
+ (WebCore::BorderImageParseContext::allowImageSlice): |
+ (WebCore::BorderImageParseContext::allowSlash): |
+ (WebCore::BorderImageParseContext::requireWidth): |
+ (WebCore::BorderImageParseContext::requireOutset): |
+ (WebCore::BorderImageParseContext::commitImage): |
+ (WebCore::BorderImageParseContext::commitImageSlice): |
+ (WebCore::BorderImageParseContext::commitSlash): |
+ (WebCore::BorderImageParseContext::commitBorderWidth): |
+ (WebCore::BorderImageParseContext::commitBorderOutset): |
+ (WebCore::BorderImageParseContext::commitRepeat): |
+ (WebCore::CSSParser::parseBorderImage): |
+ (WebCore::CSSParser::parseBorderImageRepeat): |
+ (WebCore::CSSParser::parseBorderImageSlice): |
+ (WebCore::CSSParser::parseBorderImageQuad): |
+ * css/CSSParserValues.h: |
+ (WebCore::CSSParserValueList::previous): |
+ |
+2011-09-13 Jeff Miller <jeffm@apple.com> |
+ |
+ WebCore::Cursor::ensurePlatformCursor() should always set a valid platform cursor on Windows |
+ https://bugs.webkit.org/show_bug.cgi?id=68043 |
+ |
+ Make sure we set a valid platform cursor in the Cursor::NoDrop case, and add a default |
+ clause that uses the arrow cursor in case another cursor type is added in the future |
+ and we forget to update ensurePlatformCursor(). |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ * platform/win/CursorWin.cpp: |
+ (WebCore::Cursor::ensurePlatformCursor): Always set a valid platform cursor. |
+ |
+2011-09-12 Jon Honeycutt <jhoneycutt@apple.com> |
+ |
+ MSAA: WebKit reports the document state as disabled |
+ https://bugs.webkit.org/show_bug.cgi?id=67974 |
+ <rdar://problem/10095898> |
+ |
+ Reviewed by Brian Weinstein. |
+ |
+ Test: platform/win/accessibility/document-enabled-state.html |
+ |
+ * accessibility/AccessibilityScrollView.h: |
+ (WebCore::AccessibilityScrollView::isEnabled): |
+ This object backs the AccessibleDocument on Windows - always return |
+ true for its enabled state. |
+ |
+2011-08-11 Cris Neckar <cdn@chromium.org> |
+ |
+ Fixes several bugs when adding CounterNodes to a tree which can cause asymetrical relationships. |
+ https://bugs.webkit.org/show_bug.cgi?id=65996 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Test: fast/css/counters/counter-reparent-table-children-crash.html |
+ |
+ * rendering/CounterNode.cpp: |
+ (WebCore::CounterNode::insertAfter): |
+ * rendering/RenderCounter.cpp: |
+ (WebCore::findPlaceForCounter): |
+ (WebCore::makeCounterNode): |
+ |
+2011-09-13 Beth Dakin <bdakin@apple.com> |
+ |
+ Adding a comment I forgot to add before. |
+ |
+ * rendering/RenderImage.cpp: |
+ (WebCore::RenderImage::imageSizeForError): |
+ |
+2011-09-13 Antti Koivisto <antti@apple.com> |
+ |
+ Move identifier filter from CSSStyleSelector to SelectorChecker |
+ https://bugs.webkit.org/show_bug.cgi?id=68025 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ This is a more logical place for this code. It also makes CSSStyleSelector slightly less bloated. |
+ It will make it possible to use fastRejectSelector for querySelectorAll in the future. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::loadViewSourceStyle): |
+ (WebCore::CSSStyleSelector::matchRulesForList): |
+ (WebCore::RuleData::RuleData): |
+ * css/CSSStyleSelector.h: |
+ (WebCore::CSSStyleSelector::pushParent): |
+ (WebCore::CSSStyleSelector::popParent): |
+ * css/SelectorChecker.cpp: |
+ (WebCore::collectElementIdentifierHashes): |
+ (WebCore::SelectorChecker::pushParentStackFrame): |
+ (WebCore::SelectorChecker::popParentStackFrame): |
+ (WebCore::SelectorChecker::pushParent): |
+ (WebCore::SelectorChecker::popParent): |
+ (WebCore::collectDescendantSelectorIdentifierHashes): |
+ (WebCore::SelectorChecker::collectIdentifierHashes): |
+ * css/SelectorChecker.h: |
+ (WebCore::SelectorChecker::parentStackIsConsistent): |
+ (WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame): |
+ (WebCore::SelectorChecker::fastRejectSelector): |
+ |
+2011-09-13 Kiyoto Tamura <owenestea@gmail.com> |
+ |
+ For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS' |
+ https://bugs.webkit.org/show_bug.cgi?id=36683 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ In addition to supporting the deprecated 'useCSS', 'styleWithCSS' now accepts any argument other than |
+ the boolean false or the case-insensitive string "false". This is per |
+ http://aryeh.name/spec/editing/editing.html#the-stylewithcss-command |
+ |
+ Tests: editing/execCommand/style-with-css.html |
+ editing/execCommand/use-css.html |
+ |
+ * editing/EditorCommand.cpp: |
+ (WebCore::executeStyleWithCSS): |
+ (WebCore::executeUseCSS): |
+ (WebCore::createCommandMap): |
+ |
+2011-09-13 Anders Carlsson <andersca@apple.com> |
+ |
+ Disable C++ exceptions when building with clang |
+ https://bugs.webkit.org/show_bug.cgi?id=68031 |
+ <rdar://problem/9556880> |
+ |
+ Reviewed by Mark Rowe. |
+ |
+ * Configurations/Base.xcconfig: |
+ |
+2011-09-13 Beth Dakin <bdakin@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=67885 |
+ Outline for the high-resolution broken image icon draws at 2x |
+ -and corresponding- |
+ <rdar://problem/10104637> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Scaled the image size to account for the deviceScaleFactor. |
+ * rendering/RenderImage.cpp: |
+ (WebCore::RenderImage::imageSizeForError): |
+ |
+2011-09-13 Tim Horton <timothy_horton@apple.com> |
+ |
+ REGRESSION (64275): Shape pattern-image fill turns black |
+ https://bugs.webkit.org/show_bug.cgi?id=51061 |
+ <rdar://problem/8504705> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ When destroying a resource, register clients who are losing their |
+ resource as having pending resources, so they can be resolved in the case a |
+ resource with that id is re-registered. |
+ |
+ Test: svg/custom/pending-resource-after-removal.xhtml |
+ |
+ * rendering/svg/SVGResourcesCache.cpp: |
+ (WebCore::SVGResourcesCache::resourceDestroyed): |
+ * svg/SVGStyledElement.h: |
+ (WebCore::toSVGStyledElement): Added. |
+ |
+2011-09-13 Eric Seidel <eric@webkit.org> |
+ |
+ Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5 |
+ https://bugs.webkit.org/show_bug.cgi?id=68018 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ * Configurations/FeatureDefines.xcconfig: |
+ * DerivedSources.make: |
+ * GNUmakefile.am: |
+ * WebCore.exp.in: |
+ * dom/DOMImplementation.cpp: |
+ (WebCore::isSVG10Feature): |
+ (WebCore::isSVG11Feature): |
+ * dom/Text.cpp: |
+ (WebCore::Text::createRenderer): |
+ * features.pri: |
+ * page/DOMWindow.idl: |
+ * rendering/svg/RenderSVGForeignObject.cpp: |
+ * rendering/svg/RenderSVGForeignObject.h: |
+ * svg/SVGAnimateMotionElement.cpp: |
+ (WebCore::SVGAnimateMotionElement::hasValidAttributeType): |
+ * svg/SVGForeignObjectElement.cpp: |
+ * svg/SVGForeignObjectElement.h: |
+ * svg/SVGForeignObjectElement.idl: |
+ * svg/SVGLocatable.cpp: |
+ (WebCore::isViewportElement): |
+ * svg/SVGSVGElement.cpp: |
+ (WebCore::SVGSVGElement::isOutermostSVG): |
+ * svg/SVGUseElement.cpp: |
+ (WebCore::isDisallowedElement): |
+ (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements): |
+ * svg/svgtags.in: |
+ |
+2011-09-13 Joseph Pecoraro <joepeck@webkit.org> |
+ |
+ CRASH under WebCore::ArchiveResourceCollection::addAllResources loading WebArchive |
+ https://bugs.webkit.org/show_bug.cgi?id=67983 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Null mimetypes are okay for subresources, but as previously discovered |
+ in bug 41082 they were required for main resources. Here we ensure |
+ that they are required for main resources, but we allow null mimetypes |
+ for subresources. |
+ |
+ To fix a crash for bad input we never add a null ArchiveResource to the |
+ Archive's subresource collection. It is useless and causes crashes whenever |
+ someone iterates the Archive's subresource collection. |
+ |
+ Test: webarchive/loading/test-loading-archive-subresource-null-mimetype.html |
+ |
+ * loader/archive/cf/LegacyWebArchive.cpp: |
+ (WebCore::LegacyWebArchive::createResource): |
+ Allow a null mimetype, just type check from the dictionary. |
+ |
+ (WebCore::LegacyWebArchive::extract): |
+ Require a mimetype for the main resource. Do not add null |
+ subresources to the subresource list. |
+ |
+2011-09-13 Mihai Parparita <mihaip@chromium.org> |
+ |
+ [Chromium] Remove javascript_engine from WebCore.gyp |
+ https://bugs.webkit.org/show_bug.cgi?id=68001 |
+ |
+ Reviewed by Tony Chang. |
+ |
+ Remove javascript_engine GYP variable (similar to the removal done on |
+ the Chromium side with http://crrev.com/100692) |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ |
+2011-09-12 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ [CSS3 Backgrounds and Borders] Add unprefixed border-image shorthand. |
+ https://bugs.webkit.org/show_bug.cgi?id=67970 |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Also update CSSStyleSelector.cpp to support border-image to suppress assertion in |
+ fast/borders/border-image-omit-right-slice.html |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ (WebCore::CSSStyleSelector::mapNinePieceImage): |
+ |
+2011-09-13 Xianzhu Wang <wangxianzhu@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Webkit wraps between hyphen-minus and numeric characters |
+ https://bugs.webkit.org/show_bug.cgi?id=20677 |
+ |
+ Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus |
+ is not directly after a digit or a letter. |
+ |
+ Test: fast/text/line-breaks-after-hyphen-before-number.html |
+ |
+ * rendering/break_lines.cpp: |
+ (WebCore::asciiLineBreakTable): Disabled line-breaking after '-' and before '.', '0'-'9'. Note: the change for '0'-'9' doesn't really matter because the case is handled hard-coded in shouldBreakAfter(). |
+ (WebCore::shouldBreakAfter): Changed line-breaking behavior after '-'. |
+ (WebCore::nextBreakablePosition): Passes lastLastCh to shouldBreakAfter. |
+ |
+2011-09-13 Erik Wright <erikwright@chromium.org> |
+ |
+ platform/graphics/gtk/FontGtk.cpp was renamed to platform/graphics/pango/FontPango.cpp . Reflect this change in WebCore.gypi to fix a Chromium build breakage. |
+ https://bugs.webkit.org/show_bug.cgi?id=68000 |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ No change in functionality, thus no new tests. |
+ |
+ * WebCore.gypi: |
+ |
+2011-09-10 Mikhail Naganov <mnaganov@chromium.org> |
+ |
+ Web Inspector: Profiler: Fix overlapping data in function names column. |
+ https://bugs.webkit.org/show_bug.cgi?id=67896 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * inspector/front-end/ProfileDataGridTree.js: |
+ (WebInspector.ProfileDataGridNode.prototype.createCell): |
+ * inspector/front-end/dataGrid.css: |
+ (.data-grid table.data): |
+ (.data-grid td): |
+ |
+2011-09-13 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r95025. |
+ http://trac.webkit.org/changeset/95025 |
+ https://bugs.webkit.org/show_bug.cgi?id=68005 |
+ |
+ Test failed on Snow Leopard bots. (Requested by yutak_home on |
+ #webkit). |
+ |
+ * websockets/ThreadableWebSocketChannelClientWrapper.cpp: |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol): |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol): |
+ * websockets/ThreadableWebSocketChannelClientWrapper.h: |
+ |
+2011-09-13 Yuta Kitamura <yutak@chromium.org> |
+ |
+ ThreadableWebSocketChannelClientWrapper shouldn't have a String in it. |
+ https://bugs.webkit.org/show_bug.cgi?id=67908 |
+ |
+ Reviewed by David Levin. |
+ |
+ Replace a String member variable in ThreadableWebSocketChannelClientWrapper with Vector<UChar>. |
+ |
+ No change in functionality, thus no new tests. WebSocket worker tests |
+ (tests under http/tests/websocket/tests/{hixie76,hybi}/workers/) should keep passing. |
+ |
+ * websockets/ThreadableWebSocketChannelClientWrapper.cpp: |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol): |
+ Create a String from Vector<UChar>. |
+ (WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol): |
+ Copy the content of the given String into Vector. |
+ * websockets/ThreadableWebSocketChannelClientWrapper.h: |
+ |
+2011-09-13 Fumitoshi Ukai <ukai@chromium.org> |
+ |
+ Unreviewed, build fix. |
+ |
+ CSSPropertyBorderImage was added in r94989, but not yet added in |
+ WebCore::CSSStyleSelector::applyProperty |
+ |
+ CSSStyleSelector.cpp:2481: warning: enumeration value 'CSSPropertyBorderImage' not handled in switch |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ |
+2011-09-12 Shinya Kawanaka <shinyak@google.com> |
+ |
+ Crashes in WebCore::InsertListCommand::unlistifyParagraph. |
+ https://bugs.webkit.org/show_bug.cgi?id=67918 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ execCommand("InsertUnorderedList") was crashing if the parent node of the target is |
+ a kind of list element and it is not contenteditable. |
+ This patch checks the parent node is contenteditable. |
+ |
+ Test: editing/execCommand/insert-list-in-noneditable-list-parent.html |
+ |
+ * editing/htmlediting.cpp: |
+ (WebCore::enclosingListChild): Checks the parent node is contenteditable. |
+ |
+2011-09-12 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r94975. |
+ http://trac.webkit.org/changeset/94975 |
+ https://bugs.webkit.org/show_bug.cgi?id=67984 |
+ |
+ crash in PrerenderBrowserTest.PrerenderHTML5VideoJs (Requested |
+ by ukai on #webkit). |
+ |
+ * platform/graphics/chromium/CanvasLayerChromium.h: |
+ (WebCore::CanvasLayerChromium::layerTypeAsString): |
+ * platform/graphics/chromium/ContentLayerChromium.h: |
+ (WebCore::ContentLayerChromium::layerTypeAsString): |
+ * platform/graphics/chromium/ImageLayerChromium.h: |
+ (WebCore::ImageLayerChromium::layerTypeAsString): |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::layerTreeAsText): |
+ (WebCore::writeIndent): |
+ (WebCore::LayerChromium::dumpLayer): |
+ (WebCore::LayerChromium::dumpLayerProperties): |
+ * platform/graphics/chromium/LayerChromium.h: |
+ (WebCore::LayerChromium::layerTypeAsString): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::textureMemoryReclaimLimit): |
+ (WebCore::LayerRendererChromium::create): |
+ (WebCore::LayerRendererChromium::LayerRendererChromium): |
+ (WebCore::LayerRendererChromium::close): |
+ (WebCore::LayerRendererChromium::releaseTextures): |
+ (WebCore::LayerRendererChromium::drawLayers): |
+ (WebCore::LayerRendererChromium::drawLayersInternal): |
+ (WebCore::LayerRendererChromium::getOffscreenLayerTexture): |
+ (WebCore::LayerRendererChromium::initializeSharedObjects): |
+ (WebCore::LayerRendererChromium::cleanupSharedObjects): |
+ (WebCore::LayerRendererChromium::layerTreeAsText): |
+ (WebCore::LayerRendererChromium::dumpRenderSurfaces): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ (WebCore::LayerRendererChromium::owner): |
+ (WebCore::LayerRendererChromium::rootLayer): |
+ (WebCore::LayerRendererChromium::rootLayerImpl): |
+ (WebCore::LayerRendererChromium::viewportSize): |
+ (WebCore::LayerRendererChromium::contentsTextureManager): |
+ * platform/graphics/chromium/ManagedTexture.cpp: |
+ (WebCore::ManagedTexture::bindTexture): |
+ (WebCore::ManagedTexture::framebufferTexture2D): |
+ * platform/graphics/chromium/PluginLayerChromium.h: |
+ (WebCore::PluginLayerChromium::layerTypeAsString): |
+ * platform/graphics/chromium/RenderSurfaceChromium.cpp: |
+ (WebCore::RenderSurfaceChromium::name): |
+ (WebCore::writeIndent): |
+ (WebCore::RenderSurfaceChromium::dumpSurface): |
+ * platform/graphics/chromium/RenderSurfaceChromium.h: |
+ * platform/graphics/chromium/TextureManager.cpp: |
+ (WebCore::TextureManager::deleteEvictedTextures): |
+ (WebCore::TextureManager::removeTexture): |
+ (WebCore::TextureManager::allocateTexture): |
+ (WebCore::TextureManager::requestTexture): |
+ * platform/graphics/chromium/TextureManager.h: |
+ (WebCore::TextureManager::setAssociatedContextDebugOnly): |
+ (WebCore::TextureManager::associatedContextDebugOnly): |
+ * platform/graphics/chromium/TiledLayerChromium.cpp: |
+ (WebCore::writeIndent): |
+ (WebCore::TiledLayerChromium::dumpLayerProperties): |
+ * platform/graphics/chromium/TiledLayerChromium.h: |
+ * platform/graphics/chromium/VideoLayerChromium.h: |
+ (WebCore::VideoLayerChromium::layerTypeAsString): |
+ * platform/graphics/chromium/WebGLLayerChromium.h: |
+ (WebCore::WebGLLayerChromium::layerTypeAsString): |
+ * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: |
+ * platform/graphics/chromium/cc/CCCanvasLayerImpl.h: |
+ * platform/graphics/chromium/cc/CCLayerImpl.cpp: |
+ * platform/graphics/chromium/cc/CCLayerImpl.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
+ (WebCore::CCLayerTreeHost::initialize): |
+ (WebCore::CCLayerTreeHost::~CCLayerTreeHost): |
+ (WebCore::CCLayerTreeHost::commitTo): |
+ (WebCore::CCLayerTreeHost::didRecreateGraphicsContext): |
+ (WebCore::CCLayerTreeHost::setVisible): |
+ (WebCore::CCLayerTreeHost::contentsTextureManager): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: |
+ (WebCore::CCLayerTreeHostImpl::drawLayers): |
+ (WebCore::CCLayerTreeHostImpl::setVisible): |
+ (WebCore::CCLayerTreeHostImpl::initializeLayerRenderer): |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: |
+ * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: |
+ * platform/graphics/chromium/cc/CCPluginLayerImpl.h: |
+ * platform/graphics/chromium/cc/CCProxy.h: |
+ * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: |
+ (WebCore::CCSingleThreadProxy::initializeLayerRenderer): |
+ (WebCore::CCSingleThreadProxy::stop): |
+ (WebCore::CCSingleThreadProxy::contentsTextureManager): |
+ (WebCore::CCSingleThreadProxy::recreateContextIfNeeded): |
+ * platform/graphics/chromium/cc/CCSingleThreadProxy.h: |
+ * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
+ (WebCore::CCThreadProxy::initializeLayerRenderer): |
+ (WebCore::CCThreadProxy::contentsTextureManager): |
+ (WebCore::CCThreadProxy::initializeLayerRendererOnCCThread): |
+ (WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread): |
+ * platform/graphics/chromium/cc/CCThreadProxy.h: |
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: |
+ (WebCore::CCTiledLayerImpl::dumpLayerProperties): |
+ * platform/graphics/chromium/cc/CCTiledLayerImpl.h: |
+ * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: |
+ * platform/graphics/chromium/cc/CCVideoLayerImpl.h: |
+ |
+2011-09-12 Joseph Pecoraro <joepeck@webkit.org> |
+ |
+ Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker |
+ https://bugs.webkit.org/show_bug.cgi?id=67957 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ The storageTracker singleton may already have been created |
+ through StorageTracker::tracker before initializeTracker |
+ gets called. Update the ASSERT in this case to check that |
+ there is no client for the tracker. |
+ |
+ No test, this depends on how the port initializes the tracker. |
+ |
+ * storage/StorageTracker.cpp: |
+ (WebCore::StorageTracker::initializeTracker): |
+ |
+2011-09-12 Adam Klein <adamk@chromium.org> |
+ |
+ Fix out-of-bounds access in Gradient::sortStopsIfNecessary |
+ https://bugs.webkit.org/show_bug.cgi?id=67958 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Reported by Valgrind in http://crbug.com/77049. |
+ |
+ The errant code was added as an optimization in r67804. |
+ This patch reverts that one, as all parties agree that the optimization |
+ doesn't seem worthwhile, and there clearly aren't any tests covering |
+ the special case. |
+ |
+ No new tests, as existing tests should cover the remaining call to |
+ |std::stable_sort|. |
+ |
+ * platform/graphics/Gradient.cpp: |
+ (WebCore::Gradient::sortStopsIfNecessary): |
+ |
+2011-09-12 Jacky Jiang <zhajiang@rim.com> |
+ |
+ Setting document.title doesn't affect contents of title tag of XHTML documents |
+ https://bugs.webkit.org/show_bug.cgi?id=57537 |
+ |
+ Reviewed by Alexey Proskuryakov. |
+ |
+ Update the contents of the <title> tag of XHTML documents when setting |
+ document.title. |
+ |
+ Test: fast/dom/title-content-set-innerText-get.xhtml |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::setTitle): |
+ |
+2011-09-12 Raphael Kubo da Costa <kubo@profusion.mobi> |
+ |
+ [EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl. |
+ https://bugs.webkit.org/show_bug.cgi?id=67038 |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ Since most of the time it will return the same thing as text(), we |
+ initialize it the same way we initialize m_text. The other case (what |
+ would have been generated if no modifiers were pressed) should be |
+ covered by this as well. |
+ |
+ As this method is used when handling access keys, tests such as |
+ fast/events/access-key-self-destruct.html should now pass. |
+ |
+ No new tests, as this fixes a problem uncovered by the existing ones. |
+ |
+ * platform/efl/PlatformKeyboardEventEfl.cpp: |
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): |
+ |
+2011-09-12 Hyowon Kim <hw1008.kim@samsung.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ [EFL] Add GraphicsContext3DEfl for WebGL and accelerated compositing |
+ https://bugs.webkit.org/show_bug.cgi?id=62709 |
+ |
+ Add GraphicsContext3D implementation for EFL port. |
+ GraphicsContext3D delegates to GraphicsContext3DInternal. |
+ |
+ * platform/graphics/efl/GraphicsContext3DEfl.cpp: Added. |
+ (WebCore::GraphicsContext3D::create): |
+ (WebCore::GraphicsContext3D::GraphicsContext3D): |
+ (WebCore::GraphicsContext3D::~GraphicsContext3D): |
+ (WebCore::GraphicsContext3D::platformGraphicsContext3D): |
+ (WebCore::GraphicsContext3D::platformLayer): |
+ (WebCore::GraphicsContext3D::makeContextCurrent): |
+ (WebCore::GraphicsContext3D::isGLES2Compliant): |
+ (WebCore::GraphicsContext3D::activeTexture): |
+ (WebCore::GraphicsContext3D::attachShader): |
+ (WebCore::GraphicsContext3D::bindAttribLocation): |
+ (WebCore::GraphicsContext3D::bindBuffer): |
+ (WebCore::GraphicsContext3D::bindFramebuffer): |
+ (WebCore::GraphicsContext3D::bindRenderbuffer): |
+ (WebCore::GraphicsContext3D::bindTexture): |
+ (WebCore::GraphicsContext3D::blendColor): |
+ (WebCore::GraphicsContext3D::blendEquation): |
+ (WebCore::GraphicsContext3D::blendEquationSeparate): |
+ (WebCore::GraphicsContext3D::blendFunc): |
+ (WebCore::GraphicsContext3D::blendFuncSeparate): |
+ (WebCore::GraphicsContext3D::bufferData): |
+ (WebCore::GraphicsContext3D::bufferSubData): |
+ (WebCore::GraphicsContext3D::checkFramebufferStatus): |
+ (WebCore::GraphicsContext3D::clear): |
+ (WebCore::GraphicsContext3D::clearColor): |
+ (WebCore::GraphicsContext3D::clearDepth): |
+ (WebCore::GraphicsContext3D::clearStencil): |
+ (WebCore::GraphicsContext3D::colorMask): |
+ (WebCore::GraphicsContext3D::compileShader): |
+ (WebCore::GraphicsContext3D::copyTexImage2D): |
+ (WebCore::GraphicsContext3D::copyTexSubImage2D): |
+ (WebCore::GraphicsContext3D::cullFace): |
+ (WebCore::GraphicsContext3D::depthFunc): |
+ (WebCore::GraphicsContext3D::depthMask): |
+ (WebCore::GraphicsContext3D::depthRange): |
+ (WebCore::GraphicsContext3D::detachShader): |
+ (WebCore::GraphicsContext3D::disable): |
+ (WebCore::GraphicsContext3D::disableVertexAttribArray): |
+ (WebCore::GraphicsContext3D::drawArrays): |
+ (WebCore::GraphicsContext3D::drawElements): |
+ (WebCore::GraphicsContext3D::enable): |
+ (WebCore::GraphicsContext3D::enableVertexAttribArray): |
+ (WebCore::GraphicsContext3D::finish): |
+ (WebCore::GraphicsContext3D::flush): |
+ (WebCore::GraphicsContext3D::framebufferRenderbuffer): |
+ (WebCore::GraphicsContext3D::framebufferTexture2D): |
+ (WebCore::GraphicsContext3D::frontFace): |
+ (WebCore::GraphicsContext3D::generateMipmap): |
+ (WebCore::GraphicsContext3D::getActiveAttrib): |
+ (WebCore::GraphicsContext3D::getActiveUniform): |
+ (WebCore::GraphicsContext3D::getAttachedShaders): |
+ (WebCore::GraphicsContext3D::getAttribLocation): |
+ (WebCore::GraphicsContext3D::getBooleanv): |
+ (WebCore::GraphicsContext3D::getBufferParameteriv): |
+ (WebCore::GraphicsContext3D::getContextAttributes): |
+ (WebCore::GraphicsContext3D::getError): |
+ (WebCore::GraphicsContext3D::getFloatv): |
+ (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): |
+ (WebCore::GraphicsContext3D::getIntegerv): |
+ (WebCore::GraphicsContext3D::getProgramiv): |
+ (WebCore::GraphicsContext3D::getProgramInfoLog): |
+ (WebCore::GraphicsContext3D::getRenderbufferParameteriv): |
+ (WebCore::GraphicsContext3D::getShaderiv): |
+ (WebCore::GraphicsContext3D::getShaderInfoLog): |
+ (WebCore::GraphicsContext3D::getShaderSource): |
+ (WebCore::GraphicsContext3D::getString): |
+ (WebCore::GraphicsContext3D::getTexParameterfv): |
+ (WebCore::GraphicsContext3D::getTexParameteriv): |
+ (WebCore::GraphicsContext3D::getUniformfv): |
+ (WebCore::GraphicsContext3D::getUniformiv): |
+ (WebCore::GraphicsContext3D::getUniformLocation): |
+ (WebCore::GraphicsContext3D::getVertexAttribfv): |
+ (WebCore::GraphicsContext3D::getVertexAttribiv): |
+ (WebCore::GraphicsContext3D::getVertexAttribOffset): |
+ (WebCore::GraphicsContext3D::hint): |
+ (WebCore::GraphicsContext3D::isBuffer): |
+ (WebCore::GraphicsContext3D::isEnabled): |
+ (WebCore::GraphicsContext3D::isFramebuffer): |
+ (WebCore::GraphicsContext3D::isProgram): |
+ (WebCore::GraphicsContext3D::isRenderbuffer): |
+ (WebCore::GraphicsContext3D::isShader): |
+ (WebCore::GraphicsContext3D::isTexture): |
+ (WebCore::GraphicsContext3D::lineWidth): |
+ (WebCore::GraphicsContext3D::linkProgram): |
+ (WebCore::GraphicsContext3D::pixelStorei): |
+ (WebCore::GraphicsContext3D::polygonOffset): |
+ (WebCore::GraphicsContext3D::readPixels): |
+ (WebCore::GraphicsContext3D::releaseShaderCompiler): |
+ (WebCore::GraphicsContext3D::renderbufferStorage): |
+ (WebCore::GraphicsContext3D::sampleCoverage): |
+ (WebCore::GraphicsContext3D::scissor): |
+ (WebCore::GraphicsContext3D::shaderSource): |
+ (WebCore::GraphicsContext3D::stencilFunc): |
+ (WebCore::GraphicsContext3D::stencilFuncSeparate): |
+ (WebCore::GraphicsContext3D::stencilMask): |
+ (WebCore::GraphicsContext3D::stencilMaskSeparate): |
+ (WebCore::GraphicsContext3D::stencilOp): |
+ (WebCore::GraphicsContext3D::stencilOpSeparate): |
+ (WebCore::GraphicsContext3D::texImage2D): |
+ (WebCore::GraphicsContext3D::texParameterf): |
+ (WebCore::GraphicsContext3D::texParameteri): |
+ (WebCore::GraphicsContext3D::texSubImage2D): |
+ (WebCore::GraphicsContext3D::uniform1f): |
+ (WebCore::GraphicsContext3D::uniform1fv): |
+ (WebCore::GraphicsContext3D::uniform1i): |
+ (WebCore::GraphicsContext3D::uniform1iv): |
+ (WebCore::GraphicsContext3D::uniform2f): |
+ (WebCore::GraphicsContext3D::uniform2fv): |
+ (WebCore::GraphicsContext3D::uniform2i): |
+ (WebCore::GraphicsContext3D::uniform2iv): |
+ (WebCore::GraphicsContext3D::uniform3f): |
+ (WebCore::GraphicsContext3D::uniform3fv): |
+ (WebCore::GraphicsContext3D::uniform3i): |
+ (WebCore::GraphicsContext3D::uniform3iv): |
+ (WebCore::GraphicsContext3D::uniform4f): |
+ (WebCore::GraphicsContext3D::uniform4fv): |
+ (WebCore::GraphicsContext3D::uniform4i): |
+ (WebCore::GraphicsContext3D::uniform4iv): |
+ (WebCore::GraphicsContext3D::uniformMatrix2fv): |
+ (WebCore::GraphicsContext3D::uniformMatrix3fv): |
+ (WebCore::GraphicsContext3D::uniformMatrix4fv): |
+ (WebCore::GraphicsContext3D::useProgram): |
+ (WebCore::GraphicsContext3D::validateProgram): |
+ (WebCore::GraphicsContext3D::vertexAttrib1f): |
+ (WebCore::GraphicsContext3D::vertexAttrib1fv): |
+ (WebCore::GraphicsContext3D::vertexAttrib2f): |
+ (WebCore::GraphicsContext3D::vertexAttrib2fv): |
+ (WebCore::GraphicsContext3D::vertexAttrib3f): |
+ (WebCore::GraphicsContext3D::vertexAttrib3fv): |
+ (WebCore::GraphicsContext3D::vertexAttrib4f): |
+ (WebCore::GraphicsContext3D::vertexAttrib4fv): |
+ (WebCore::GraphicsContext3D::vertexAttribPointer): |
+ (WebCore::GraphicsContext3D::viewport): |
+ (WebCore::GraphicsContext3D::reshape): |
+ (WebCore::GraphicsContext3D::markContextChanged): |
+ (WebCore::GraphicsContext3D::markLayerComposited): |
+ (WebCore::GraphicsContext3D::layerComposited): |
+ (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): |
+ (WebCore::GraphicsContext3D::paintRenderingResultsToImageData): |
+ (WebCore::GraphicsContext3D::createBuffer): |
+ (WebCore::GraphicsContext3D::createFramebuffer): |
+ (WebCore::GraphicsContext3D::createProgram): |
+ (WebCore::GraphicsContext3D::createRenderbuffer): |
+ (WebCore::GraphicsContext3D::createShader): |
+ (WebCore::GraphicsContext3D::createTexture): |
+ (WebCore::GraphicsContext3D::deleteBuffer): |
+ (WebCore::GraphicsContext3D::deleteFramebuffer): |
+ (WebCore::GraphicsContext3D::deleteProgram): |
+ (WebCore::GraphicsContext3D::deleteRenderbuffer): |
+ (WebCore::GraphicsContext3D::deleteShader): |
+ (WebCore::GraphicsContext3D::deleteTexture): |
+ (WebCore::GraphicsContext3D::synthesizeGLError): |
+ (WebCore::GraphicsContext3D::getExtensions): |
+ (WebCore::GraphicsContext3D::getInternalFramebufferSize): |
+ (WebCore::GraphicsContext3D::setContextLostCallback): |
+ (WebCore::GraphicsContext3D::getImageData): |
+ |
+2011-09-12 Hyowon Kim <hw1008.kim@samsung.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ [CMAKE] Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt |
+ https://bugs.webkit.org/show_bug.cgi?id=62707 |
+ |
+ No change in fuctionality so no new tests. |
+ |
+ Bug 62376 makes all ports use GraphicsContext3DOpenGL and |
+ Extensions3DOpenGL when enabling WebGL. |
+ However, some ports already have their own GC3D implementation. |
+ In QT and chromium, for example, GC3D delegates to GC3DInternal. |
+ So, it would be better to allow each port to decide whether or not |
+ to include files in platform/graphics/opengl. |
+ |
+ * CMakeLists.txt: |
+ |
+2011-09-12 Dan Bernstein <mitz@apple.com> |
+ |
+ <rdar://problem/10054615> Floats in ruby text intrude into the base |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Test: fast/ruby/float-overhang-from-ruby-text.html |
+ |
+ * rendering/RenderRubyText.cpp: |
+ (WebCore::RenderRubyText::avoidsFloats): Added. Returns true. This ensures that |
+ RenderBlock::clearFloats() will not consider ruby text as having intruding floats. |
+ * rendering/RenderRubyText.h: |
+ |
+2011-09-12 David Hyatt <hyatt@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=67970 |
+ |
+ Add unprefixed border-image property. |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ * css/CSSComputedStyleDeclaration.cpp: |
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseValue): |
+ * css/CSSPropertyNames.in: |
+ |
+2011-09-12 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ REGRESSION: Moving up doesn't work in some cases |
+ https://bugs.webkit.org/show_bug.cgi?id=67522 |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ The bug was caused by previousLinePosition's attempting to obtain the last root line box using |
+ a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines). |
+ |
+ Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1), |
+ use the positionBeforeNode for br elements. |
+ |
+ Test: editing/selection/move-up-into-wrapped-line.html |
+ |
+ * editing/visible_units.cpp: |
+ (WebCore::previousLinePosition): |
+ |
+2011-09-12 David Levin <levin@chromium.org> |
+ |
+ Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*. |
+ https://bugs.webkit.org/show_bug.cgi?id=67947 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ The changes are tested by compiling and added compile asserts to do some verification as well. |
+ |
+ * platform/CrossThreadCopier.cpp: |
+ Added some compile asserts to verify various match and non-matches for CrossThreadCopier. |
+ * platform/CrossThreadCopier.h: |
+ Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr. |
+ Added a compile assert to verify that only one of the typedef did anything. |
+ (CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary. |
+ It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently |
+ convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method. |
+ |
+2011-09-12 Chris Rogers <crogers@google.com> |
+ |
+ Address lifetime issues in OfflineAudioDestinationNode |
+ https://bugs.webkit.org/show_bug.cgi?id=67949 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ No new tests. This does not change JavaScript API. |
+ |
+ * webaudio/OfflineAudioDestinationNode.cpp: |
+ (WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode): |
+ (WebCore::OfflineAudioDestinationNode::render): |
+ (WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch): |
+ |
+2011-09-12 Jeff Timanus <twiz@chromium.org> |
+ |
+ [chromium] Prevent a crash when tearing down an ImageBuffer that was not successfully initialized. |
+ https://bugs.webkit.org/show_bug.cgi?id=67944 |
+ |
+ Reviewed by Stephen White. |
+ |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::ImageBuffer::~ImageBuffer): |
+ |
+2011-09-12 Michael Saboff <msaboff@apple.com> |
+ |
+ Update RegExp and related classes to use 8 bit strings when available |
+ https://bugs.webkit.org/show_bug.cgi?id=67337 |
+ |
+ Updated call to match to use UString& instead of UChar*. |
+ |
+ Reviewed by Gavin Barraclough. |
+ |
+ No new tests, Covered by existing tests. |
+ |
+ * platform/text/RegularExpression.cpp: |
+ (WebCore::RegularExpression::match): |
+ |
+2011-09-12 Beth Dakin <bdakin@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=67898 |
+ REGRESSION(r94900): fast/images/support-broken-image-delegate.html fails on Mac |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ New function willPaintBrokenImage() returns true when there has been an error |
+ loading the image and the broken image icon will be used in its place. This is |
+ necessary since it is possible to have an error loading an image and to NOT use |
+ the broken image icon. |
+ * loader/cache/CachedImage.cpp: |
+ (WebCore::CachedImage::willPaintBrokenImage): |
+ * loader/cache/CachedImage.h: |
+ * rendering/RenderImage.cpp: |
+ (WebCore::RenderImage::imageSizeForError): |
+ |
2011-09-12 James Robinson <jamesr@chromium.org> |
+ [chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost |
+ https://bugs.webkit.org/show_bug.cgi?id=67440 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ This moves the contents TextureManager over to the CCLayerTreeHost, where it belongs, and adds in a commit path |
+ to make sure that textures are deleted even if the page is not visible. This move also removed the need for |
+ LayerRendererChromium's CCLayerTreeHost pointer, so I removed that as well. That meant moving the |
+ layerTreeAsText() logic over to the CCLayerImpl side, which is where it really belonged anyway. |
+ |
+ Covered by existing compositing/ tests and |
+ platform/chromium/compositor/lost-compositor-context-with-rendersurface.html |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::releaseRenderSurfaceTextures): |
+ (WebCore::LayerRendererChromium::drawLayers): |
+ (WebCore::LayerRendererChromium::initializeSharedObjects): |
+ (WebCore::LayerRendererChromium::cleanupSharedObjects): |
+ * platform/graphics/chromium/LayerRendererChromium.h: |
+ (WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes): |
+ * platform/graphics/chromium/TextureManager.cpp: |
+ (WebCore::TextureManager::highLimitBytes): |
+ (WebCore::TextureManager::reclaimLimitBytes): |
+ (WebCore::TextureManager::lowLimitBytes): |
+ * platform/graphics/chromium/TextureManager.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
+ (WebCore::CCLayerTreeHost::initialize): |
+ (WebCore::CCLayerTreeHost::~CCLayerTreeHost): |
+ (WebCore::CCLayerTreeHost::deleteContentsTextures): |
+ (WebCore::CCLayerTreeHost::commitTo): |
+ (WebCore::CCLayerTreeHost::setVisible): |
+ (WebCore::CCLayerTreeHost::contentsTextureManager): |
+ * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
+ * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: |
+ (WebCore::CCLayerTreeHostImpl::setVisible): |
+ * platform/graphics/chromium/cc/CCProxy.h: |
+ * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: |
+ (WebCore::CCSingleThreadProxy::setNeedsCommit): |
+ (WebCore::CCSingleThreadProxy::stop): |
+ * platform/graphics/chromium/cc/CCSingleThreadProxy.h: |
+ * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
+ (WebCore::CCThreadProxy::setNeedsCommit): |
+ (WebCore::CCThreadProxy::setNeedsCommitOnCCThread): |
+ (WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread): |
+ * platform/graphics/chromium/cc/CCThreadProxy.h: |
+ |
+2011-09-12 Chris Rogers <crogers@google.com> |
+ |
+ DelayNode delay buffer is not correctly wrapping around |
+ https://bugs.webkit.org/show_bug.cgi?id=67872 |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Test: webaudio/delaynode.html |
+ |
+ * webaudio/DelayDSPKernel.cpp: |
+ (WebCore::DelayDSPKernel::process): |
+ |
+2011-09-12 Arko Saha <arko@motorola.com> |
+ |
+ Selectstart is not fired when selection was created by arrow keys. |
+ https://bugs.webkit.org/show_bug.cgi?id=60430 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ Fire selectstart when a user starts extending the selection using arrow key. |
+ Fixed by Arko Saha <arko@motorola.com> and Kaustubh Atrawalkar <kaustubh@motorola.com> |
+ |
+ Tests: fast/events/selectstart-by-arrow-keys-prevent-default.html |
+ fast/events/selectstart-by-arrow-keys.html |
+ |
+ * editing/FrameSelection.cpp: |
+ (WebCore::FrameSelection::modify): |
+ (WebCore::FrameSelection::shouldChangeSelection): |
+ (WebCore::FrameSelection::dispatchSelectStart): |
+ * editing/FrameSelection.h: |
+ |
+2011-09-12 James Robinson <jamesr@chromium.org> |
+ |
[chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process |
https://bugs.webkit.org/show_bug.cgi?id=67816 |