Issue 7982002: [cros,webui] Adds scrollbar for the network drop-down controller.

Issue 7982002: [cros,webui] Adds scrollbar for the network drop-down controller. (Closed)

Created:
9 years, 3 months ago by altimofeev

Modified:
9 years, 3 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros,webui] Adds scrollbar for the network drop-down controller. Also ellipses was added for the title. BUG=chromium-os:19789, chromium-os:20510 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102097

Patch Set 2 : added ellipsis for title, fixed width problems #

Total comments: 4

Patch Set 3 : nits #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -15 lines)			Patch
M	chrome/browser/resources/chromeos/login/network_dropdown.css	View	1 2	2 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/network_dropdown.js	View	1 2	6 chunks	+33 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.css	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

altimofeev

I have update CSS, so now menu item's width is flexible (depends on the whether ...

9 years, 3 months ago (2011-09-21 08:41:55 UTC) #2

Nikita (slow)

lgtm http://codereview.chromium.org/7982002/diff/1004/chrome/browser/resources/chromeos/login/network_dropdown.css File chrome/browser/resources/chromeos/login/network_dropdown.css (right): http://codereview.chromium.org/7982002/diff/1004/chrome/browser/resources/chromeos/login/network_dropdown.css#newcode58 chrome/browser/resources/chromeos/login/network_dropdown.css:58: max-height: 350px; nit: This value should be based ...

9 years, 3 months ago (2011-09-21 10:44:25 UTC) #3

altimofeev

9 years, 3 months ago (2011-09-21 11:49:52 UTC) #4

http://codereview.chromium.org/7982002/diff/1004/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/network_dropdown.css (right):

http://codereview.chromium.org/7982002/diff/1004/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/network_dropdown.css:58: max-height:
350px;
On 2011/09/21 10:44:25, Nikita Kostylev wrote:
> nit: This value should be based on space available for French UI language
since
> it makes 2 line labels.

Use 330px. Done.

http://codereview.chromium.org/7982002/diff/1004/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/network_dropdown.js (right):

http://codereview.chromium.org/7982002/diff/1004/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/network_dropdown.js:31: scrollAction:
function(item) {
On 2011/09/21 10:44:25, Nikita Kostylev wrote:
> nit: Function comment.

Done.

Expand Messages | Collapse Messages