Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Issue 7981047: Allow word separators in a few more Autofill regexes (Closed)

Created:
9 years, 3 months ago by Ilya Sherman
Modified:
9 years, 3 months ago
CC:
chromium-reviews, GeorgeY, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., Ilya Sherman, dhollowa
Visibility:
Public.

Description

Allow word separators in a few more Autofill regexes. This also fixes an issue where inferred sections were not being updated after server types were returned. BUG=93595 TEST=browser_tests --gtest_filter=*DataDrivenHeuristics*16* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102251

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -59 lines) Patch
M chrome/browser/autofill/autofill_regex_constants.cc.utf8 View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/form_structure.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 4 chunks +57 lines, -55 lines 0 comments Download
A chrome/test/data/autofill/heuristics/input/16_crbug_93595.html View 1 chunk +80 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/16_crbug_93595.out View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
9 years, 3 months ago (2011-09-22 01:18:26 UTC) #1
dhollowa
LGTM.
9 years, 3 months ago (2011-09-22 02:36:43 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
9 years, 3 months ago (2011-09-22 05:20:37 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 08:43:30 UTC) #4
Change committed as 102251

Powered by Google App Engine
This is Rietveld 408576698