Make infobars ignore button clicks when closing.

chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm

Index: chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm
===================================================================
--- chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm	(revision 102206)
+++ chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm	(working copy)
@@ -106,16 +106,16 @@
 
 // This is called when the "Never Translate [language]" button is pressed.
 - (void)neverTranslate:(id)sender {
-  TranslateInfoBarDelegate* delegate = [self delegate];
-  if (delegate)
-    [self delegate]->NeverTranslatePageLanguage();
+  if (![self owned])
+    return;  // We're closing; don't call anything, it might access the owner.

[Robert Sesek, 2011/09/22 16:49:56]

I'm not sure this copy-pasted comment is really necessary in every place.

[Peter Kasting, 2011/09/22 21:55:25]

It does seem redundant, but OTOH, I really don't want to just have no comment in
some places either... this stuff is all subtle :(

[Robert Sesek, 2011/09/24 19:20:16]

How about adding something like it to the declaration of |-owned| instead?

[Peter Kasting, 2011/09/26 22:34:49]

Done.

+  [self delegate]->NeverTranslatePageLanguage();
 }
 
 // This is called when the "Always Translate [language]" button is pressed.
 - (void)alwaysTranslate:(id)sender {
-  TranslateInfoBarDelegate* delegate = [self delegate];
-  if (delegate)
-    delegate->AlwaysTranslatePageLanguage();
+  if (![self owned])
+    return;  // We're closing; don't call anything, it might access the owner.
+  [self delegate]->AlwaysTranslatePageLanguage();
 }
 
 - (bool)verifyLayout {