Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2658)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/tab_contents/infobar.cc

Issue 7981045: Make infobars ignore button clicks when closing. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/infobar.h ('k') | chrome/browser/ui/cocoa/infobars/infobar_controller.h » ('j') | chrome/browser/ui/cocoa/infobars/infobar_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/infobar.cc
===================================================================
--- chrome/browser/tab_contents/infobar.cc (revision 102206)
+++ chrome/browser/tab_contents/infobar.cc (working copy)
@@ -102,10 +102,8 @@
}
void InfoBar::RemoveSelf() {
- // |owner_| can be NULL here, e.g. because the user clicks the close button
- // when the infobar is already closing.
- if (delegate_ && owner_)
- owner_->infobar_tab_helper()->RemoveInfoBar(delegate_);
+ DCHECK(owner_);
+ owner_->infobar_tab_helper()->RemoveInfoBar(delegate_);
}
void InfoBar::SetBarTargetHeight(int height) {
« no previous file with comments | « chrome/browser/tab_contents/infobar.h ('k') | chrome/browser/ui/cocoa/infobars/infobar_controller.h » ('j') | chrome/browser/ui/cocoa/infobars/infobar_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698