Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc

Issue 7981045: Make infobars ignore button clicks when closing. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm ('K') | « chrome/browser/ui/gtk/infobars/link_infobar_gtk.cc ('k') | chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc (revision 102206)
+++ chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc (working copy)
@@ -209,6 +209,8 @@
}
void TranslateInfoBarBase::OnOptionsClicked(GtkWidget* sender) {
+ if (!owned())
+ return; // We're closing; don't call anything, it might access the owner.
if (!options_menu_model_.get()) {
options_menu_model_.reset(new OptionsMenuModel(GetDelegate()));
options_menu_menu_.reset(new MenuGtk(NULL, options_menu_model_.get()));
« chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm ('K') | « chrome/browser/ui/gtk/infobars/link_infobar_gtk.cc ('k') | chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698