Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc

Issue 7981045: Make infobars ignore button clicks when closing. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm ('K') | « chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.cc ('k') | chrome/browser/ui/gtk/infobars/infobar_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc (revision 102206)
+++ chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc (working copy)
@@ -177,6 +177,10 @@
gboolean ExtensionInfoBarGtk::OnButtonPress(GtkWidget* widget,
GdkEventButton* event) {
+ // If we're closing, don't call anything, it might access the owner.
+ if (!owned())
+ return FALSE;
+
if (event->button != 1)
return FALSE;
« chrome/browser/ui/cocoa/translate/before_translate_infobar_controller.mm ('K') | « chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.cc ('k') | chrome/browser/ui/gtk/infobars/infobar_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698