Make infobars ignore button clicks when closing.

chrome/browser/ui/views/infobars/confirm_infobar.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/infobars/confirm_infobar.h"
 
 #include "base/logging.h"
 #include "chrome/browser/tab_contents/confirm_infobar_delegate.h"
 #include "chrome/browser/ui/views/event_utils.h"
 #include "views/controls/button/text_button.h"
@@ skipping 80 matching lines @@
     }
   }
 
   // This must happen after adding all other children so InfoBarView can ensure
   // the close button is the last child.
   InfoBarView::ViewHierarchyChanged(is_add, parent, child);
 }
 
 void ConfirmInfoBar::ButtonPressed(views::Button* sender,
                                    const views::Event& event) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   ConfirmInfoBarDelegate* delegate = GetDelegate();
   if ((ok_button_ != NULL) && sender == ok_button_) {
     if (delegate->Accept())
       RemoveSelf();
   } else if ((cancel_button_ != NULL) && (sender == cancel_button_)) {
     if (delegate->Cancel())
       RemoveSelf();
   } else {
     InfoBarView::ButtonPressed(sender, event);
   }
 }
 
 int ConfirmInfoBar::ContentMinimumWidth() const {
   int width = (link_ == NULL) ? 0 : kEndOfLabelSpacing;  // Space before link
   int before_cancel_spacing = kEndOfLabelSpacing;
   if (ok_button_ != NULL) {
     width += kEndOfLabelSpacing + ok_button_->GetPreferredSize().width();
     before_cancel_spacing = kButtonButtonSpacing;
   }
   return width + ((cancel_button_ == NULL) ? 0 :
       (before_cancel_spacing + cancel_button_->GetPreferredSize().width()));
 }
 
 void ConfirmInfoBar::LinkClicked(views::Link* source, int event_flags) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   DCHECK(link_ != NULL);
   DCHECK_EQ(link_, source);
   if (GetDelegate()->LinkClicked(
       event_utils::DispositionFromEventFlags(event_flags)))
     RemoveSelf();
 }
 
 ConfirmInfoBarDelegate* ConfirmInfoBar::GetDelegate() {
   return delegate()->AsConfirmInfoBarDelegate();
 }