Make infobars ignore button clicks when closing.

chrome/browser/ui/views/infobars/before_translate_infobar.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/infobars/before_translate_infobar.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/translate/translate_infobar_delegate.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 143 matching lines @@
           (kButtonButtonSpacing +
               never_translate_button_->GetPreferredSize().width())) +
       ((always_translate_button_ == NULL) ? 0 :
           (kButtonButtonSpacing +
               always_translate_button_->GetPreferredSize().width())) +
       (kEndOfLabelSpacing + options_menu_button_->GetPreferredSize().width());
 }
 
 void BeforeTranslateInfoBar::ButtonPressed(views::Button* sender,
                                            const views::Event& event) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   TranslateInfoBarDelegate* delegate = GetDelegate();
   if (sender == accept_button_) {
     delegate->Translate();
   } else if (sender == deny_button_) {
     delegate->TranslationDeclined();
     RemoveSelf();
   } else if (sender == never_translate_button_) {
     delegate->NeverTranslatePageLanguage();
   } else if (sender == always_translate_button_) {
     delegate->AlwaysTranslatePageLanguage();
   } else {
     TranslateInfoBarBase::ButtonPressed(sender, event);
   }
 }
 
 void BeforeTranslateInfoBar::OriginalLanguageChanged() {
   // Tests can call this function when the infobar has never been added to a
   // view hierarchy and thus there is no button.
   if (language_menu_button_) {
     UpdateLanguageButtonText(language_menu_button_,
                              LanguagesMenuModel::ORIGINAL);
   }
 }
 
 void BeforeTranslateInfoBar::RunMenu(View* source, const gfx::Point& pt) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   ui::MenuModel* menu_model = NULL;
   views::MenuButton* button = NULL;
   views::MenuItemView::AnchorPosition anchor = views::MenuItemView::TOPLEFT;
   if (source == language_menu_button_) {
     menu_model = &languages_menu_model_;
     button = language_menu_button_;
   } else {
     DCHECK_EQ(options_menu_button_, source);
     menu_model = &options_menu_model_;
     button = options_menu_button_;
     anchor = views::MenuItemView::TOPRIGHT;
   }
   RunMenuAt(menu_model, button, anchor);
-  // TODO(pkasting): this may be deleted after rewrite.
 }