Make infobars ignore button clicks when closing.

chrome/browser/ui/views/infobars/infobar_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_INFOBARS_INFOBAR_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_INFOBARS_INFOBAR_VIEW_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 33 matching lines @@
  protected:
   static const int kButtonButtonSpacing;
   static const int kEndOfLabelSpacing;
 
   virtual ~InfoBarView();
 
   // Creates a label with the appropriate font and color for an infobar.
   static views::Label* CreateLabel(const string16& text);
 
   // Creates a link with the appropriate font and color for an infobar.
+  // NOTE: Subclasses must ignore link clicks if we're unowned.
   static views::Link* CreateLink(const string16& text,
                                  views::LinkListener* listener,
                                  const SkColor& background_color);
 
   // Creates a menu button with an infobar-specific appearance.
+  // NOTE: Subclasses must ignore button presses if we're unowned.
   static views::MenuButton* CreateMenuButton(
       const string16& text,
       views::ViewMenuDelegate* menu_delegate);
 
   // Creates a text button with an infobar-specific appearance.
+  // NOTE: Subclasses must ignore button presses if we're unowned.
   static views::TextButton* CreateTextButton(views::ButtonListener* listener,
                                              const string16& text,
                                              bool needs_elevation);
 
   // views::View:
   virtual void Layout() OVERRIDE;
   virtual void ViewHierarchyChanged(bool is_add,
                                     View* parent,
                                     View* child) OVERRIDE;
 
   // views::ButtonListener:
+  // NOTE: This must not be called if we're unowned.  (Subclasses should ignore
+  // calls to ButtonPressed() in this case.)
   virtual void ButtonPressed(views::Button* sender,
                              const views::Event& event) OVERRIDE;
 
   // Returns the minimum width the content (that is, everything between the icon
   // and the close button) can be shrunk to.  This is used to prevent the close
   // button from overlapping views that cannot be shrunk any further.
   virtual int ContentMinimumWidth() const;
 
   // These return x coordinates delimiting the usable area for subclasses to lay
   // out their controls.
   int StartX() const;
   int EndX() const;
 
   // Convenience getter.
   const InfoBarContainer::Delegate* container_delegate() const;
 
-  // Show a menu at the specified position. By invoking this InfobarView ensures
-  // the menu is destroyed at the appropriate time.
+  // Shows a menu at the specified position.
+  // NOTE: This must not be called if we're unowned.  (Subclasses should ignore
+  // calls to RunMenu() in this case.)
   void RunMenuAt(ui::MenuModel* menu_model,
                  views::MenuButton* button,
                  views::MenuItemView::AnchorPosition anchor);
 
  private:
   static const int kHorizontalPadding;
 
   // InfoBar:
   virtual void PlatformSpecificShow(bool animate) OVERRIDE;
   virtual void PlatformSpecificHide(bool animate) OVERRIDE;
@@ skipping 23 matching lines @@
   SkPath fill_path_;
   SkPath stroke_path_;
 
   // Used to run the menu.
   scoped_ptr<views::MenuRunner> menu_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(InfoBarView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_INFOBARS_INFOBAR_VIEW_H_