Make infobars ignore button clicks when closing.

chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h"
 
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/translate/translate_infobar_delegate.h"
 #include "chrome/browser/ui/gtk/gtk_util.h"
@@ skipping 44 matching lines @@
                      FALSE, FALSE, 0);
   gtk_box_pack_start(GTK_BOX(hbox),
                      swapped_language_combos ? original_lang_combo :
                                                target_lang_combo,
                      FALSE, FALSE, 0);
   gtk_box_pack_start(GTK_BOX(hbox), CreateLabel(UTF16ToUTF8(strings[2])),
                      FALSE, FALSE, 0);
 
   GtkWidget* button = gtk_button_new_with_label(
       l10n_util::GetStringUTF8(IDS_TRANSLATE_INFOBAR_REVERT).c_str());
-  g_signal_connect(button, "clicked",G_CALLBACK(&OnRevertPressedThunk), this);
+  g_signal_connect(button, "clicked", G_CALLBACK(&OnRevertPressedThunk), this);
   gtk_box_pack_start(GTK_BOX(hbox), button, FALSE, FALSE, 0);
 }
 
 bool AfterTranslateInfoBar::ShowOptionsMenuButton() const {
   return true;
 }
 
 void AfterTranslateInfoBar::OnOriginalLanguageModified(GtkWidget* sender) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   size_t index = GetLanguageComboboxActiveId(GTK_COMBO_BOX(sender));
   if (index == GetDelegate()->original_language_index())
     return;
 
   // Setting the language will lead to a new translation that is going to close
   // the infobar.  This is not OK to do this from the signal handler, so we'll
   // defer it.
   MessageLoop::current()->PostTask(FROM_HERE, method_factory_.NewRunnableMethod(
       &AfterTranslateInfoBar::SetOriginalLanguage, index));
 }
 
 void AfterTranslateInfoBar::OnTargetLanguageModified(GtkWidget* sender) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   size_t index = GetLanguageComboboxActiveId(GTK_COMBO_BOX(sender));
   if (index == GetDelegate()->target_language_index())
     return;
 
   // See comment in OnOriginalLanguageModified on why we use a task.
   MessageLoop::current()->PostTask(FROM_HERE, method_factory_.NewRunnableMethod(
       &AfterTranslateInfoBar::SetTargetLanguage, index));
 }
 
 void AfterTranslateInfoBar::OnRevertPressed(GtkWidget* sender) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   GetDelegate()->RevertTranslation();
 }
 
 void AfterTranslateInfoBar::SetOriginalLanguage(size_t language_index) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   GetDelegate()->SetOriginalLanguage(language_index);
 }
 
 void AfterTranslateInfoBar::SetTargetLanguage(size_t language_index) {
+  if (!owned())
+    return;  // We're closing; don't call anything, it might access the owner.
   GetDelegate()->SetTargetLanguage(language_index);
 }