Make infobars ignore button clicks when closing.

chrome/browser/ui/cocoa/infobars/infobar_controller.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/cocoa_protocols.h"
 #include "base/memory/scoped_nsobject.h"
 
 @class AnimatableView;
@@ skipping 30 matching lines @@
   // text views cannot conveniently be created in IB. The xib file contains
   // a text field |labelPlaceholder_| that's replaced by this text view |label_|
   // in -awakeFromNib.
   scoped_nsobject<NSTextView> label_;
 };
 
 // Initializes a new InfoBarController.
 - (id)initWithDelegate:(InfoBarDelegate*)delegate
                  owner:(TabContentsWrapper*)owner;
 
+// Returns true if the infobar is owned.  If this is false, it is not safe to
+// call any delegate functions, since they might attempt to access the owner.
+- (bool)owned;

[Robert Sesek, 2011/09/22 16:49:56]

This should be an Obj-C BOOL and be YES/NO instead of true/false.

[Peter Kasting, 2011/09/22 21:55:25]

Done.

+
 // Called when someone clicks on the OK or Cancel buttons.  Subclasses
 // must override if they do not hide the buttons.
 - (void)ok:(id)sender;
 - (void)cancel:(id)sender;
 
-// Called when someone clicks on the close button.  Dismisses the
-// infobar without taking any action.
-- (IBAction)dismiss:(id)sender;

[Robert Sesek, 2011/09/22 16:49:56]

This needs to stay part of the public header because the XIB file (user
interface layout) still calls through this method.

[Peter Kasting, 2011/09/22 21:55:25]

sail informed me that it was safe to move this to private and I wouldn't break
the IB connection.  He also said there was some extra magic that could be done
to make the private method show up correctly in the IB GUI but that he didn't
know it.  I would like to make this private if I can, do you know the right
voodoo?

[Robert Sesek, 2011/09/24 19:20:16]

It's technically safe, but as some other entity is calling it, I'd consider it
part of the public interface and it should live there. You can document what
you'd prefer code to call and that it exists solely for the XIB.

[Peter Kasting, 2011/09/26 22:34:49]

Done.

+// Asks the container controller to remove the infobar for this delegate.  This
+// call will trigger a notification that starts the infobar animating closed.
+- (void)removeSelf;
 
 // Returns a pointer to this controller's view, cast as an AnimatableView.
 - (AnimatableView*)animatableView;
 
 // Open or animate open the infobar.
 - (void)open;
 - (void)animateOpen;
 
 // Close or animate close the infobar.
 - (void)close;
@@ skipping 28 matching lines @@
 @end
 
 
 @interface ConfirmInfoBarController : InfoBarController
 // Called when the OK and Cancel buttons are clicked.
 - (IBAction)ok:(id)sender;
 - (IBAction)cancel:(id)sender;
 // Called when there is a click on the link in the infobar.
 - (void)linkClicked;
 @end