Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 7981040: Make chrome.tabs.update's tabId parameter optional. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Mihai's comments addressed. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 6
7 #include "chrome/browser/prefs/incognito_mode_prefs.h" 7 #include "chrome/browser/prefs/incognito_mode_prefs.h"
8 #include "chrome/browser/prefs/pref_service.h" 8 #include "chrome/browser/prefs/pref_service.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 prefs::kHomePageIsNewTabPage, true); 69 prefs::kHomePageIsNewTabPage, true);
70 70
71 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud.html")) << message_; 71 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud.html")) << message_;
72 } 72 }
73 73
74 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Tabs2) { 74 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Tabs2) {
75 ASSERT_TRUE(StartTestServer()); 75 ASSERT_TRUE(StartTestServer());
76 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud2.html")) << message_; 76 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud2.html")) << message_;
77 } 77 }
78 78
79 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabUpdate) {
80 ASSERT_TRUE(StartTestServer());
81 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "update.html")) << message_;
82 }
83
79 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabPinned) { 84 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabPinned) {
80 ASSERT_TRUE(StartTestServer()); 85 ASSERT_TRUE(StartTestServer());
81 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "pinned.html")) << message_; 86 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "pinned.html")) << message_;
82 } 87 }
83 88
84 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_TabMove) { 89 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_TabMove) {
85 ASSERT_TRUE(StartTestServer()); 90 ASSERT_TRUE(StartTestServer());
86 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "move.html")) << message_; 91 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "move.html")) << message_;
87 } 92 }
88 93
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedPopup) { 223 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedPopup) {
219 ASSERT_TRUE(StartTestServer()); 224 ASSERT_TRUE(StartTestServer());
220 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html")) 225 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))
221 << message_; 226 << message_;
222 } 227 }
223 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedWindow) { 228 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedWindow) {
224 ASSERT_TRUE(StartTestServer()); 229 ASSERT_TRUE(StartTestServer());
225 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html")) 230 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))
226 << message_; 231 << message_;
227 } 232 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698