Make chrome.tabs.update's tabId parameter optional.

chrome/test/data/extensions/api_test/tabs/basics/update.js

+var tabIds = new Array();

[Mihai Parparita -not on Chrome, 2011/09/21 23:24:05]

The presubmit check will nag you about a missing license block in the .js file.

Also, var tabIds = [] is preferred to using new Array.

[miket_OOO, 2011/09/22 00:06:44]

Everything in this file is fixed.

+var kFooUrl = "foo";
+var kBarUrl = "bar";
+var kBazUrl = "baz";
+
+chrome.test.runTests([
+
+    function setUp() {
+      chrome.tabs.create({"url": pageUrl("a")}, function(tab) {
+          tabIds.push(tab.id);
+        });
+      chrome.tabs.create({"url": pageUrl("b")}, function(tab) {
+          tabIds.push(tab.id);
+        });
+      chrome.tabs.create({"url": pageUrl("c")}, function(tab) {
+          tabIds.push(tab.id);
+        });
+      chrome.windows.create({"url": pageUrl("xxx")}, pass(function(tab) {}));
+    },
+
+    function testBasicSetup() {
+      chrome.tabs.get(tabIds[0], pass(function(tab) {
+            assertEq(pageUrl("a"), tab.url);
+          }));
+      chrome.tabs.get(tabIds[1], pass(function(tab) {
+            assertEq(pageUrl("b"), tab.url);
+          }));
+      chrome.tabs.get(tabIds[2], pass(function(tab) {
+            assertEq(pageUrl("c"), tab.url);
+          }));
+    },
+
+    function testUpdatingBySpecificTabIds() {

[Mihai Parparita -not on Chrome, 2011/09/21 23:24:05]

This is already tested by update in crud2.html.

+      chrome.tabs.update(
+          tabIds[0],
+          {"url": pageUrl(kFooUrl)},
+          pass(function(tab) {
+              chrome.tabs.get(
+                  tabIds[0],
+                  pass(function(tab) {
+                      assertEq(pageUrl(kFooUrl), tab.url);
+                    }));}));
+    },
+
+    function testUpdatingDefaultTabViaUndefined() {
+      chrome.tabs.update(
+          tabIds[1],
+          {"selected": true},
+          pass(function(tab) {
+              chrome.tabs.update(
+                  undefined,
+                  {"url": pageUrl(kBarUrl)},
+                  pass(function(tab) {
+                      chrome.tabs.get(
+                          tabIds[1],
+                          pass(function(tab) {
+                              assertEq(pageUrl(kBarUrl), tab.url);
+                            }));}));}));

[Mihai Parparita -not on Chrome, 2011/09/21 23:24:05]

This looks hard to read or edit, perhaps keeping the closing braces on their own
lines at the indentation levels that they were opened at would help (see nested
callbacks in crud2.html and other test).

+    },
+
+    function testUpdatingDefaultTabViaNull() {
+      chrome.tabs.update(
+          tabIds[2],
+          {"selected": true},
+          pass(function(tab) {
+              chrome.tabs.update(
+                  null,
+                  {"url": pageUrl(kBazUrl)},
+                  pass(function(tab) {
+                      chrome.tabs.get(
+                          tabIds[2],
+                          pass(function(tab) {
+                              assertEq(pageUrl(kBazUrl), tab.url);
+                            }));}));}));
+    }
+]);