Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 7981033: Deflake PrerenderBrowserTest.PrerenderClientRedirectInIframe. (Closed)

Created:
9 years, 3 months ago by mmenke
Modified:
9 years, 3 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke, Paweł Hajdan Jr.
Visibility:
Public.

Description

Deflake PrerenderBrowserTest.PrerenderClientRedirectInIframe. What seems to be happening is that the client redirect can result in starting and stopping the page loading again. As a result, we quit the message loop when the second load finishes as well as the first, which can occur either while we're waiting for the result of a Javascript function, or while we're waiting for the navigation to occur. Either case will result in a test failure. BUG=88973 TEST=PrerenderBrowserTest.PrerenderClientRedirectInIframe (And probably PrerenderBrowserTest.PrerenderClientRedirectToHttpsInIframe) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102431

Patch Set 1 : '' #

Patch Set 2 : update comment #

Patch Set 3 : Slightly different solution #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mmenke
Both changes aren't necessary, either one alone should do the trick, but in retrospect, quitting ...
9 years, 3 months ago (2011-09-22 03:35:44 UTC) #1
cbentzel
LGTM
9 years, 3 months ago (2011-09-22 19:26:32 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/7981033/3004
9 years, 3 months ago (2011-09-22 20:24:58 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 3 months ago (2011-09-23 00:02:20 UTC) #4
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/7981033/3004
9 years, 3 months ago (2011-09-23 00:05:49 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-23 02:37:02 UTC) #6
Change committed as 102431

Powered by Google App Engine
This is Rietveld 408576698