Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1600)

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 7981027: Fix the clock values in PhishingDOMFeatureExtractorTest.Continuation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
index e18d938ed266dee5f10bcf704e683756ad4bc9b5..548c172505e29aa02df8ef20cd167a352475c506 100644
--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
@@ -255,7 +255,7 @@ TEST_F(PhishingDOMFeatureExtractorTest, Continuation) {
response.append("<form action=\"http://host2.com/\"></form></body></html>");
responses_["http://host.com/"] = response;
- // Advance the clock 8 ms every 10 elements processed, 10 ms between chunks.
+ // Advance the clock 12 ms every 10 elements processed, 10 ms between chunks.
// Note that this assumes kClockCheckGranularity = 10 and
// kMaxTimePerChunkMs = 20.
base::TimeTicks now = base::TimeTicks::Now();
@@ -265,27 +265,27 @@ TEST_F(PhishingDOMFeatureExtractorTest, Continuation) {
// Time check at the start of the first chunk of work.
.WillOnce(Return(now))
// Time check after the first 10 elements.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(8)))
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(12)))
// Time check after the next 10 elements. This is over the chunk
// time limit, so a continuation task will be posted.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(16)))
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(24)))
// Time check at the start of the second chunk of work.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(26)))
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(34)))
// Time check after resuming iteration for the second chunk.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(28)))
- // Time check after the next 10 elements.
.WillOnce(Return(now + base::TimeDelta::FromMilliseconds(36)))
+ // Time check after the next 10 elements.
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(48)))
// Time check after the next 10 elements. This will trigger another
// continuation task.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(44)))
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(60)))
// Time check at the start of the third chunk of work.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(54)))
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(70)))
// Time check after resuming iteration for the third chunk.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(56)))
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(72)))
// Time check after the last 10 elements.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(64)))
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(84)))
// A final time check for the histograms.
- .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(66)));
+ .WillOnce(Return(now + base::TimeDelta::FromMilliseconds(86)));
FeatureMap expected_features;
expected_features.AddBooleanFeature(features::kPageHasForms);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698