Issue 7981025: Use P2P Transport API by default.

Issue 7981025: Use P2P Transport API by default. (Closed)

Created:
9 years, 3 months ago by Sergey Ulanov

Modified:
9 years, 3 months ago

Reviewers:
Wez, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use P2P Transport API by default. BUG=51198 TEST=chromoting client still works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102297

Patch Set 1 #

Patch Set 2 : - #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -72 lines)			Patch
M	remoting/client/plugin/chromoting_instance.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View	1	2 chunks	+5 lines, -34 lines	2 comments	Download
M	remoting/client/plugin/chromoting_scriptable_object.cc	View		3 chunks	+1 line, -11 lines	0 comments	Download
M	remoting/webapp/me2mom/client_session.js	View		1 chunk	+2 lines, -7 lines	0 comments	Download
M	remoting/webapp/me2mom/remoting.js	View		3 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jamie

Wez has offered to look at this for me, and I think he's better qualified.

9 years, 3 months ago (2011-09-21 19:25:47 UTC) #2

Wez

LGTM http://codereview.chromium.org/7981025/diff/1006/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): http://codereview.chromium.org/7981025/diff/1006/remoting/client/plugin/chromoting_instance.cc#newcode174 remoting/client/plugin/chromoting_instance.cc:174: enable_client_nat_traversal_)); Will the ConnectionToHost be updated in a ...

9 years, 3 months ago (2011-09-22 11:24:56 UTC) #3

Sergey Ulanov

9 years, 3 months ago (2011-09-22 17:07:45 UTC) #4

http://codereview.chromium.org/7981025/diff/1006/remoting/client/plugin/chrom...
File remoting/client/plugin/chromoting_instance.cc (right):

http://codereview.chromium.org/7981025/diff/1006/remoting/client/plugin/chrom...
remoting/client/plugin/chromoting_instance.cc:174:
enable_client_nat_traversal_));
On 2011/09/22 11:24:56, Wez wrote:
> Will the ConnectionToHost be updated in a subsequent CL, to remove the
no-longer
> used constructor parameters?
Yes.

Expand Messages | Collapse Messages